From: Sebastian Reichel <sre@debian.org> To: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: "Benoît Cousson" <bcousson@baylibre.com>, "Tony Lindgren" <tony@atomide.com>, "Rob Herring" <rob.herring@calxeda.com>, "Pawel Moll" <pawel.moll@arm.com>, "Mark Rutland" <mark.rutland@arm.com>, "Stephen Warren" <swarren@wwwdotorg.org>, "Ian Campbell" <ijc+devicetree@hellion.org.uk>, "Rob Landley" <rob@landley.net>, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 0/4] OMAPDSS: DT support for N900 panel Date: Thu, 19 Dec 2013 11:08:40 +0100 [thread overview] Message-ID: <20131219100840.GA923@earth.universe> (raw) In-Reply-To: <52B2848A.80807@ti.com> [-- Attachment #1: Type: text/plain, Size: 3487 bytes --] On Thu, Dec 19, 2013 at 07:30:50AM +0200, Tomi Valkeinen wrote: > On 2013-12-19 02:51, Sebastian Reichel wrote: > > On Wed, Dec 18, 2013 at 10:55:37PM +0100, Sebastian Reichel wrote: > >> On Tue, Dec 17, 2013 at 07:29:34PM +0200, Tomi Valkeinen wrote: > >>>>> I added N900 display DT support on top of my v2 series, including > >>>>> pinmuxing. Can you check if it looks right and works? > >>>>> > >>>>> git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git work/dss-dt > >>>> > >>>> I just tried it and it does not work. On a first look the pinmuxing > >>>> looks fishy: 0x0d4 is muxed two times. > >>> > >>> Hmm, so it is. > >>> > >>> I'm not really familiar with SDI, I just muxed all the SDI pins, except > >>> datapair3. I previously thought that there's only the data and clock > >>> pairs for SDI, but the TRM revealed more sdi pins, so I included them. > >>> It is well possible that these can be removed: > >>> > >>> 0x0d0 (PIN_OUTPUT | MUX_MODE1) /* dss_data18.sdi_vsync */ > >>> 0x0d2 (PIN_OUTPUT | MUX_MODE1) /* dss_data19.sdi_hsync */ > >>> 0x0d4 (PIN_OUTPUT | MUX_MODE1) /* dss_data20.sdi_den */ > >>> 0x0d6 (PIN_OUTPUT | MUX_MODE1) /* dss_data21.sdi_stp */ > >> > >> Just removing the dss_data20.sdi_den pin was enough to get a working display. I > >> don't know if the other pins are needed, because the display pins are already > >> muxed correctly by the bootloader. > > > > I just had a look in the leaked n900 schematics. According to it the > > following pins are connected to the display: > > > > DSS_DATA20 (E28) GPIO 90 LCD_RST > > DSS_DATA10 (AD28) SDI_DAT1N CDP 0 > > DSS_DATA11 (AD27) SDI_DAT1P CDP 1 > > DSS_DATA12 (AB28) SDI_DAT2N CDP 2 > > DSS_DATA13 (AB27) SDI_DAT2P CDP 3 > > DSS_DATA14 (AA28) SDI_DAT3N CDP 4 > > DSS_DATA15 (AA27) SDI_DAT3P CDP 5 > > DSS_DATA22 (AC27) SDI_CLKP CDP 6 > > DSS_DATA23 (AC28) SDI_CLKN CDP 7 > > > > I also noticed that dss_data19.sdi_hsync is used as gpio 89 for the > > N900's proximity sensor. Thus I suggest the following SDI pin muxing: > > > > dss_sdi_pins: pinmux_dss_sdi_pins { > > pinctrl-single,pins = < > > 0x0c0 (PIN_OUTPUT | MUX_MODE1) /* dss_data10.sdi_dat1n */ > > 0x0c2 (PIN_OUTPUT | MUX_MODE1) /* dss_data11.sdi_dat1p */ > > 0x0c4 (PIN_OUTPUT | MUX_MODE1) /* dss_data12.sdi_dat2n */ > > 0x0c6 (PIN_OUTPUT | MUX_MODE1) /* dss_data13.sdi_dat2p */ > > 0x0c8 (PIN_OUTPUT | MUX_MODE1) /* dss_data14.sdi_dat3n */ > > 0x0ca (PIN_OUTPUT | MUX_MODE1) /* dss_data15.sdi_dat3p */ > > > > 0x0d8 (PIN_OUTPUT | MUX_MODE1) /* dss_data22.sdi_clkp */ > > 0x0da (PIN_OUTPUT | MUX_MODE1) /* dss_data23.sdi_clkn */ > > >; > > }; > > Thanks, I'll do the modifications. The dat3 lines are not needed, but if > they're connected to the panel, I don't see any harm in muxing them. > > Although, makes me wonder. If the panel supports only 2 datalanes, why > does it have connectors for 3? And if it supports 3, why would N900 use > only 2? I wondered about the same and I also assumed, that the muxing should be safe. > Are you able to check if the bootloader muxes dat3 to SDI mode? The bootloader's source code is not available as far as i know. I tried to cat /sys/kernel/debug/pinctrl/48002030.pinmux/pins, but I get an external abort on non-linefetch. So I can't check it :( -- Sebastian [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sre@debian.org> To: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: "Benoît Cousson" <bcousson@baylibre.com>, "Tony Lindgren" <tony@atomide.com>, "Rob Herring" <rob.herring@calxeda.com>, "Pawel Moll" <pawel.moll@arm.com>, "Mark Rutland" <mark.rutland@arm.com>, "Stephen Warren" <swarren@wwwdotorg.org>, "Ian Campbell" <ijc+devicetree@hellion.org.uk>, "Rob Landley" <rob@landley.net>, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 0/4] OMAPDSS: DT support for N900 panel Date: Thu, 19 Dec 2013 10:08:40 +0000 [thread overview] Message-ID: <20131219100840.GA923@earth.universe> (raw) In-Reply-To: <52B2848A.80807@ti.com> [-- Attachment #1: Type: text/plain, Size: 3487 bytes --] On Thu, Dec 19, 2013 at 07:30:50AM +0200, Tomi Valkeinen wrote: > On 2013-12-19 02:51, Sebastian Reichel wrote: > > On Wed, Dec 18, 2013 at 10:55:37PM +0100, Sebastian Reichel wrote: > >> On Tue, Dec 17, 2013 at 07:29:34PM +0200, Tomi Valkeinen wrote: > >>>>> I added N900 display DT support on top of my v2 series, including > >>>>> pinmuxing. Can you check if it looks right and works? > >>>>> > >>>>> git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git work/dss-dt > >>>> > >>>> I just tried it and it does not work. On a first look the pinmuxing > >>>> looks fishy: 0x0d4 is muxed two times. > >>> > >>> Hmm, so it is. > >>> > >>> I'm not really familiar with SDI, I just muxed all the SDI pins, except > >>> datapair3. I previously thought that there's only the data and clock > >>> pairs for SDI, but the TRM revealed more sdi pins, so I included them. > >>> It is well possible that these can be removed: > >>> > >>> 0x0d0 (PIN_OUTPUT | MUX_MODE1) /* dss_data18.sdi_vsync */ > >>> 0x0d2 (PIN_OUTPUT | MUX_MODE1) /* dss_data19.sdi_hsync */ > >>> 0x0d4 (PIN_OUTPUT | MUX_MODE1) /* dss_data20.sdi_den */ > >>> 0x0d6 (PIN_OUTPUT | MUX_MODE1) /* dss_data21.sdi_stp */ > >> > >> Just removing the dss_data20.sdi_den pin was enough to get a working display. I > >> don't know if the other pins are needed, because the display pins are already > >> muxed correctly by the bootloader. > > > > I just had a look in the leaked n900 schematics. According to it the > > following pins are connected to the display: > > > > DSS_DATA20 (E28) GPIO 90 LCD_RST > > DSS_DATA10 (AD28) SDI_DAT1N CDP 0 > > DSS_DATA11 (AD27) SDI_DAT1P CDP 1 > > DSS_DATA12 (AB28) SDI_DAT2N CDP 2 > > DSS_DATA13 (AB27) SDI_DAT2P CDP 3 > > DSS_DATA14 (AA28) SDI_DAT3N CDP 4 > > DSS_DATA15 (AA27) SDI_DAT3P CDP 5 > > DSS_DATA22 (AC27) SDI_CLKP CDP 6 > > DSS_DATA23 (AC28) SDI_CLKN CDP 7 > > > > I also noticed that dss_data19.sdi_hsync is used as gpio 89 for the > > N900's proximity sensor. Thus I suggest the following SDI pin muxing: > > > > dss_sdi_pins: pinmux_dss_sdi_pins { > > pinctrl-single,pins = < > > 0x0c0 (PIN_OUTPUT | MUX_MODE1) /* dss_data10.sdi_dat1n */ > > 0x0c2 (PIN_OUTPUT | MUX_MODE1) /* dss_data11.sdi_dat1p */ > > 0x0c4 (PIN_OUTPUT | MUX_MODE1) /* dss_data12.sdi_dat2n */ > > 0x0c6 (PIN_OUTPUT | MUX_MODE1) /* dss_data13.sdi_dat2p */ > > 0x0c8 (PIN_OUTPUT | MUX_MODE1) /* dss_data14.sdi_dat3n */ > > 0x0ca (PIN_OUTPUT | MUX_MODE1) /* dss_data15.sdi_dat3p */ > > > > 0x0d8 (PIN_OUTPUT | MUX_MODE1) /* dss_data22.sdi_clkp */ > > 0x0da (PIN_OUTPUT | MUX_MODE1) /* dss_data23.sdi_clkn */ > > >; > > }; > > Thanks, I'll do the modifications. The dat3 lines are not needed, but if > they're connected to the panel, I don't see any harm in muxing them. > > Although, makes me wonder. If the panel supports only 2 datalanes, why > does it have connectors for 3? And if it supports 3, why would N900 use > only 2? I wondered about the same and I also assumed, that the muxing should be safe. > Are you able to check if the bootloader muxes dat3 to SDI mode? The bootloader's source code is not available as far as i know. I tried to cat /sys/kernel/debug/pinctrl/48002030.pinmux/pins, but I get an external abort on non-linefetch. So I can't check it :( -- Sebastian [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-19 10:08 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-12-13 18:17 [PATCH 0/4] OMAPDSS: DT support for N900 panel Sebastian Reichel 2013-12-13 18:17 ` Sebastian Reichel 2013-12-13 18:17 ` [PATCH 1/4] OMAPDSS: Add DT support to SDI Sebastian Reichel 2013-12-13 18:17 ` Sebastian Reichel 2013-12-13 18:17 ` [PATCH 2/4] OMAPDSS: ACX565AKM: Add DT support Sebastian Reichel 2013-12-13 18:17 ` Sebastian Reichel 2013-12-13 18:17 ` [PATCH 3/4] ARM: OMAP: rx51: DT boot: disable legacy dss init Sebastian Reichel 2013-12-13 18:17 ` Sebastian Reichel 2013-12-13 18:17 ` [PATCH 4/4] ARM: dts: omap3-n900: Add display support Sebastian Reichel 2013-12-13 18:17 ` Sebastian Reichel 2013-12-17 7:37 ` [PATCH 0/4] OMAPDSS: DT support for N900 panel Tomi Valkeinen 2013-12-17 7:37 ` Tomi Valkeinen 2013-12-17 17:14 ` Sebastian Reichel 2013-12-17 17:14 ` Sebastian Reichel 2013-12-17 17:29 ` Tomi Valkeinen 2013-12-17 17:29 ` Tomi Valkeinen 2013-12-18 21:55 ` Sebastian Reichel 2013-12-18 21:55 ` Sebastian Reichel 2013-12-19 0:51 ` Sebastian Reichel 2013-12-19 0:51 ` Sebastian Reichel 2013-12-19 5:30 ` Tomi Valkeinen 2013-12-19 5:30 ` Tomi Valkeinen 2013-12-19 10:08 ` Sebastian Reichel [this message] 2013-12-19 10:08 ` Sebastian Reichel [not found] ` <20131219100840.GA923-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org> 2013-12-19 13:56 ` Sebastian Reichel 2013-12-19 13:56 ` Sebastian Reichel 2013-12-19 16:42 ` Tony Lindgren 2013-12-19 16:42 ` Tony Lindgren 2013-12-19 17:00 ` Sebastian Reichel 2013-12-19 17:00 ` Sebastian Reichel 2013-12-19 18:34 ` Tony Lindgren 2013-12-19 18:34 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20131219100840.GA923@earth.universe \ --to=sre@debian.org \ --cc=bcousson@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=rob.herring@calxeda.com \ --cc=rob@landley.net \ --cc=swarren@wwwdotorg.org \ --cc=tomi.valkeinen@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.