* [PATCH 0/2] Add Ether's PHY IRQ support for R8A7790/Lager board
@ 2013-12-19 23:18 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2013-12-19 23:18 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.13-rc4-20131219' tag. Here we add support for the Ether's PHY
IRQ to the R8A7790/Lager board. The patchset depends on the two 'sh_eth' driver
patches posted earlier in order to compile and work. It would be good if Dave Miller
could merge these patches thru his tree, along with 'sh_eth' patches as this
would have prevented delaying these patches to 3.15 which seems inevitable
otherwise (well, unless Simon merges net-next to his tree?). I'll rebase the
patches to the 'net-next.git' repo if Dave consents to merging them...
[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
2013-12-19 23:18 ` Sergei Shtylyov
@ 2013-12-19 23:19 ` Sergei Shtylyov
-1 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2013-12-19 22:19 UTC (permalink / raw)
To: linux-arm-kernel
Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
trigger type to be low-level as per the Micrel PHY driver's setup.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm/mach-shmobile/board-lager.c | 4 ++++
1 file changed, 4 insertions(+)
Index: renesas/arch/arm/mach-shmobile/board-lager.c
=================================--- renesas.orig/arch/arm/mach-shmobile/board-lager.c
+++ renesas/arch/arm/mach-shmobile/board-lager.c
@@ -22,6 +22,7 @@
#include <linux/gpio_keys.h>
#include <linux/input.h>
#include <linux/interrupt.h>
+#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/mmc/host.h>
@@ -228,6 +229,7 @@ static const struct resource mmcif1_reso
/* Ether */
static const struct sh_eth_plat_data ether_pdata __initconst = {
.phy = 0x1,
+ .phy_irq = irq_pin(0),
.edmac_endian = EDMAC_LITTLE_ENDIAN,
.phy_interface = PHY_INTERFACE_MODE_RMII,
.ether_link_active_low = 1,
@@ -391,6 +393,8 @@ static void __init lager_init(void)
{
lager_add_standard_devices();
+ irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW);
+
if (IS_ENABLED(CONFIG_PHYLIB))
phy_register_fixup_for_id("r8a7790-ether-ff:01",
lager_ksz8041_fixup);
^ permalink raw reply [flat|nested] 36+ messages in thread* [PATCH 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
@ 2013-12-19 23:19 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2013-12-19 23:19 UTC (permalink / raw)
To: linux-arm-kernel
Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
trigger type to be low-level as per the Micrel PHY driver's setup.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm/mach-shmobile/board-lager.c | 4 ++++
1 file changed, 4 insertions(+)
Index: renesas/arch/arm/mach-shmobile/board-lager.c
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/board-lager.c
+++ renesas/arch/arm/mach-shmobile/board-lager.c
@@ -22,6 +22,7 @@
#include <linux/gpio_keys.h>
#include <linux/input.h>
#include <linux/interrupt.h>
+#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/mmc/host.h>
@@ -228,6 +229,7 @@ static const struct resource mmcif1_reso
/* Ether */
static const struct sh_eth_plat_data ether_pdata __initconst = {
.phy = 0x1,
+ .phy_irq = irq_pin(0),
.edmac_endian = EDMAC_LITTLE_ENDIAN,
.phy_interface = PHY_INTERFACE_MODE_RMII,
.ether_link_active_low = 1,
@@ -391,6 +393,8 @@ static void __init lager_init(void)
{
lager_add_standard_devices();
+ irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW);
+
if (IS_ENABLED(CONFIG_PHYLIB))
phy_register_fixup_for_id("r8a7790-ether-ff:01",
lager_ksz8041_fixup);
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
2013-12-19 23:19 ` Sergei Shtylyov
@ 2014-01-07 1:02 ` Simon Horman
-1 siblings, 0 replies; 36+ messages in thread
From: Simon Horman @ 2014-01-07 1:02 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 20, 2013 at 02:19:30AM +0300, Sergei Shtylyov wrote:
> Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
> trigger type to be low-level as per the Micrel PHY driver's setup.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Hi Sergei,
for better or for worse I believe this is a v3.15 candidate.
Could you repost it once v3.14-rc1 has been released,
I believe it will include the dependencies of this patch.
Thanks
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
@ 2014-01-07 1:02 ` Simon Horman
0 siblings, 0 replies; 36+ messages in thread
From: Simon Horman @ 2014-01-07 1:02 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 20, 2013 at 02:19:30AM +0300, Sergei Shtylyov wrote:
> Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
> trigger type to be low-level as per the Micrel PHY driver's setup.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Hi Sergei,
for better or for worse I believe this is a v3.15 candidate.
Could you repost it once v3.14-rc1 has been released,
I believe it will include the dependencies of this patch.
Thanks
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
2013-12-19 23:19 ` Sergei Shtylyov
@ 2014-01-17 6:00 ` Magnus Damm
-1 siblings, 0 replies; 36+ messages in thread
From: Magnus Damm @ 2014-01-17 6:00 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 20, 2013 at 8:19 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
> trigger type to be low-level as per the Micrel PHY driver's setup.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> arch/arm/mach-shmobile/board-lager.c | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks for your efforts. The code looks fine. I have now also tested
this on my Lager board.
Acked-by: Magnus Damm <damm@opensource.se>
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
@ 2014-01-17 6:00 ` Magnus Damm
0 siblings, 0 replies; 36+ messages in thread
From: Magnus Damm @ 2014-01-17 6:00 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 20, 2013 at 8:19 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
> trigger type to be low-level as per the Micrel PHY driver's setup.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> arch/arm/mach-shmobile/board-lager.c | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks for your efforts. The code looks fine. I have now also tested
this on my Lager board.
Acked-by: Magnus Damm <damm@opensource.se>
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
2014-01-17 6:00 ` Magnus Damm
@ 2014-01-20 0:31 ` Simon Horman
-1 siblings, 0 replies; 36+ messages in thread
From: Simon Horman @ 2014-01-20 0:31 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 17, 2014 at 03:00:29PM +0900, Magnus Damm wrote:
> On Fri, Dec 20, 2013 at 8:19 AM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
> > trigger type to be low-level as per the Micrel PHY driver's setup.
> >
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > ---
> > arch/arm/mach-shmobile/board-lager.c | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> Thanks for your efforts. The code looks fine. I have now also tested
> this on my Lager board.
>
> Acked-by: Magnus Damm <damm@opensource.se>
Hi Sergei,
please repost this patch with Magnus's ack once an rc release is
available with the pre-requisites of this patch.
Thanks
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
@ 2014-01-20 0:31 ` Simon Horman
0 siblings, 0 replies; 36+ messages in thread
From: Simon Horman @ 2014-01-20 0:31 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 17, 2014 at 03:00:29PM +0900, Magnus Damm wrote:
> On Fri, Dec 20, 2013 at 8:19 AM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
> > trigger type to be low-level as per the Micrel PHY driver's setup.
> >
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > ---
> > arch/arm/mach-shmobile/board-lager.c | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> Thanks for your efforts. The code looks fine. I have now also tested
> this on my Lager board.
>
> Acked-by: Magnus Damm <damm@opensource.se>
Hi Sergei,
please repost this patch with Magnus's ack once an rc release is
available with the pre-requisites of this patch.
Thanks
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
2013-12-19 23:18 ` Sergei Shtylyov
@ 2013-12-19 23:20 ` Sergei Shtylyov
-1 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2013-12-19 22:20 UTC (permalink / raw)
To: linux-arm-kernel
Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we intend
to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm/mach-shmobile/Kconfig | 2 ++
1 file changed, 2 insertions(+)
Index: renesas/arch/arm/mach-shmobile/Kconfig
=================================--- renesas.orig/arch/arm/mach-shmobile/Kconfig
+++ renesas/arch/arm/mach-shmobile/Kconfig
@@ -54,6 +54,7 @@ config MACH_KZM9D
config MACH_LAGER
bool "Lager board"
depends on ARCH_R8A7790
+ select MICREL_PHY if SH_ETH
comment "Renesas ARM SoCs System Configuration"
endif
@@ -261,6 +262,7 @@ config MACH_LAGER
bool "Lager board"
depends on ARCH_R8A7790
select USE_OF
+ select MICREL_PHY if SH_ETH
config MACH_KOELSCH
bool "Koelsch board"
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
@ 2013-12-19 23:20 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2013-12-19 23:20 UTC (permalink / raw)
To: linux-arm-kernel
Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we intend
to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm/mach-shmobile/Kconfig | 2 ++
1 file changed, 2 insertions(+)
Index: renesas/arch/arm/mach-shmobile/Kconfig
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/Kconfig
+++ renesas/arch/arm/mach-shmobile/Kconfig
@@ -54,6 +54,7 @@ config MACH_KZM9D
config MACH_LAGER
bool "Lager board"
depends on ARCH_R8A7790
+ select MICREL_PHY if SH_ETH
comment "Renesas ARM SoCs System Configuration"
endif
@@ -261,6 +262,7 @@ config MACH_LAGER
bool "Lager board"
depends on ARCH_R8A7790
select USE_OF
+ select MICREL_PHY if SH_ETH
config MACH_KOELSCH
bool "Koelsch board"
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
2013-12-19 23:20 ` Sergei Shtylyov
@ 2013-12-23 0:53 ` Simon Horman
-1 siblings, 0 replies; 36+ messages in thread
From: Simon Horman @ 2013-12-23 0:53 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 20, 2013 at 02:20:54AM +0300, Sergei Shtylyov wrote:
> Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we intend
> to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
> Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Hi Sergei,
while I am very happy to see this change unfortunately it no longer
applies. Could you please rebase it on top of
renesas-devel-v3.13-rc4-20131219?
Thanks
>
> ---
> arch/arm/mach-shmobile/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: renesas/arch/arm/mach-shmobile/Kconfig
> =================================> --- renesas.orig/arch/arm/mach-shmobile/Kconfig
> +++ renesas/arch/arm/mach-shmobile/Kconfig
> @@ -54,6 +54,7 @@ config MACH_KZM9D
> config MACH_LAGER
> bool "Lager board"
> depends on ARCH_R8A7790
> + select MICREL_PHY if SH_ETH
>
> comment "Renesas ARM SoCs System Configuration"
> endif
> @@ -261,6 +262,7 @@ config MACH_LAGER
> bool "Lager board"
> depends on ARCH_R8A7790
> select USE_OF
> + select MICREL_PHY if SH_ETH
>
> config MACH_KOELSCH
> bool "Koelsch board"
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
@ 2013-12-23 0:53 ` Simon Horman
0 siblings, 0 replies; 36+ messages in thread
From: Simon Horman @ 2013-12-23 0:53 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 20, 2013 at 02:20:54AM +0300, Sergei Shtylyov wrote:
> Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we intend
> to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
> Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Hi Sergei,
while I am very happy to see this change unfortunately it no longer
applies. Could you please rebase it on top of
renesas-devel-v3.13-rc4-20131219?
Thanks
>
> ---
> arch/arm/mach-shmobile/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: renesas/arch/arm/mach-shmobile/Kconfig
> ===================================================================
> --- renesas.orig/arch/arm/mach-shmobile/Kconfig
> +++ renesas/arch/arm/mach-shmobile/Kconfig
> @@ -54,6 +54,7 @@ config MACH_KZM9D
> config MACH_LAGER
> bool "Lager board"
> depends on ARCH_R8A7790
> + select MICREL_PHY if SH_ETH
>
> comment "Renesas ARM SoCs System Configuration"
> endif
> @@ -261,6 +262,7 @@ config MACH_LAGER
> bool "Lager board"
> depends on ARCH_R8A7790
> select USE_OF
> + select MICREL_PHY if SH_ETH
>
> config MACH_KOELSCH
> bool "Koelsch board"
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
2013-12-23 0:53 ` Simon Horman
@ 2013-12-23 18:57 ` Sergei Shtylyov
-1 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2013-12-23 17:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 12/23/2013 03:53 AM, Simon Horman wrote:
>> Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we intend
>> to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
>> Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Hi Sergei,
> while I am very happy to see this change unfortunately it no longer
> applies. Could you please rebase it on top of
> renesas-devel-v3.13-rc4-20131219?
Hmm, it *was done* on top of this tag. Perhaps you meant today's
renesas-devel-v3.13-rc5-20131223?
> Thanks
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread* [PATCH 2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
@ 2013-12-23 18:57 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2013-12-23 18:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 12/23/2013 03:53 AM, Simon Horman wrote:
>> Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we intend
>> to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
>> Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Hi Sergei,
> while I am very happy to see this change unfortunately it no longer
> applies. Could you please rebase it on top of
> renesas-devel-v3.13-rc4-20131219?
Hmm, it *was done* on top of this tag. Perhaps you meant today's
renesas-devel-v3.13-rc5-20131223?
> Thanks
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
2013-12-23 18:57 ` Sergei Shtylyov
@ 2013-12-23 19:08 ` Sergei Shtylyov
-1 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2013-12-23 18:08 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 12/23/2013 09:57 PM, Sergei Shtylyov wrote:
>>> Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we
>>> intend
>>> to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
>>> Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Hi Sergei,
>> while I am very happy to see this change unfortunately it no longer
>> applies. Could you please rebase it on top of
>> renesas-devel-v3.13-rc4-20131219?
> Hmm, it *was done* on top of this tag. Perhaps you meant today's
> renesas-devel-v3.13-rc5-20131223?
It continues to apply even to that tag seamlessly. Some issue must be on
your side...
>> Thanks
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread* [PATCH 2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
@ 2013-12-23 19:08 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2013-12-23 19:08 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 12/23/2013 09:57 PM, Sergei Shtylyov wrote:
>>> Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we
>>> intend
>>> to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
>>> Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Hi Sergei,
>> while I am very happy to see this change unfortunately it no longer
>> applies. Could you please rebase it on top of
>> renesas-devel-v3.13-rc4-20131219?
> Hmm, it *was done* on top of this tag. Perhaps you meant today's
> renesas-devel-v3.13-rc5-20131223?
It continues to apply even to that tag seamlessly. Some issue must be on
your side...
>> Thanks
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
2013-12-23 19:08 ` Sergei Shtylyov
@ 2013-12-24 2:55 ` Simon Horman
-1 siblings, 0 replies; 36+ messages in thread
From: Simon Horman @ 2013-12-24 2:55 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Dec 23, 2013 at 10:08:24PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/23/2013 09:57 PM, Sergei Shtylyov wrote:
>
> >>>Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we
> >>>intend
> >>>to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
> >>>Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
>
> >>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >>Hi Sergei,
>
> >>while I am very happy to see this change unfortunately it no longer
> >>applies. Could you please rebase it on top of
> >>renesas-devel-v3.13-rc4-20131219?
>
> > Hmm, it *was done* on top of this tag. Perhaps you meant today's
> >renesas-devel-v3.13-rc5-20131223?
>
> It continues to apply even to that tag seamlessly. Some issue
> must be on your side...
Indeed. I have now queued up the patch.
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
@ 2013-12-24 2:55 ` Simon Horman
0 siblings, 0 replies; 36+ messages in thread
From: Simon Horman @ 2013-12-24 2:55 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Dec 23, 2013 at 10:08:24PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/23/2013 09:57 PM, Sergei Shtylyov wrote:
>
> >>>Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we
> >>>intend
> >>>to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
> >>>Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
>
> >>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >>Hi Sergei,
>
> >>while I am very happy to see this change unfortunately it no longer
> >>applies. Could you please rebase it on top of
> >>renesas-devel-v3.13-rc4-20131219?
>
> > Hmm, it *was done* on top of this tag. Perhaps you meant today's
> >renesas-devel-v3.13-rc5-20131223?
>
> It continues to apply even to that tag seamlessly. Some issue
> must be on your side...
Indeed. I have now queued up the patch.
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 0/2] Add Ether's PHY IRQ support for R8A7790/Lager board
@ 2014-02-04 15:48 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-04 14:48 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.13-rc4-20131219' tag. Here we add support for the Ether's PHY
IRQ to the R8A7790/Lager board. The patchset depends on the two 'sh_eth' driver
patches posted earlier in order to compile and work. It would be good if Dave Miller
could merge these patches thru his tree, along with 'sh_eth' patches as this
would have prevented delaying these patches to 3.15 which seems inevitable
otherwise (well, unless Simon merges net-next to his tree?). I'll rebase the
patches to the 'net-next.git' repo if Dave consents to merging them...
[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 0/2] Add Ether's PHY IRQ support for R8A7790/Lager board
@ 2014-02-04 15:48 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-04 15:48 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.13-rc4-20131219' tag. Here we add support for the Ether's PHY
IRQ to the R8A7790/Lager board. The patchset depends on the two 'sh_eth' driver
patches posted earlier in order to compile and work. It would be good if Dave Miller
could merge these patches thru his tree, along with 'sh_eth' patches as this
would have prevented delaying these patches to 3.15 which seems inevitable
otherwise (well, unless Simon merges net-next to his tree?). I'll rebase the
patches to the 'net-next.git' repo if Dave consents to merging them...
[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards
@ 2014-02-04 15:51 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-04 14:51 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
PS: Sorry for the previous mail, I've hit Ctrl-Enter unexpectedly.
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards
@ 2014-02-04 15:51 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-04 15:51 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
PS: Sorry for the previous mail, I've hit Ctrl-Enter unexpectedly.
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
2014-02-04 15:51 ` Sergei Shtylyov
@ 2014-02-04 15:53 ` Sergei Shtylyov
-1 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-04 14:53 UTC (permalink / raw)
To: linux-arm-kernel
Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
trigger type to be low-level as per the Micrel PHY driver's setup.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
Changes in version 2:
- refreshed the patch.
arch/arm/mach-shmobile/board-lager.c | 4 ++++
1 file changed, 4 insertions(+)
Index: renesas/arch/arm/mach-shmobile/board-lager.c
=================================--- renesas.orig/arch/arm/mach-shmobile/board-lager.c
+++ renesas/arch/arm/mach-shmobile/board-lager.c
@@ -22,6 +22,7 @@
#include <linux/gpio_keys.h>
#include <linux/input.h>
#include <linux/interrupt.h>
+#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/mmc/host.h>
@@ -233,6 +234,7 @@ static const struct resource mmcif1_reso
/* Ether */
static const struct sh_eth_plat_data ether_pdata __initconst = {
.phy = 0x1,
+ .phy_irq = irq_pin(0),
.edmac_endian = EDMAC_LITTLE_ENDIAN,
.phy_interface = PHY_INTERFACE_MODE_RMII,
.ether_link_active_low = 1,
@@ -618,6 +620,8 @@ static void __init lager_init(void)
{
lager_add_standard_devices();
+ irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW);
+
if (IS_ENABLED(CONFIG_PHYLIB))
phy_register_fixup_for_id("r8a7790-ether-ff:01",
lager_ksz8041_fixup);
^ permalink raw reply [flat|nested] 36+ messages in thread* [PATCH v2 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
@ 2014-02-04 15:53 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-04 15:53 UTC (permalink / raw)
To: linux-arm-kernel
Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
trigger type to be low-level as per the Micrel PHY driver's setup.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
Changes in version 2:
- refreshed the patch.
arch/arm/mach-shmobile/board-lager.c | 4 ++++
1 file changed, 4 insertions(+)
Index: renesas/arch/arm/mach-shmobile/board-lager.c
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/board-lager.c
+++ renesas/arch/arm/mach-shmobile/board-lager.c
@@ -22,6 +22,7 @@
#include <linux/gpio_keys.h>
#include <linux/input.h>
#include <linux/interrupt.h>
+#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/mmc/host.h>
@@ -233,6 +234,7 @@ static const struct resource mmcif1_reso
/* Ether */
static const struct sh_eth_plat_data ether_pdata __initconst = {
.phy = 0x1,
+ .phy_irq = irq_pin(0),
.edmac_endian = EDMAC_LITTLE_ENDIAN,
.phy_interface = PHY_INTERFACE_MODE_RMII,
.ether_link_active_low = 1,
@@ -618,6 +620,8 @@ static void __init lager_init(void)
{
lager_add_standard_devices();
+ irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW);
+
if (IS_ENABLED(CONFIG_PHYLIB))
phy_register_fixup_for_id("r8a7790-ether-ff:01",
lager_ksz8041_fixup);
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
2014-02-04 15:51 ` Sergei Shtylyov
@ 2014-02-04 15:55 ` Sergei Shtylyov
-1 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-04 14:55 UTC (permalink / raw)
To: linux-arm-kernel
Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
trigger type to be low-level as per the Micrel PHY driver's setup.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
Changes in version 2:
- refreshed the patch.
arch/arm/mach-shmobile/board-koelsch.c | 4 ++++
1 file changed, 4 insertions(+)
Index: renesas/arch/arm/mach-shmobile/board-koelsch.c
=================================--- renesas.orig/arch/arm/mach-shmobile/board-koelsch.c
+++ renesas/arch/arm/mach-shmobile/board-koelsch.c
@@ -23,6 +23,7 @@
#include <linux/gpio.h>
#include <linux/gpio_keys.h>
#include <linux/input.h>
+#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/phy.h>
@@ -92,6 +93,7 @@ static void __init koelsch_add_du_device
/* Ether */
static const struct sh_eth_plat_data ether_pdata __initconst = {
.phy = 0x1,
+ .phy_irq = irq_pin(0),
.edmac_endian = EDMAC_LITTLE_ENDIAN,
.phy_interface = PHY_INTERFACE_MODE_RMII,
.ether_link_active_low = 1,
@@ -232,6 +234,8 @@ static void __init koelsch_init(void)
{
koelsch_add_standard_devices();
+ irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW);
+
if (IS_ENABLED(CONFIG_PHYLIB))
phy_register_fixup_for_id("r8a7791-ether-ff:01",
koelsch_ksz8041_fixup);
^ permalink raw reply [flat|nested] 36+ messages in thread* [PATCH v2 2/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
@ 2014-02-04 15:55 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-04 15:55 UTC (permalink / raw)
To: linux-arm-kernel
Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
trigger type to be low-level as per the Micrel PHY driver's setup.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
Changes in version 2:
- refreshed the patch.
arch/arm/mach-shmobile/board-koelsch.c | 4 ++++
1 file changed, 4 insertions(+)
Index: renesas/arch/arm/mach-shmobile/board-koelsch.c
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/board-koelsch.c
+++ renesas/arch/arm/mach-shmobile/board-koelsch.c
@@ -23,6 +23,7 @@
#include <linux/gpio.h>
#include <linux/gpio_keys.h>
#include <linux/input.h>
+#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/phy.h>
@@ -92,6 +93,7 @@ static void __init koelsch_add_du_device
/* Ether */
static const struct sh_eth_plat_data ether_pdata __initconst = {
.phy = 0x1,
+ .phy_irq = irq_pin(0),
.edmac_endian = EDMAC_LITTLE_ENDIAN,
.phy_interface = PHY_INTERFACE_MODE_RMII,
.ether_link_active_low = 1,
@@ -232,6 +234,8 @@ static void __init koelsch_init(void)
{
koelsch_add_standard_devices();
+ irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW);
+
if (IS_ENABLED(CONFIG_PHYLIB))
phy_register_fixup_for_id("r8a7791-ether-ff:01",
koelsch_ksz8041_fixup);
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards
2014-02-04 15:51 ` Sergei Shtylyov
@ 2014-02-05 7:25 ` Magnus Damm
-1 siblings, 0 replies; 36+ messages in thread
From: Magnus Damm @ 2014-02-05 7:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Wed, Feb 5, 2014 at 12:51 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> 'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
> IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
>
> [1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
> [1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
Thanks, looking good!
/ magnus
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards
@ 2014-02-05 7:25 ` Magnus Damm
0 siblings, 0 replies; 36+ messages in thread
From: Magnus Damm @ 2014-02-05 7:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Wed, Feb 5, 2014 at 12:51 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> 'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
> IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
>
> [1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
> [1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
Thanks, looking good!
/ magnus
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards
2014-02-05 7:25 ` Magnus Damm
@ 2014-02-05 16:36 ` Sergei Shtylyov
-1 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-05 15:36 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 02/05/2014 10:25 AM, Magnus Damm wrote:
>> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
>> 'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
>> IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
>> [1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
>> [1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
> Thanks, looking good!
Not at all, you've already tested these patches, IIRC.
> / magnus
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread* [PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards
@ 2014-02-05 16:36 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-05 16:36 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 02/05/2014 10:25 AM, Magnus Damm wrote:
>> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
>> 'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
>> IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
>> [1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
>> [1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
> Thanks, looking good!
Not at all, you've already tested these patches, IIRC.
> / magnus
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards
2014-02-05 16:36 ` Sergei Shtylyov
@ 2014-02-06 6:34 ` Simon Horman
-1 siblings, 0 replies; 36+ messages in thread
From: Simon Horman @ 2014-02-06 6:34 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Feb 05, 2014 at 07:36:58PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 02/05/2014 10:25 AM, Magnus Damm wrote:
>
> >> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> >>'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
> >>IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
>
> >>[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
> >>[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
>
> >Thanks, looking good!
>
> Not at all, you've already tested these patches, IIRC.
Thanks, I have queued these up with Magnus's ack which
he supplied the previous time that you posted them.
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards
@ 2014-02-06 6:34 ` Simon Horman
0 siblings, 0 replies; 36+ messages in thread
From: Simon Horman @ 2014-02-06 6:34 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Feb 05, 2014 at 07:36:58PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 02/05/2014 10:25 AM, Magnus Damm wrote:
>
> >> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> >>'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
> >>IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
>
> >>[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
> >>[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
>
> >Thanks, looking good!
>
> Not at all, you've already tested these patches, IIRC.
Thanks, I have queued these up with Magnus's ack which
he supplied the previous time that you posted them.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards
2014-02-06 6:34 ` Simon Horman
@ 2014-02-06 11:49 ` Sergei Shtylyov
-1 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-06 11:49 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 06-02-2014 10:34, Simon Horman wrote:
>>>> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
>>>> 'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
>>>> IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
>>>> [1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
>>>> [1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
>>> Thanks, looking good!
>> Not at all, you've already tested these patches, IIRC.
> Thanks, I have queued these up with Magnus's ack which
> he supplied the previous time that you posted them.
Oh, sorry, I forgot to pick it up myself. :-/
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread* [PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards
@ 2014-02-06 11:49 ` Sergei Shtylyov
0 siblings, 0 replies; 36+ messages in thread
From: Sergei Shtylyov @ 2014-02-06 11:49 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 06-02-2014 10:34, Simon Horman wrote:
>>>> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
>>>> 'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
>>>> IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
>>>> [1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
>>>> [1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
>>> Thanks, looking good!
>> Not at all, you've already tested these patches, IIRC.
> Thanks, I have queued these up with Magnus's ack which
> he supplied the previous time that you posted them.
Oh, sorry, I forgot to pick it up myself. :-/
WBR, Sergei
^ permalink raw reply [flat|nested] 36+ messages in thread