All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Zlatko Calusic <zcalusic@bitsync.net>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Rik van Riel <riel@redhat.com>, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/7] Configurable fair allocation zone policy v2r6
Date: Mon, 23 Dec 2013 10:26:37 +0000	[thread overview]
Message-ID: <20131223102637.GF11295@suse.de> (raw)
In-Reply-To: <52B5BBDF.9010200@bitsync.net>

On Sat, Dec 21, 2013 at 05:03:43PM +0100, Zlatko Calusic wrote:
> On 17.12.2013 22:23, Mel Gorman wrote:
> >On Tue, Dec 17, 2013 at 04:07:35PM +0100, Zlatko Calusic wrote:
> >>On 13.12.2013 15:10, Mel Gorman wrote:
> >>>Kicked this another bit today. It's still a bit half-baked but it restores
> >>>the historical performance and leaves the door open at the end for playing
> >>>nice with distributing file pages between nodes. Finishing this series
> >>>depends on whether we are going to make the remote node behaviour of the
> >>>fair zone allocation policy configurable or redefine MPOL_LOCAL. I'm in
> >>>favour of the configurable option because the default can be redefined and
> >>>tested while giving users a "compat" mode if we discover the new default
> >>>behaviour sucks for some workload.
> >>>
> >>
> >>I'll start a 5-day test of this patchset in a few hours, unless you
> >>can send an updated one in the meantime. I intend to test it on a
> >>rather boring 4GB x86_64 machine that before Johannes' work had lots
> >>of trouble balancing zones. Would you recommend to use the default
> >>settings, i.e. don't mess with tunables at this point?
> >>
> >
> >For me at least I would prefer you tested v3 of the series with the
> >default settings of not interleaving file-backed pages on remote nodes
> >by default. Johannes might request testing with that knob enabled if the
> >machine is NUMA although I doubt it is with 4G of RAM.
> >
> 
> Tested v3 on UMA machine, with default setting. I see no regression,
> no issues whatsoever. From what I understand, this whole series is
> about fixing issues noticed on NUMA, so I wish you good luck with
> that (no such hardware here). Just be extra careful not to disturb
> finally very well balanced MM on more common machines (and
> especially those equipped with 4GB RAM). And once again thank you
> Johannes for your work, you did a great job.
> 
> Tested-by: Zlatko Calusic <zcalusic@bitsync.net>

Thanks for testing. Even though this patch is about NUMA, it preserves
the fair zone allocation policy on UMA that your workload depends upon.

-- 
Mel Gorman
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Zlatko Calusic <zcalusic@bitsync.net>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Rik van Riel <riel@redhat.com>, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/7] Configurable fair allocation zone policy v2r6
Date: Mon, 23 Dec 2013 10:26:37 +0000	[thread overview]
Message-ID: <20131223102637.GF11295@suse.de> (raw)
In-Reply-To: <52B5BBDF.9010200@bitsync.net>

On Sat, Dec 21, 2013 at 05:03:43PM +0100, Zlatko Calusic wrote:
> On 17.12.2013 22:23, Mel Gorman wrote:
> >On Tue, Dec 17, 2013 at 04:07:35PM +0100, Zlatko Calusic wrote:
> >>On 13.12.2013 15:10, Mel Gorman wrote:
> >>>Kicked this another bit today. It's still a bit half-baked but it restores
> >>>the historical performance and leaves the door open at the end for playing
> >>>nice with distributing file pages between nodes. Finishing this series
> >>>depends on whether we are going to make the remote node behaviour of the
> >>>fair zone allocation policy configurable or redefine MPOL_LOCAL. I'm in
> >>>favour of the configurable option because the default can be redefined and
> >>>tested while giving users a "compat" mode if we discover the new default
> >>>behaviour sucks for some workload.
> >>>
> >>
> >>I'll start a 5-day test of this patchset in a few hours, unless you
> >>can send an updated one in the meantime. I intend to test it on a
> >>rather boring 4GB x86_64 machine that before Johannes' work had lots
> >>of trouble balancing zones. Would you recommend to use the default
> >>settings, i.e. don't mess with tunables at this point?
> >>
> >
> >For me at least I would prefer you tested v3 of the series with the
> >default settings of not interleaving file-backed pages on remote nodes
> >by default. Johannes might request testing with that knob enabled if the
> >machine is NUMA although I doubt it is with 4G of RAM.
> >
> 
> Tested v3 on UMA machine, with default setting. I see no regression,
> no issues whatsoever. From what I understand, this whole series is
> about fixing issues noticed on NUMA, so I wish you good luck with
> that (no such hardware here). Just be extra careful not to disturb
> finally very well balanced MM on more common machines (and
> especially those equipped with 4GB RAM). And once again thank you
> Johannes for your work, you did a great job.
> 
> Tested-by: Zlatko Calusic <zcalusic@bitsync.net>

Thanks for testing. Even though this patch is about NUMA, it preserves
the fair zone allocation policy on UMA that your workload depends upon.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-12-23 10:26 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 14:10 [RFC PATCH 0/7] Configurable fair allocation zone policy v2r6 Mel Gorman
2013-12-13 14:10 ` Mel Gorman
2013-12-13 14:10 ` [PATCH 1/7] mm: page_alloc: exclude unreclaimable allocations from zone fairness policy Mel Gorman
2013-12-13 14:10   ` Mel Gorman
2013-12-13 15:45   ` Rik van Riel
2013-12-13 15:45     ` Rik van Riel
2013-12-13 14:10 ` [PATCH 2/7] mm: page_alloc: Break out zone page aging distribution into its own helper Mel Gorman
2013-12-13 14:10   ` Mel Gorman
2013-12-13 15:46   ` Rik van Riel
2013-12-13 15:46     ` Rik van Riel
2013-12-16 20:16   ` Johannes Weiner
2013-12-16 20:16     ` Johannes Weiner
2013-12-13 14:10 ` [PATCH 3/7] mm: page_alloc: Use zone node IDs to approximate locality Mel Gorman
2013-12-13 14:10   ` Mel Gorman
2013-12-16 13:20   ` Rik van Riel
2013-12-16 13:20     ` Rik van Riel
2013-12-16 20:25   ` Johannes Weiner
2013-12-16 20:25     ` Johannes Weiner
2013-12-17 11:13     ` Mel Gorman
2013-12-17 11:13       ` Mel Gorman
2013-12-17 15:38       ` Johannes Weiner
2013-12-17 15:38         ` Johannes Weiner
2013-12-17 16:08         ` Mel Gorman
2013-12-17 16:08           ` Mel Gorman
2013-12-17 20:11           ` Johannes Weiner
2013-12-17 20:11             ` Johannes Weiner
2013-12-17 21:03             ` Mel Gorman
2013-12-17 21:03               ` Mel Gorman
2013-12-17 22:31               ` Johannes Weiner
2013-12-17 22:31                 ` Johannes Weiner
2013-12-13 14:10 ` [PATCH 4/7] mm: Annotate page cache allocations Mel Gorman
2013-12-13 14:10   ` Mel Gorman
2013-12-16 15:20   ` Rik van Riel
2013-12-16 15:20     ` Rik van Riel
2013-12-13 14:10 ` [PATCH 5/7] mm: page_alloc: Make zone distribution page aging policy configurable Mel Gorman
2013-12-13 14:10   ` Mel Gorman
2013-12-16 19:25   ` Rik van Riel
2013-12-16 19:25     ` Rik van Riel
2013-12-16 20:42   ` Johannes Weiner
2013-12-16 20:42     ` Johannes Weiner
2013-12-17 15:29     ` Mel Gorman
2013-12-17 15:29       ` Mel Gorman
2013-12-17 15:54       ` Johannes Weiner
2013-12-17 15:54         ` Johannes Weiner
2013-12-17 16:14         ` Mel Gorman
2013-12-17 16:14           ` Mel Gorman
2013-12-17 17:43           ` Johannes Weiner
2013-12-17 17:43             ` Johannes Weiner
2013-12-17 21:22             ` Mel Gorman
2013-12-17 21:22               ` Mel Gorman
2013-12-17 22:57               ` Johannes Weiner
2013-12-17 22:57                 ` Johannes Weiner
2013-12-17 23:24                 ` Mel Gorman
2013-12-17 23:24                   ` Mel Gorman
2013-12-13 14:10 ` [PATCH 6/7] mm: page_alloc: Only account batch allocations requests that are eligible Mel Gorman
2013-12-13 14:10   ` Mel Gorman
2013-12-16 20:52   ` Johannes Weiner
2013-12-16 20:52     ` Johannes Weiner
2013-12-17 11:20     ` Mel Gorman
2013-12-17 11:20       ` Mel Gorman
2013-12-17 15:43       ` Johannes Weiner
2013-12-17 15:43         ` Johannes Weiner
2013-12-17 16:06         ` Mel Gorman
2013-12-17 16:06           ` Mel Gorman
2013-12-13 14:10 ` [PATCH 7/7] mm: page_alloc: Default allow file pages to use remote nodes for fair allocation policy Mel Gorman
2013-12-13 14:10   ` Mel Gorman
2013-12-13 17:04   ` Johannes Weiner
2013-12-13 17:04     ` Johannes Weiner
2013-12-13 19:20     ` Mel Gorman
2013-12-13 19:20       ` Mel Gorman
2013-12-13 22:15       ` Johannes Weiner
2013-12-13 22:15         ` Johannes Weiner
2013-12-17 16:04         ` Mel Gorman
2013-12-17 16:04           ` Mel Gorman
2013-12-16 19:26   ` Rik van Riel
2013-12-16 19:26     ` Rik van Riel
2013-12-17 15:07 ` [RFC PATCH 0/7] Configurable fair allocation zone policy v2r6 Zlatko Calusic
2013-12-17 15:07   ` Zlatko Calusic
2013-12-17 21:23   ` Mel Gorman
2013-12-17 21:23     ` Mel Gorman
2013-12-21 16:03     ` Zlatko Calusic
2013-12-21 16:03       ` Zlatko Calusic
2013-12-23 10:26       ` Mel Gorman [this message]
2013-12-23 10:26         ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131223102637.GF11295@suse.de \
    --to=mgorman@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    --cc=zcalusic@bitsync.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.