All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY
Date: Thu, 26 Dec 2013 05:30:19 +0000	[thread overview]
Message-ID: <20131226053015.GA9638@verge.net.au> (raw)
In-Reply-To: <52B37BAC.4090405@cogentembedded.com>

On Fri, Dec 20, 2013 at 02:05:16AM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/16/2013 03:31 AM, Simon Horman wrote:
> 
> >The koelsch board uses has an SH ethernet controller which uses a Micrel
> >phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the
> >Micrel-specific phy driver rather than relying on the generic phy driver.
> 
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >---
> >  arch/arm/mach-shmobile/Kconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> >diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
> >index f01e878..670238a 100644
> >--- a/arch/arm/mach-shmobile/Kconfig
> >+++ b/arch/arm/mach-shmobile/Kconfig
> >@@ -41,6 +41,7 @@ config MACH_GENMAI
> >  config MACH_KOELSCH
> >  	bool "Koelsch board"
> >  	depends on ARCH_R8A7791
> >+	select MICREL_PHY if SH_ETH
> >
> >  config MACH_KZM9D
> >  	bool "KZM9D board"
> 
>    Simon, did you initially remove that hunk when committing?

Thanks for noticing.

I will queue up the following:

From: Simon Horman <horms+renesas@verge.net.au>

ARM: shmobile: koelsch: Conditionally select MICREL_PHY for Multiplatform

The koelsch board uses has an SH ethernet controller which uses a Micrel
phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the
Micrel-specific phy driver rather than relying on the generic phy driver.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
index a127252..958ccf3d 100644
--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -45,6 +45,7 @@ config MACH_GENMAI
 config MACH_KOELSCH
 	bool "Koelsch board"
 	depends on ARCH_R8A7791
+	select MICREL_PHY if SH_ETH
 
 config MACH_KZM9D
 	bool "KZM9D board"
-- 
1.8.4


WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY
Date: Thu, 26 Dec 2013 14:30:19 +0900	[thread overview]
Message-ID: <20131226053015.GA9638@verge.net.au> (raw)
In-Reply-To: <52B37BAC.4090405@cogentembedded.com>

On Fri, Dec 20, 2013 at 02:05:16AM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/16/2013 03:31 AM, Simon Horman wrote:
> 
> >The koelsch board uses has an SH ethernet controller which uses a Micrel
> >phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the
> >Micrel-specific phy driver rather than relying on the generic phy driver.
> 
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >---
> >  arch/arm/mach-shmobile/Kconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> >diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
> >index f01e878..670238a 100644
> >--- a/arch/arm/mach-shmobile/Kconfig
> >+++ b/arch/arm/mach-shmobile/Kconfig
> >@@ -41,6 +41,7 @@ config MACH_GENMAI
> >  config MACH_KOELSCH
> >  	bool "Koelsch board"
> >  	depends on ARCH_R8A7791
> >+	select MICREL_PHY if SH_ETH
> >
> >  config MACH_KZM9D
> >  	bool "KZM9D board"
> 
>    Simon, did you initially remove that hunk when committing?

Thanks for noticing.

I will queue up the following:

From: Simon Horman <horms+renesas@verge.net.au>

ARM: shmobile: koelsch: Conditionally select MICREL_PHY for Multiplatform

The koelsch board uses has an SH ethernet controller which uses a Micrel
phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the
Micrel-specific phy driver rather than relying on the generic phy driver.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
index a127252..958ccf3d 100644
--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -45,6 +45,7 @@ config MACH_GENMAI
 config MACH_KOELSCH
 	bool "Koelsch board"
 	depends on ARCH_R8A7791
+	select MICREL_PHY if SH_ETH
 
 config MACH_KZM9D
 	bool "KZM9D board"
-- 
1.8.4

  reply	other threads:[~2013-12-26  5:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16  0:31 [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY Simon Horman
2013-12-16  0:31 ` Simon Horman
2013-12-16 13:25 ` Sergei Shtylyov
2013-12-16 13:25   ` Sergei Shtylyov
2013-12-16 22:31   ` Sergei Shtylyov
2013-12-16 23:31     ` Sergei Shtylyov
2013-12-17  0:31     ` Simon Horman
2013-12-17  0:31       ` Simon Horman
2013-12-17 10:10       ` Geert Uytterhoeven
2013-12-17 10:10         ` Geert Uytterhoeven
2013-12-18  0:53         ` Simon Horman
2013-12-18  0:53           ` Simon Horman
2013-12-19  9:04           ` Simon Horman
2013-12-19  9:04             ` Simon Horman
2013-12-17  0:30   ` Simon Horman
2013-12-17  0:30     ` Simon Horman
2013-12-19 22:05 ` Sergei Shtylyov
2013-12-19 23:05   ` Sergei Shtylyov
2013-12-26  5:30   ` Simon Horman [this message]
2013-12-26  5:30     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131226053015.GA9638@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.