From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/upmpdcli: needs NPTL
Date: Sun, 17 Feb 2019 20:18:52 +0100 [thread overview]
Message-ID: <20139c84b00941198fea0b7391bac4ef6cdc2351.camel@embedded.rocks> (raw)
In-Reply-To: <20190216104202.13511-1-fontaine.fabrice@gmail.com>
On Sat, 2019-02-16 at 11:42 +0100, Fabrice Fontaine wrote:
> The software uses pthread_mutexattr_setrobust which isn't available in
> uClibc-ng Linuxthreads support.
>
> Fixes:
> - http://autobuild.buildroot.org/results/197615ad077b0a719954024c3ba182dac43a0555
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/upmpdcli/Config.in | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/package/upmpdcli/Config.in b/package/upmpdcli/Config.in
> index 938024e8a2..74eb768830 100644
> --- a/package/upmpdcli/Config.in
> +++ b/package/upmpdcli/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_UPMPDCLI
> bool "upmpdcli"
> depends on BR2_USE_MMU # fork()
> depends on BR2_INSTALL_LIBSTDCPP
> - depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp
> + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11, libupnpp
> select BR2_PACKAGE_JSONCPP
> select BR2_PACKAGE_LIBMICROHTTPD
> @@ -15,6 +15,8 @@ config BR2_PACKAGE_UPMPDCLI
>
> http://www.lesbonscomptes.com/upmpdcli/
>
> -comment "upmpdcli needs a toolchain w/ C++, threads, gcc >= 4.9"
> +comment "upmpdcli needs a toolchain w/ C++, NPTL, gcc >= 4.9"
> depends on BR2_USE_MMU
> - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + depends on !BR2_INSTALL_LIBSTDCPP || \
> + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
pthread_mutexattr_setrobust and PTHREAD_MUTEXATTR_FLAG_ROBUST are only
available in NPTL [1]. Therefore:
Acked-by: J?rg Krause <joerg.krause@embedded.rocks>
[1] https://elixir.bootlin.com/uclibc-ng/v1.0.31/ident/PTHREAD_MUTEXATTR_FLAG_ROBUST
next prev parent reply other threads:[~2019-02-17 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 10:42 [Buildroot] [PATCH 1/1] package/upmpdcli: needs NPTL Fabrice Fontaine
2019-02-17 19:18 ` Jörg Krause [this message]
2019-02-24 20:24 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20139c84b00941198fea0b7391bac4ef6cdc2351.camel@embedded.rocks \
--to=joerg.krause@embedded.rocks \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.