* [Buildroot] [PATCH 1/1] package/upmpdcli: needs NPTL
@ 2019-02-16 10:42 Fabrice Fontaine
2019-02-17 19:18 ` Jörg Krause
2019-02-24 20:24 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-02-16 10:42 UTC (permalink / raw)
To: buildroot
The software uses pthread_mutexattr_setrobust which isn't available in
uClibc-ng Linuxthreads support.
Fixes:
- http://autobuild.buildroot.org/results/197615ad077b0a719954024c3ba182dac43a0555
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/upmpdcli/Config.in | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/package/upmpdcli/Config.in b/package/upmpdcli/Config.in
index 938024e8a2..74eb768830 100644
--- a/package/upmpdcli/Config.in
+++ b/package/upmpdcli/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_UPMPDCLI
bool "upmpdcli"
depends on BR2_USE_MMU # fork()
depends on BR2_INSTALL_LIBSTDCPP
- depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp
+ depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11, libupnpp
select BR2_PACKAGE_JSONCPP
select BR2_PACKAGE_LIBMICROHTTPD
@@ -15,6 +15,8 @@ config BR2_PACKAGE_UPMPDCLI
http://www.lesbonscomptes.com/upmpdcli/
-comment "upmpdcli needs a toolchain w/ C++, threads, gcc >= 4.9"
+comment "upmpdcli needs a toolchain w/ C++, NPTL, gcc >= 4.9"
depends on BR2_USE_MMU
- depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+ depends on !BR2_INSTALL_LIBSTDCPP || \
+ !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/upmpdcli: needs NPTL
2019-02-16 10:42 [Buildroot] [PATCH 1/1] package/upmpdcli: needs NPTL Fabrice Fontaine
@ 2019-02-17 19:18 ` Jörg Krause
2019-02-24 20:24 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Jörg Krause @ 2019-02-17 19:18 UTC (permalink / raw)
To: buildroot
On Sat, 2019-02-16 at 11:42 +0100, Fabrice Fontaine wrote:
> The software uses pthread_mutexattr_setrobust which isn't available in
> uClibc-ng Linuxthreads support.
>
> Fixes:
> - http://autobuild.buildroot.org/results/197615ad077b0a719954024c3ba182dac43a0555
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/upmpdcli/Config.in | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/package/upmpdcli/Config.in b/package/upmpdcli/Config.in
> index 938024e8a2..74eb768830 100644
> --- a/package/upmpdcli/Config.in
> +++ b/package/upmpdcli/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_UPMPDCLI
> bool "upmpdcli"
> depends on BR2_USE_MMU # fork()
> depends on BR2_INSTALL_LIBSTDCPP
> - depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp
> + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11, libupnpp
> select BR2_PACKAGE_JSONCPP
> select BR2_PACKAGE_LIBMICROHTTPD
> @@ -15,6 +15,8 @@ config BR2_PACKAGE_UPMPDCLI
>
> http://www.lesbonscomptes.com/upmpdcli/
>
> -comment "upmpdcli needs a toolchain w/ C++, threads, gcc >= 4.9"
> +comment "upmpdcli needs a toolchain w/ C++, NPTL, gcc >= 4.9"
> depends on BR2_USE_MMU
> - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + depends on !BR2_INSTALL_LIBSTDCPP || \
> + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
pthread_mutexattr_setrobust and PTHREAD_MUTEXATTR_FLAG_ROBUST are only
available in NPTL [1]. Therefore:
Acked-by: J?rg Krause <joerg.krause@embedded.rocks>
[1] https://elixir.bootlin.com/uclibc-ng/v1.0.31/ident/PTHREAD_MUTEXATTR_FLAG_ROBUST
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/upmpdcli: needs NPTL
2019-02-16 10:42 [Buildroot] [PATCH 1/1] package/upmpdcli: needs NPTL Fabrice Fontaine
2019-02-17 19:18 ` Jörg Krause
@ 2019-02-24 20:24 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-02-24 20:24 UTC (permalink / raw)
To: buildroot
Hello Fabrice,
On Sat, 16 Feb 2019 11:42:02 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> The software uses pthread_mutexattr_setrobust which isn't available in
> uClibc-ng Linuxthreads support.
>
> Fixes:
> - http://autobuild.buildroot.org/results/197615ad077b0a719954024c3ba182dac43a0555
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks. However...
> ---
> package/upmpdcli/Config.in | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/package/upmpdcli/Config.in b/package/upmpdcli/Config.in
> index 938024e8a2..74eb768830 100644
> --- a/package/upmpdcli/Config.in
> +++ b/package/upmpdcli/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_UPMPDCLI
> bool "upmpdcli"
> depends on BR2_USE_MMU # fork()
> depends on BR2_INSTALL_LIBSTDCPP
> - depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp
... I'm not sure on which commit you based this on, but in master, this
line looked like this:
depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp, libmicrohttpd
so your patch didn't apply. I fixed this up manually.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-24 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-16 10:42 [Buildroot] [PATCH 1/1] package/upmpdcli: needs NPTL Fabrice Fontaine
2019-02-17 19:18 ` Jörg Krause
2019-02-24 20:24 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.