* [PATCH net-next] r8152: fix the wrong return value
@ 2014-01-03 3:21 Hayes Wang
2014-01-03 5:38 ` David Cohen
2014-01-04 1:37 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Hayes Wang @ 2014-01-03 3:21 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel, linux-usb, Hayes Wang
The return value should be the boolean value, not the error code.
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Spotted-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/usb/r8152.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index e3d878c..13fabbb 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -2708,7 +2708,7 @@ static bool rtl_ops_init(struct r8152 *tp, const struct usb_device_id *id)
ops->unload = rtl8153_unload;
break;
default:
- ret = -EFAULT;
+ ret = false;
break;
}
break;
--
1.8.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] r8152: fix the wrong return value
2014-01-03 3:21 [PATCH net-next] r8152: fix the wrong return value Hayes Wang
@ 2014-01-03 5:38 ` David Cohen
2014-01-04 1:37 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Cohen @ 2014-01-03 5:38 UTC (permalink / raw)
To: Hayes Wang; +Cc: netdev, linux-kernel, linux-usb
On Fri, Jan 03, 2014 at 11:21:56AM +0800, Hayes Wang wrote:
> The return value should be the boolean value, not the error code.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> Spotted-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/usb/r8152.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index e3d878c..13fabbb 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -2708,7 +2708,7 @@ static bool rtl_ops_init(struct r8152 *tp, const struct usb_device_id *id)
> ops->unload = rtl8153_unload;
> break;
> default:
> - ret = -EFAULT;
> + ret = false;
How about fix the function's return type instead?
Returning bool for success/error in Linux kernel is not natural. You
gotta check rtl_ops_init() for success and !rtl_ops_init() for error.
And you are unable to return the error value.
Br, David
> break;
> }
> break;
> --
> 1.8.4.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] r8152: fix the wrong return value
2014-01-03 3:21 [PATCH net-next] r8152: fix the wrong return value Hayes Wang
2014-01-03 5:38 ` David Cohen
@ 2014-01-04 1:37 ` David Miller
2014-01-06 3:20 ` hayeswang
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2014-01-04 1:37 UTC (permalink / raw)
To: hayeswang; +Cc: netdev, linux-kernel, linux-usb
From: Hayes Wang <hayeswang@realtek.com>
Date: Fri, 3 Jan 2014 11:21:56 +0800
> The return value should be the boolean value, not the error code.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> Spotted-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, but I agree with others that it's more canonical to have the
function return either an error code, or zero for success, rather than
a boolean.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH net-next] r8152: fix the wrong return value
2014-01-04 1:37 ` David Miller
@ 2014-01-06 3:20 ` hayeswang
0 siblings, 0 replies; 4+ messages in thread
From: hayeswang @ 2014-01-06 3:20 UTC (permalink / raw)
To: 'David Miller'; +Cc: netdev, linux-kernel, linux-usb
David Miller [mailto:davem@davemloft.net]
> Sent: Saturday, January 04, 2014 9:38 AM
> To: Hayeswang
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next] r8152: fix the wrong return value
>
> From: Hayes Wang <hayeswang@realtek.com>
> Date: Fri, 3 Jan 2014 11:21:56 +0800
>
> > The return value should be the boolean value, not the error code.
> >
> > Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> > Spotted-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied, but I agree with others that it's more canonical to have the
> function return either an error code, or zero for success, rather than
> a boolean.
Thanks. I would find if there is suitable error code.
Best Regards,
Hayes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-06 3:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-03 3:21 [PATCH net-next] r8152: fix the wrong return value Hayes Wang
2014-01-03 5:38 ` David Cohen
2014-01-04 1:37 ` David Miller
2014-01-06 3:20 ` hayeswang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.