All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <khali@linux-fr.org>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>,
	"Zhang, Rui" <rui.zhang@intel.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	lm-sensors@lm-sensors.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] hwmon/sensors: fix SENSORS_LM75 dependencies
Date: Tue, 7 Jan 2014 08:10:18 -0800	[thread overview]
Message-ID: <20140107161018.GB24018@roeck-us.net> (raw)
In-Reply-To: <20140107160738.4a76a6d0@endymion.delvare>

On Tue, Jan 07, 2014 at 04:07:38PM +0100, Jean Delvare wrote:
> On Tue, 7 Jan 2014 10:57:52 -0400, Eduardo Valentin wrote:
> > On 07-01-2014 10:05, Zhang, Rui wrote:
> > > BTW, I've been thinking of make CONFIG_THERMAL a bool since long time ago, the only thing that blocks me is that Thermal subsystem needs to register a hwmon device for each thermal zone and CONFIG_HWMON is a tristate.
> > 
> > I agree with the move of having CONFIG_THERMAL as bool. Unless you have
> > use cases where users are dynamically loading and unloading thermal per
> > user demand, which I doubt.
> 
> Modularity is not only about reloading modules (although this can be
> useful for developers in particular.) It's also about enabling many
> features in a generic distribution kernel and each feature only gets
> loaded/used on the hardware which needs it. This is why, as a
> distribution kernel maintainer, I keep complaining when I see boolean
> options which might easily be tristates.
> 
Agreed. Problem is really that it is not easy to declare cross-module
dependencies (eg THERMAL=m -> HWMON=m and THERMAL=y -> HWMON=y and
vice versa) in Kconfig. Declaring everything as bool can not be
the solution to that.

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <khali@linux-fr.org>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>,
	"Zhang, Rui" <rui.zhang@intel.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	lm-sensors@lm-sensors.org, linux-pm@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon/sensors: fix SENSORS_LM75 dependencies
Date: Tue, 07 Jan 2014 16:10:18 +0000	[thread overview]
Message-ID: <20140107161018.GB24018@roeck-us.net> (raw)
In-Reply-To: <20140107160738.4a76a6d0@endymion.delvare>

On Tue, Jan 07, 2014 at 04:07:38PM +0100, Jean Delvare wrote:
> On Tue, 7 Jan 2014 10:57:52 -0400, Eduardo Valentin wrote:
> > On 07-01-2014 10:05, Zhang, Rui wrote:
> > > BTW, I've been thinking of make CONFIG_THERMAL a bool since long time ago, the only thing that blocks me is that Thermal subsystem needs to register a hwmon device for each thermal zone and CONFIG_HWMON is a tristate.
> > 
> > I agree with the move of having CONFIG_THERMAL as bool. Unless you have
> > use cases where users are dynamically loading and unloading thermal per
> > user demand, which I doubt.
> 
> Modularity is not only about reloading modules (although this can be
> useful for developers in particular.) It's also about enabling many
> features in a generic distribution kernel and each feature only gets
> loaded/used on the hardware which needs it. This is why, as a
> distribution kernel maintainer, I keep complaining when I see boolean
> options which might easily be tristates.
> 
Agreed. Problem is really that it is not easy to declare cross-module
dependencies (eg THERMAL=m -> HWMON=m and THERMAL=y -> HWMON=y and
vice versa) in Kconfig. Declaring everything as bool can not be
the solution to that.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2014-01-07 16:10 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06  9:40 linux-next: Tree for Jan 06 Stephen Rothwell
2014-01-06  9:40 ` Stephen Rothwell
2014-01-06 19:51 ` linux-next: Tree for Jan 06 (hwmon/lm75.c) Randy Dunlap
2014-01-06 19:51   ` [lm-sensors] " Randy Dunlap
2014-01-06 20:32   ` Guenter Roeck
2014-01-06 20:32     ` [lm-sensors] " Guenter Roeck
2014-01-07  1:09     ` [PATCH] hwmon/sensors: fix SENSORS_LM75 dependencies Randy Dunlap
2014-01-07  1:09       ` [lm-sensors] " Randy Dunlap
2014-01-07  2:26       ` Guenter Roeck
2014-01-07  2:26         ` [lm-sensors] " Guenter Roeck
2014-01-07 11:35         ` Eduardo Valentin
2014-01-07 11:35           ` [lm-sensors] " Eduardo Valentin
2014-01-07 11:35           ` Eduardo Valentin
2014-01-07 12:04         ` Jean Delvare
2014-01-07 12:04           ` [lm-sensors] " Jean Delvare
2014-01-07 12:23           ` Eduardo Valentin
2014-01-07 12:23             ` [lm-sensors] " Eduardo Valentin
2014-01-07 12:23             ` Eduardo Valentin
2014-01-07 12:44             ` [PATCH 1/1] thermal: fix compilation issue on CONFIG_THERMAL_OF dependencies Eduardo Valentin
2014-01-07 12:44               ` Eduardo Valentin
2014-01-07 14:33               ` Guenter Roeck
2014-01-07 14:56                 ` Eduardo Valentin
2014-01-07 14:56                   ` Eduardo Valentin
2014-01-07 15:03                 ` Jean Delvare
2014-01-07 14:05             ` [PATCH] hwmon/sensors: fix SENSORS_LM75 dependencies Zhang, Rui
2014-01-07 14:05               ` [lm-sensors] " Zhang, Rui
2014-01-07 14:57               ` Eduardo Valentin
2014-01-07 14:57                 ` [lm-sensors] " Eduardo Valentin
2014-01-07 15:07                 ` Jean Delvare
2014-01-07 15:07                   ` [lm-sensors] " Jean Delvare
2014-01-07 15:28                   ` Eduardo Valentin
2014-01-07 15:28                     ` [lm-sensors] " Eduardo Valentin
2014-01-07 15:28                     ` Eduardo Valentin
2014-01-07 16:10                   ` Guenter Roeck [this message]
2014-01-07 16:10                     ` [lm-sensors] " Guenter Roeck
2014-01-07 14:21             ` Jean Delvare
2014-01-07 14:21               ` [lm-sensors] " Jean Delvare
2014-01-07 14:21               ` Jean Delvare
2014-01-07 16:33               ` Eduardo Valentin
2014-01-07 16:33                 ` [lm-sensors] " Eduardo Valentin
2014-01-07 16:33                 ` Eduardo Valentin
2014-01-08  1:50                 ` Guenter Roeck
2014-01-08  1:50                   ` [lm-sensors] " Guenter Roeck
2014-01-07 18:06               ` Randy Dunlap
2014-01-07 18:06                 ` [lm-sensors] " Randy Dunlap
2014-01-08  2:02               ` Zhang Rui
2014-01-08  2:02                 ` [lm-sensors] " Zhang Rui
2014-01-07 16:02           ` Guenter Roeck
2014-01-07 16:02             ` [lm-sensors] " Guenter Roeck
2014-01-07 11:33     ` linux-next: Tree for Jan 06 (hwmon/lm75.c) Eduardo Valentin
2014-01-07 11:33       ` [lm-sensors] " Eduardo Valentin
2014-01-07 11:33       ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140107161018.GB24018@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=eduardo.valentin@ti.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=rdunlap@infradead.org \
    --cc=rui.zhang@intel.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.