From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Kishon Vijay Abraham I <kishon@ti.com> Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Tony Lindgren <tony@atomide.com> Subject: Re: [PATCH 4/5] arm: omap3: twl: use the new lookup method with usb phy Date: Tue, 14 Jan 2014 16:38:49 +0200 [thread overview] Message-ID: <20140114143849.GB21169@xps8300> (raw) In-Reply-To: <52CBFAC0.9040103@ti.com> On Tue, Jan 07, 2014 at 06:31:52PM +0530, Kishon Vijay Abraham I wrote: > > In any case, having two device names to deal with does not add any > > more risk. These associations should always be made in the place where > > the phy device is created so you will always know it's device name. > > huh.. we should also know the 'controller' device name while defining these > associations and in some cases the controller device and phy device are created > in entirely different places. If you don't want to use the controller device name to do the matching, we can use the con_id string as well. I believe the lookup method I use in this set just needs a small change. Is that OK with you? > > Normally the platform code creates these associations in the same > > place it creates the platform devices, so you definitely know what the > > device names will be. > > > > In this case it's actually created in drivers/mfd/twl-core.c, so I do > > need to update this and move the lookup table there. We can still > > deliver the user name as platform data, though I believe it's always > > "musb". Maybe we could actually skip that and just hard code the name? > > I would rather leave the way it is modelled now. Do you mean, leave it in the platform code? Why? We would reduce the platform code by moving it to the mfd driver. Or did I misunderstood something? Hope I'm not forgetting something we have talked before my vacation. Thanks, -- heikki
WARNING: multiple messages have this Message-ID (diff)
From: heikki.krogerus@linux.intel.com (Heikki Krogerus) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/5] arm: omap3: twl: use the new lookup method with usb phy Date: Tue, 14 Jan 2014 16:38:49 +0200 [thread overview] Message-ID: <20140114143849.GB21169@xps8300> (raw) In-Reply-To: <52CBFAC0.9040103@ti.com> On Tue, Jan 07, 2014 at 06:31:52PM +0530, Kishon Vijay Abraham I wrote: > > In any case, having two device names to deal with does not add any > > more risk. These associations should always be made in the place where > > the phy device is created so you will always know it's device name. > > huh.. we should also know the 'controller' device name while defining these > associations and in some cases the controller device and phy device are created > in entirely different places. If you don't want to use the controller device name to do the matching, we can use the con_id string as well. I believe the lookup method I use in this set just needs a small change. Is that OK with you? > > Normally the platform code creates these associations in the same > > place it creates the platform devices, so you definitely know what the > > device names will be. > > > > In this case it's actually created in drivers/mfd/twl-core.c, so I do > > need to update this and move the lookup table there. We can still > > deliver the user name as platform data, though I believe it's always > > "musb". Maybe we could actually skip that and just hard code the name? > > I would rather leave the way it is modelled now. Do you mean, leave it in the platform code? Why? We would reduce the platform code by moving it to the mfd driver. Or did I misunderstood something? Hope I'm not forgetting something we have talked before my vacation. Thanks, -- heikki
next prev parent reply other threads:[~2014-01-14 14:39 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-12-09 15:08 [PATCH 0/5] phy: remove the need for the phys to know about their users Heikki Krogerus 2013-12-09 15:08 ` Heikki Krogerus 2013-12-09 15:08 ` [PATCH 1/5] phy: unify the phy name parameters Heikki Krogerus 2013-12-09 15:08 ` Heikki Krogerus 2013-12-09 15:08 ` Heikki Krogerus 2013-12-09 15:08 ` [PATCH 2/5] phy: add support for indexed lookup Heikki Krogerus 2013-12-09 15:08 ` Heikki Krogerus 2013-12-16 11:02 ` Kishon Vijay Abraham I 2013-12-16 11:02 ` Kishon Vijay Abraham I 2013-12-16 11:02 ` Kishon Vijay Abraham I 2013-12-16 14:32 ` Heikki Krogerus 2013-12-16 14:32 ` Heikki Krogerus 2014-01-07 13:40 ` Kishon Vijay Abraham I 2014-01-07 13:40 ` Kishon Vijay Abraham I 2014-01-07 13:40 ` Kishon Vijay Abraham I 2014-01-14 14:23 ` Heikki Krogerus 2014-01-14 14:23 ` Heikki Krogerus 2014-01-15 14:11 ` Kishon Vijay Abraham I 2014-01-15 14:11 ` Kishon Vijay Abraham I 2014-01-15 14:11 ` Kishon Vijay Abraham I 2013-12-09 15:08 ` [PATCH 3/5] phy: improved lookup method Heikki Krogerus 2013-12-09 15:08 ` Heikki Krogerus 2013-12-09 15:08 ` [PATCH 4/5] arm: omap3: twl: use the new lookup method with usb phy Heikki Krogerus 2013-12-09 15:08 ` Heikki Krogerus 2013-12-16 11:04 ` Kishon Vijay Abraham I 2013-12-16 11:04 ` Kishon Vijay Abraham I 2013-12-16 11:04 ` Kishon Vijay Abraham I 2013-12-16 14:43 ` Heikki Krogerus 2013-12-16 14:43 ` Heikki Krogerus 2014-01-07 13:01 ` Kishon Vijay Abraham I 2014-01-07 13:01 ` Kishon Vijay Abraham I 2014-01-07 13:01 ` Kishon Vijay Abraham I 2014-01-14 14:38 ` Heikki Krogerus [this message] 2014-01-14 14:38 ` Heikki Krogerus 2014-01-15 14:11 ` Kishon Vijay Abraham I 2014-01-15 14:11 ` Kishon Vijay Abraham I 2014-01-15 14:11 ` Kishon Vijay Abraham I 2014-01-16 11:58 ` Heikki Krogerus 2014-01-16 11:58 ` Heikki Krogerus 2014-01-08 17:53 ` Tony Lindgren 2014-01-08 17:53 ` Tony Lindgren 2013-12-09 15:08 ` [PATCH] phy: remove the old lookup method Heikki Krogerus 2013-12-09 15:08 ` Heikki Krogerus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140114143849.GB21169@xps8300 \ --to=heikki.krogerus@linux.intel.com \ --cc=kishon@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.