All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: dri-devel@lists.freedesktop.org
Cc: Dave Airlie <airlied@gmail.com>, Rob Clark <robdclark@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: [PATCH v3 09/24] drm/i2c: tda998x: use HDMI constants
Date: Sun, 19 Jan 2014 19:58:42 +0100	[thread overview]
Message-ID: <20140119195842.5790f26d@armhf> (raw)
In-Reply-To: <cover.1390153344.git.moinejf@free.fr>

This patch replaces hard coded values by hdmi constants.

Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 78d324b..978edaf 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -549,12 +549,12 @@ tda998x_write_if(struct tda998x_priv *priv, uint8_t bit, uint16_t addr,
 static void
 tda998x_write_aif(struct tda998x_priv *priv, struct tda998x_encoder_params *p)
 {
-	uint8_t buf[PB(5) + 1];
+	u8 buf[PB(HDMI_AUDIO_INFOFRAME_SIZE) + 1];
 
 	memset(buf, 0, sizeof(buf));
-	buf[HB(0)] = 0x84;
+	buf[HB(0)] = HDMI_INFOFRAME_TYPE_AUDIO;
 	buf[HB(1)] = 0x01;
-	buf[HB(2)] = 10;
+	buf[HB(2)] = HDMI_AUDIO_INFOFRAME_SIZE;
 	buf[PB(1)] = p->audio_frame[1] & 0x07; /* CC */
 	buf[PB(2)] = p->audio_frame[2] & 0x1c; /* SF */
 	buf[PB(4)] = p->audio_frame[4];
@@ -567,12 +567,12 @@ tda998x_write_aif(struct tda998x_priv *priv, struct tda998x_encoder_params *p)
 static void
 tda998x_write_avi(struct tda998x_priv *priv, struct drm_display_mode *mode)
 {
-	uint8_t buf[PB(13) + 1];
+	u8 buf[PB(HDMI_AVI_INFOFRAME_SIZE) + 1];
 
 	memset(buf, 0, sizeof(buf));
-	buf[HB(0)] = 0x82;
+	buf[HB(0)] = HDMI_INFOFRAME_TYPE_AVI;
 	buf[HB(1)] = 0x02;
-	buf[HB(2)] = 13;
+	buf[HB(2)] = HDMI_AVI_INFOFRAME_SIZE;
 	buf[PB(1)] = HDMI_SCAN_MODE_UNDERSCAN;
 	buf[PB(3)] = HDMI_QUANTIZATION_RANGE_FULL << 2;
 	buf[PB(4)] = drm_match_cea_mode(mode);
-- 
1.8.5.3


WARNING: multiple messages have this Message-ID (diff)
From: moinejf@free.fr (Jean-Francois Moine)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 09/24] drm/i2c: tda998x: use HDMI constants
Date: Sun, 19 Jan 2014 19:58:42 +0100	[thread overview]
Message-ID: <20140119195842.5790f26d@armhf> (raw)
In-Reply-To: <cover.1390153344.git.moinejf@free.fr>

This patch replaces hard coded values by hdmi constants.

Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 78d324b..978edaf 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -549,12 +549,12 @@ tda998x_write_if(struct tda998x_priv *priv, uint8_t bit, uint16_t addr,
 static void
 tda998x_write_aif(struct tda998x_priv *priv, struct tda998x_encoder_params *p)
 {
-	uint8_t buf[PB(5) + 1];
+	u8 buf[PB(HDMI_AUDIO_INFOFRAME_SIZE) + 1];
 
 	memset(buf, 0, sizeof(buf));
-	buf[HB(0)] = 0x84;
+	buf[HB(0)] = HDMI_INFOFRAME_TYPE_AUDIO;
 	buf[HB(1)] = 0x01;
-	buf[HB(2)] = 10;
+	buf[HB(2)] = HDMI_AUDIO_INFOFRAME_SIZE;
 	buf[PB(1)] = p->audio_frame[1] & 0x07; /* CC */
 	buf[PB(2)] = p->audio_frame[2] & 0x1c; /* SF */
 	buf[PB(4)] = p->audio_frame[4];
@@ -567,12 +567,12 @@ tda998x_write_aif(struct tda998x_priv *priv, struct tda998x_encoder_params *p)
 static void
 tda998x_write_avi(struct tda998x_priv *priv, struct drm_display_mode *mode)
 {
-	uint8_t buf[PB(13) + 1];
+	u8 buf[PB(HDMI_AVI_INFOFRAME_SIZE) + 1];
 
 	memset(buf, 0, sizeof(buf));
-	buf[HB(0)] = 0x82;
+	buf[HB(0)] = HDMI_INFOFRAME_TYPE_AVI;
 	buf[HB(1)] = 0x02;
-	buf[HB(2)] = 13;
+	buf[HB(2)] = HDMI_AVI_INFOFRAME_SIZE;
 	buf[PB(1)] = HDMI_SCAN_MODE_UNDERSCAN;
 	buf[PB(3)] = HDMI_QUANTIZATION_RANGE_FULL << 2;
 	buf[PB(4)] = drm_match_cea_mode(mode);
-- 
1.8.5.3

WARNING: multiple messages have this Message-ID (diff)
From: Jean-Francois Moine <moinejf@free.fr>
To: dri-devel@lists.freedesktop.org
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 09/24] drm/i2c: tda998x: use HDMI constants
Date: Sun, 19 Jan 2014 19:58:42 +0100	[thread overview]
Message-ID: <20140119195842.5790f26d@armhf> (raw)
In-Reply-To: <cover.1390153344.git.moinejf@free.fr>

This patch replaces hard coded values by hdmi constants.

Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 78d324b..978edaf 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -549,12 +549,12 @@ tda998x_write_if(struct tda998x_priv *priv, uint8_t bit, uint16_t addr,
 static void
 tda998x_write_aif(struct tda998x_priv *priv, struct tda998x_encoder_params *p)
 {
-	uint8_t buf[PB(5) + 1];
+	u8 buf[PB(HDMI_AUDIO_INFOFRAME_SIZE) + 1];
 
 	memset(buf, 0, sizeof(buf));
-	buf[HB(0)] = 0x84;
+	buf[HB(0)] = HDMI_INFOFRAME_TYPE_AUDIO;
 	buf[HB(1)] = 0x01;
-	buf[HB(2)] = 10;
+	buf[HB(2)] = HDMI_AUDIO_INFOFRAME_SIZE;
 	buf[PB(1)] = p->audio_frame[1] & 0x07; /* CC */
 	buf[PB(2)] = p->audio_frame[2] & 0x1c; /* SF */
 	buf[PB(4)] = p->audio_frame[4];
@@ -567,12 +567,12 @@ tda998x_write_aif(struct tda998x_priv *priv, struct tda998x_encoder_params *p)
 static void
 tda998x_write_avi(struct tda998x_priv *priv, struct drm_display_mode *mode)
 {
-	uint8_t buf[PB(13) + 1];
+	u8 buf[PB(HDMI_AVI_INFOFRAME_SIZE) + 1];
 
 	memset(buf, 0, sizeof(buf));
-	buf[HB(0)] = 0x82;
+	buf[HB(0)] = HDMI_INFOFRAME_TYPE_AVI;
 	buf[HB(1)] = 0x02;
-	buf[HB(2)] = 13;
+	buf[HB(2)] = HDMI_AVI_INFOFRAME_SIZE;
 	buf[PB(1)] = HDMI_SCAN_MODE_UNDERSCAN;
 	buf[PB(3)] = HDMI_QUANTIZATION_RANGE_FULL << 2;
 	buf[PB(4)] = drm_match_cea_mode(mode);
-- 
1.8.5.3

  parent reply	other threads:[~2014-01-19 19:01 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1390153344.git.moinejf@free.fr>
2014-01-19 18:58 ` [PATCH v3 01/24] drm/i2c: tda998x: simplify the i2c read/write functions Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58 ` [PATCH v3 02/24] drm/i2c: tda998x: check more I/O errors Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 21:21   ` Russell King - ARM Linux
2014-01-22 21:21     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 04/24] drm/i2c: tda998x: change probe message origin Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58 ` [PATCH v3 03/24] drm/i2c: tda998x: code cleanup Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 21:22   ` Russell King - ARM Linux
2014-01-22 21:22     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 05/24] drm/i2c: tda998x: don't freeze the system at audio startup time Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58 ` [PATCH v3 06/24] drm/i2c: tda998x: force the page register at " Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58 ` [PATCH v3 07/24] drm/i2c: tda998x: set the video mode from the adjusted value Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 21:28   ` Russell King - ARM Linux
2014-01-22 21:28     ` Russell King - ARM Linux
2014-01-23 23:29   ` Darren Etheridge
2014-01-23 23:29     ` Darren Etheridge
2014-01-23 23:29     ` Darren Etheridge
2014-01-28 17:12     ` Jean-Francois Moine
2014-01-28 17:12       ` Jean-Francois Moine
2014-01-28 17:12       ` Jean-Francois Moine
2014-01-28 19:24       ` Darren Etheridge
2014-01-28 19:24         ` Darren Etheridge
2014-01-28 19:24         ` Darren Etheridge
2014-01-19 18:58 ` [PATCH v3 08/24] drm/i2c: tda998x: fix bad value in the AIF Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58 ` [PATCH v3 12/24] drm/i2c: tda998x: check the CEC device creation Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58 ` [PATCH v3 11/24] drm/i2c: tda998x: free the CEC device on encoder_destroy Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58 ` Jean-Francois Moine [this message]
2014-01-19 18:58   ` [PATCH v3 09/24] drm/i2c: tda998x: use HDMI constants Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58 ` [PATCH v3 10/24] drm/i2c: tda998x: don't read write-only registers Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 21:35   ` Russell King - ARM Linux
2014-01-22 21:35     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 13/24] drm/i2c: tda998x: fix a NULL pointer dereference Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 21:41   ` Russell King - ARM Linux
2014-01-22 21:41     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 15/24] drm/i2c: tda998x: use irq for connection status and EDID read Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 22:27   ` Russell King - ARM Linux
2014-01-22 22:27     ` Russell King - ARM Linux
2014-01-24 17:29     ` Sebastian Hesselbarth
2014-01-24 17:29       ` Sebastian Hesselbarth
2014-01-24 17:47       ` Russell King - ARM Linux
2014-01-24 17:47         ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 14/24] drm/i2c: tda998x: add DT support Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 21:37   ` Russell King - ARM Linux
2014-01-22 21:37     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 17/24] drm/i2c: tda998x: get a better status of the connection Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 22:51   ` Russell King - ARM Linux
2014-01-22 22:51     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 16/24] drm/i2c: tda998x: add DT documentation Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-20  4:06   ` Olof Johansson
2014-01-20  4:06     ` Olof Johansson
2014-01-20  4:06     ` Olof Johansson
2014-01-20  9:54     ` Jean-Francois Moine
2014-01-20  9:54     ` Jean-Francois Moine
2014-01-20  9:54       ` Jean-Francois Moine
2014-01-20  9:54       ` Jean-Francois Moine
2014-01-21 18:17       ` Olof Johansson
2014-01-21 18:17         ` Olof Johansson
2014-01-21 18:17         ` Olof Johansson
2014-01-22 22:40         ` Russell King - ARM Linux
2014-01-22 22:40           ` Russell King - ARM Linux
2014-01-22 22:40           ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 19/24] drm/i2c: tda998x: use global constants Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 23:29   ` Russell King - ARM Linux
2014-01-22 23:29     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 18/24] drm/i2c: tda998x: fix the ENABLE_SPACE register Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 23:27   ` Russell King - ARM Linux
2014-01-22 23:27     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 21/24] drm/i2c: tda998x: add the active aspect in HDMI AVI frame Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 23:37   ` Russell King - ARM Linux
2014-01-22 23:37     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 20/24] drm/i2c: tda998x: remove the unused variable ca_i2s Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 23:30   ` Russell King - ARM Linux
2014-01-22 23:30     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 23/24] drm/i2c: tda998x: code optimization Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58 ` [PATCH v3 22/24] drm/i2c: tda998x: change the frequence in the audio channel Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-22 23:52   ` Russell King - ARM Linux
2014-01-22 23:52     ` Russell King - ARM Linux
2014-01-19 18:58 ` [PATCH v3 24/24] drm/i2c: tda998x: adjust the audio clock divider for S/PDIF Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine
2014-01-19 18:58   ` Jean-Francois Moine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140119195842.5790f26d@armhf \
    --to=moinejf@free.fr \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.