All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] drm: use after free in drm_pci_exit()
@ 2014-01-20 10:31 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2014-01-20 10:31 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter; +Cc: dri-devel, kernel-janitors

We can't use "dev" after we freed it on the line before.

Fixes: b3f2333de8e8 ('drm: restrict the device list for shadow attached drivers')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
index 5736aaa7e86c..f7af69bcf3f4 100644
--- a/drivers/gpu/drm/drm_pci.c
+++ b/drivers/gpu/drm/drm_pci.c
@@ -468,8 +468,8 @@ void drm_pci_exit(struct drm_driver *driver, struct pci_driver *pdriver)
 	} else {
 		list_for_each_entry_safe(dev, tmp, &driver->legacy_dev_list,
 					 legacy_dev_list) {
-			drm_put_dev(dev);
 			list_del(&dev->legacy_dev_list);
+			drm_put_dev(dev);
 		}
 	}
 	DRM_INFO("Module unloaded\n");

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [patch] drm: use after free in drm_pci_exit()
@ 2014-01-20 10:31 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2014-01-20 10:31 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter; +Cc: dri-devel, kernel-janitors

We can't use "dev" after we freed it on the line before.

Fixes: b3f2333de8e8 ('drm: restrict the device list for shadow attached drivers')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
index 5736aaa7e86c..f7af69bcf3f4 100644
--- a/drivers/gpu/drm/drm_pci.c
+++ b/drivers/gpu/drm/drm_pci.c
@@ -468,8 +468,8 @@ void drm_pci_exit(struct drm_driver *driver, struct pci_driver *pdriver)
 	} else {
 		list_for_each_entry_safe(dev, tmp, &driver->legacy_dev_list,
 					 legacy_dev_list) {
-			drm_put_dev(dev);
 			list_del(&dev->legacy_dev_list);
+			drm_put_dev(dev);
 		}
 	}
 	DRM_INFO("Module unloaded\n");

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [patch] drm: use after free in drm_pci_exit()
  2014-01-20 10:31 ` Dan Carpenter
@ 2014-03-14 16:19   ` Aaron Plattner
  -1 siblings, 0 replies; 6+ messages in thread
From: Aaron Plattner @ 2014-03-14 16:19 UTC (permalink / raw)
  To: Dan Carpenter, David Airlie, Daniel Vetter; +Cc: kernel-janitors, dri-devel

On 01/20/2014 02:31 AM, Dan Carpenter wrote:
> We can't use "dev" after we freed it on the line before.
>
> Fixes: b3f2333de8e8 ('drm: restrict the device list for shadow attached drivers')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

I just ran into this same problem, and this change fixes it.

Tested-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>

and since he just sent me an independently-developed identical change,

Reviewed-by: John Hubbard <jhubbard@nvidia.com>

> diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
> index 5736aaa7e86c..f7af69bcf3f4 100644
> --- a/drivers/gpu/drm/drm_pci.c
> +++ b/drivers/gpu/drm/drm_pci.c
> @@ -468,8 +468,8 @@ void drm_pci_exit(struct drm_driver *driver, struct pci_driver *pdriver)
>   	} else {
>   		list_for_each_entry_safe(dev, tmp, &driver->legacy_dev_list,
>   					 legacy_dev_list) {
> -			drm_put_dev(dev);
>   			list_del(&dev->legacy_dev_list);
> +			drm_put_dev(dev);
>   		}
>   	}
>   	DRM_INFO("Module unloaded\n");
> --


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [patch] drm: use after free in drm_pci_exit()
@ 2014-03-14 16:19   ` Aaron Plattner
  0 siblings, 0 replies; 6+ messages in thread
From: Aaron Plattner @ 2014-03-14 16:19 UTC (permalink / raw)
  To: Dan Carpenter, David Airlie, Daniel Vetter; +Cc: kernel-janitors, dri-devel

On 01/20/2014 02:31 AM, Dan Carpenter wrote:
> We can't use "dev" after we freed it on the line before.
>
> Fixes: b3f2333de8e8 ('drm: restrict the device list for shadow attached drivers')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

I just ran into this same problem, and this change fixes it.

Tested-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>

and since he just sent me an independently-developed identical change,

Reviewed-by: John Hubbard <jhubbard@nvidia.com>

> diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
> index 5736aaa7e86c..f7af69bcf3f4 100644
> --- a/drivers/gpu/drm/drm_pci.c
> +++ b/drivers/gpu/drm/drm_pci.c
> @@ -468,8 +468,8 @@ void drm_pci_exit(struct drm_driver *driver, struct pci_driver *pdriver)
>   	} else {
>   		list_for_each_entry_safe(dev, tmp, &driver->legacy_dev_list,
>   					 legacy_dev_list) {
> -			drm_put_dev(dev);
>   			list_del(&dev->legacy_dev_list);
> +			drm_put_dev(dev);
>   		}
>   	}
>   	DRM_INFO("Module unloaded\n");
> --

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [patch] drm: use after free in drm_pci_exit()
  2014-03-14 16:19   ` Aaron Plattner
@ 2014-03-17 10:24     ` Daniel Vetter
  -1 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2014-03-17 10:24 UTC (permalink / raw)
  To: Aaron Plattner; +Cc: kernel-janitors, dri-devel, Dan Carpenter

On Fri, Mar 14, 2014 at 5:19 PM, Aaron Plattner <aplattner@nvidia.com> wrote:
> On 01/20/2014 02:31 AM, Dan Carpenter wrote:
>>
>> We can't use "dev" after we freed it on the line before.
>>
>> Fixes: b3f2333de8e8 ('drm: restrict the device list for shadow attached
>> drivers')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
>
> I just ran into this same problem, and this change fixes it.
>
> Tested-by: Aaron Plattner <aplattner@nvidia.com>
> Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
>
> and since he just sent me an independently-developed identical change,
>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>

Hey, I have such a patch too!

http://patchwork.freedesktop.org/patch/19163/

Dave? I think I'll just send a pull for my random pile of drm core
patches I've shepharded ...

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [patch] drm: use after free in drm_pci_exit()
@ 2014-03-17 10:24     ` Daniel Vetter
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2014-03-17 10:24 UTC (permalink / raw)
  To: Aaron Plattner; +Cc: kernel-janitors, dri-devel, Dan Carpenter

On Fri, Mar 14, 2014 at 5:19 PM, Aaron Plattner <aplattner@nvidia.com> wrote:
> On 01/20/2014 02:31 AM, Dan Carpenter wrote:
>>
>> We can't use "dev" after we freed it on the line before.
>>
>> Fixes: b3f2333de8e8 ('drm: restrict the device list for shadow attached
>> drivers')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
>
> I just ran into this same problem, and this change fixes it.
>
> Tested-by: Aaron Plattner <aplattner@nvidia.com>
> Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
>
> and since he just sent me an independently-developed identical change,
>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>

Hey, I have such a patch too!

http://patchwork.freedesktop.org/patch/19163/

Dave? I think I'll just send a pull for my random pile of drm core
patches I've shepharded ...

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-17 10:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-20 10:31 [patch] drm: use after free in drm_pci_exit() Dan Carpenter
2014-01-20 10:31 ` Dan Carpenter
2014-03-14 16:19 ` Aaron Plattner
2014-03-14 16:19   ` Aaron Plattner
2014-03-17 10:24   ` Daniel Vetter
2014-03-17 10:24     ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.