Re: [PATCH] Use uint32_t for lttng_viewer_stream.metadata_flag

Re: [PATCH] Use uint32_t for lttng_viewer_stream.metadata_flag

[Simon Marchi]

[-- Attachment #1.1: Type: text/plain, Size: 1189 bytes --]

While you are at it, you could change the char fields as well, since char
is not exact-width either.


On 17 January 2014 18:47, Marc-Andre Laperle <
marc-andre.laperle@ericsson.com> wrote:

> This struct is meant to be sent over the network so members should be
> of exact-width.
>
> Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
> ---
>  src/bin/lttng-relayd/lttng-viewer.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bin/lttng-relayd/lttng-viewer.h
> b/src/bin/lttng-relayd/lttng-viewer.h
> index 1977a43..6330270 100644
> --- a/src/bin/lttng-relayd/lttng-viewer.h
> +++ b/src/bin/lttng-relayd/lttng-viewer.h
> @@ -100,7 +100,7 @@ struct lttng_viewer_session {
>  struct lttng_viewer_stream {
>         uint64_t id;
>         uint64_t ctf_trace_id;
> -       int metadata_flag;
> +       uint32_t metadata_flag;
>         char path_name[LTTNG_VIEWER_PATH_MAX];
>         char channel_name[LTTNG_VIEWER_NAME_MAX];
>  } __attribute__((__packed__));
> --
> 1.8.3.2
>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>

[-- Attachment #1.2: Type: text/html, Size: 1839 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [PATCH] Use uint32_t for lttng_viewer_stream.metadata_flag

[Marc-André Laperle]

[-- Attachment #1.1: Type: text/plain, Size: 1783 bytes --]

I'm not sure that's possible. Whether I change them to uint8_t or int8_t, I get warnings because they get used with strncpy which wants char. Any idea how to solve this?

Marc-André

________________________________
From: thundersim@gmail.com [thundersim@gmail.com] on behalf of Simon Marchi [simon.marchi@polymtl.ca]
Sent: Friday, 17 January 2014 9:31 PM
To: Marc-André Laperle
Cc: lttng-dev@lists.lttng.org
Subject: Re: [lttng-dev] [PATCH] Use uint32_t for lttng_viewer_stream.metadata_flag

While you are at it, you could change the char fields as well, since char is not exact-width either.


On 17 January 2014 18:47, Marc-Andre Laperle <marc-andre.laperle@ericsson.com<mailto:marc-andre.laperle@ericsson.com>> wrote:
This struct is meant to be sent over the network so members should be
of exact-width.

Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com<mailto:marc-andre.laperle@ericsson.com>>
---
 src/bin/lttng-relayd/lttng-viewer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/lttng-relayd/lttng-viewer.h b/src/bin/lttng-relayd/lttng-viewer.h
index 1977a43..6330270 100644
--- a/src/bin/lttng-relayd/lttng-viewer.h
+++ b/src/bin/lttng-relayd/lttng-viewer.h
@@ -100,7 +100,7 @@ struct lttng_viewer_session {
 struct lttng_viewer_stream {
        uint64_t id;
        uint64_t ctf_trace_id;
-       int metadata_flag;
+       uint32_t metadata_flag;
        char path_name[LTTNG_VIEWER_PATH_MAX];
        char channel_name[LTTNG_VIEWER_NAME_MAX];
 } __attribute__((__packed__));
--
1.8.3.2


_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org<mailto:lttng-dev@lists.lttng.org>
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


[-- Attachment #1.2: Type: text/html, Size: 3159 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [PATCH] Use uint32_t for lttng_viewer_stream.metadata_flag

[Mathieu Desnoyers]

[-- Attachment #1.1: Type: text/plain, Size: 2419 bytes --]

Using a char should be OK here. 

----- Original Message -----

> From: "Marc-André Laperle" <marc-andre.laperle@ericsson.com>
> To: "Simon Marchi" <simon.marchi@polymtl.ca>
> Cc: lttng-dev@lists.lttng.org
> Sent: Monday, January 20, 2014 3:25:07 PM
> Subject: Re: [lttng-dev] [PATCH] Use uint32_t for
> lttng_viewer_stream.metadata_flag

> I'm not sure that's possible. Whether I change them to uint8_t or int8_t, I
> get warnings because they get used with strncpy which wants char. Any idea
> how to solve this?

> Marc-André

> From: thundersim@gmail.com [thundersim@gmail.com] on behalf of Simon Marchi
> [simon.marchi@polymtl.ca]
> Sent: Friday, 17 January 2014 9:31 PM
> To: Marc-André Laperle
> Cc: lttng-dev@lists.lttng.org
> Subject: Re: [lttng-dev] [PATCH] Use uint32_t for
> lttng_viewer_stream.metadata_flag

> While you are at it, you could change the char fields as well, since char is
> not exact-width either.

> On 17 January 2014 18:47, Marc-Andre Laperle <
> marc-andre.laperle@ericsson.com > wrote:

> > This struct is meant to be sent over the network so members should be
> 
> > of exact-width.
> 

> > Signed-off-by: Marc-Andre Laperle < marc-andre.laperle@ericsson.com >
> 
> > ---
> 
> > src/bin/lttng-relayd/lttng-viewer.h | 2 +-
> 
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> 

> > diff --git a/src/bin/lttng-relayd/lttng-viewer.h
> > b/src/bin/lttng-relayd/lttng-viewer.h
> 
> > index 1977a43..6330270 100644
> 
> > --- a/src/bin/lttng-relayd/lttng-viewer.h
> 
> > +++ b/src/bin/lttng-relayd/lttng-viewer.h
> 
> > @@ -100,7 +100,7 @@ struct lttng_viewer_session {
> 
> > struct lttng_viewer_stream {
> 
> > uint64_t id;
> 
> > uint64_t ctf_trace_id;
> 
> > - int metadata_flag;
> 
> > + uint32_t metadata_flag;
> 
> > char path_name[LTTNG_VIEWER_PATH_MAX];
> 
> > char channel_name[LTTNG_VIEWER_NAME_MAX];
> 
> > } __attribute__((__packed__));
> 
> > --
> 
> > 1.8.3.2
> 

> > _______________________________________________
> 
> > lttng-dev mailing list
> 
> > lttng-dev@lists.lttng.org
> 
> > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
> 

> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers 
EfficiOS Inc. 
http://www.efficios.com 

[-- Attachment #1.2: Type: text/html, Size: 4278 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [PATCH] Use uint32_t for lttng_viewer_stream.metadata_flag

[David Goulet]

[-- Attachment #1.1: Type: text/plain, Size: 1296 bytes --]

FYI, there is a lot of development on the relayd right now so I'll be
merging this patch with everything else thus consider it merged but not
yet upstream.

Once upstream in the master branch, it will be ported to 2.4 stable.

Big thanks!
David

On 17 Jan (18:47:43), Marc-Andre Laperle wrote:
> This struct is meant to be sent over the network so members should be
> of exact-width.
> 
> Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
> ---
>  src/bin/lttng-relayd/lttng-viewer.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/bin/lttng-relayd/lttng-viewer.h b/src/bin/lttng-relayd/lttng-viewer.h
> index 1977a43..6330270 100644
> --- a/src/bin/lttng-relayd/lttng-viewer.h
> +++ b/src/bin/lttng-relayd/lttng-viewer.h
> @@ -100,7 +100,7 @@ struct lttng_viewer_session {
>  struct lttng_viewer_stream {
>  	uint64_t id;
>  	uint64_t ctf_trace_id;
> -	int metadata_flag;
> +	uint32_t metadata_flag;
>  	char path_name[LTTNG_VIEWER_PATH_MAX];
>  	char channel_name[LTTNG_VIEWER_NAME_MAX];
>  } __attribute__((__packed__));
> -- 
> 1.8.3.2
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 603 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[PATCH] Use uint32_t for lttng_viewer_stream.metadata_flag

[Marc-Andre Laperle]

This struct is meant to be sent over the network so members should be
of exact-width.

Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
---
 src/bin/lttng-relayd/lttng-viewer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/lttng-relayd/lttng-viewer.h b/src/bin/lttng-relayd/lttng-viewer.h
index 1977a43..6330270 100644
--- a/src/bin/lttng-relayd/lttng-viewer.h
+++ b/src/bin/lttng-relayd/lttng-viewer.h
@@ -100,7 +100,7 @@ struct lttng_viewer_session {
 struct lttng_viewer_stream {
 	uint64_t id;
 	uint64_t ctf_trace_id;
-	int metadata_flag;
+	uint32_t metadata_flag;
 	char path_name[LTTNG_VIEWER_PATH_MAX];
 	char channel_name[LTTNG_VIEWER_NAME_MAX];
 } __attribute__((__packed__));
-- 
1.8.3.2