* [PATCH] SoC: wm8991: Remove unused pointer in wm8991_probe()
@ 2014-02-04 20:20 Christian Engelmayer
2014-02-07 13:39 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Christian Engelmayer @ 2014-02-04 20:20 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 881 bytes --]
Remove unused pointer 'wm8991' in function wm8991_probe(). The last user
vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)
Detected by Coverity: CID 1162831
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
sound/soc/codecs/wm8991.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/wm8991.c b/sound/soc/codecs/wm8991.c
index dba0306..244eb09 100644
--- a/sound/soc/codecs/wm8991.c
+++ b/sound/soc/codecs/wm8991.c
@@ -1251,11 +1251,8 @@ static int wm8991_remove(struct snd_soc_codec *codec)
static int wm8991_probe(struct snd_soc_codec *codec)
{
- struct wm8991_priv *wm8991;
int ret;
- wm8991 = snd_soc_codec_get_drvdata(codec);
-
ret = snd_soc_codec_set_cache_io(codec, 8, 16, SND_SOC_REGMAP);
if (ret < 0) {
dev_err(codec->dev, "Failed to set cache i/o: %d\n", ret);
--
1.8.3.2
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] SoC: wm8991: Remove unused pointer in wm8991_probe()
2014-02-04 20:20 [PATCH] SoC: wm8991: Remove unused pointer in wm8991_probe() Christian Engelmayer
@ 2014-02-07 13:39 ` Mark Brown
2014-02-07 18:43 ` [PATCH v2] ASoC: " Christian Engelmayer
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2014-02-07 13:39 UTC (permalink / raw)
To: Christian Engelmayer; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 389 bytes --]
On Tue, Feb 04, 2014 at 09:20:59PM +0100, Christian Engelmayer wrote:
> Remove unused pointer 'wm8991' in function wm8991_probe(). The last user
> vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)
>
> Detected by Coverity: CID 1162831
This doesn't apply against current code, please check and resend and
please also remember to CC maintainers on patches.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] ASoC: wm8991: Remove unused pointer in wm8991_probe()
2014-02-07 13:39 ` Mark Brown
@ 2014-02-07 18:43 ` Christian Engelmayer
2014-02-07 20:51 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Christian Engelmayer @ 2014-02-07 18:43 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, patches, Graeme.Gregory, Liam Girdwood, Charles Keepax
[-- Attachment #1.1: Type: text/plain, Size: 1185 bytes --]
Remove unused pointer 'wm8991' in function wm8991_probe(). The last user
vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)
Detected by Coverity: CID 1162831
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
v2: Resend after input by Mark Brown
* Added ASoC maintainer CC.
* Added driver maintainer CC.
* Verified that the patch applies against v3.14-rc1 as well as branch
for-next in git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git.
* Fixed a typo in the summary phrase.
---
sound/soc/codecs/wm8991.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/wm8991.c b/sound/soc/codecs/wm8991.c
index dba0306..244eb09 100644
--- a/sound/soc/codecs/wm8991.c
+++ b/sound/soc/codecs/wm8991.c
@@ -1251,11 +1251,8 @@ static int wm8991_remove(struct snd_soc_codec *codec)
static int wm8991_probe(struct snd_soc_codec *codec)
{
- struct wm8991_priv *wm8991;
int ret;
- wm8991 = snd_soc_codec_get_drvdata(codec);
-
ret = snd_soc_codec_set_cache_io(codec, 8, 16, SND_SOC_REGMAP);
if (ret < 0) {
dev_err(codec->dev, "Failed to set cache i/o: %d\n", ret);
--
1.8.3.2
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ASoC: wm8991: Remove unused pointer in wm8991_probe()
2014-02-07 18:43 ` [PATCH v2] ASoC: " Christian Engelmayer
@ 2014-02-07 20:51 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-02-07 20:51 UTC (permalink / raw)
To: Christian Engelmayer; +Cc: alsa-devel, patches, Charles Keepax, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 285 bytes --]
On Fri, Feb 07, 2014 at 07:43:19PM +0100, Christian Engelmayer wrote:
> Remove unused pointer 'wm8991' in function wm8991_probe(). The last user
> vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)
>
> Detected by Coverity: CID 1162831
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-07 20:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-04 20:20 [PATCH] SoC: wm8991: Remove unused pointer in wm8991_probe() Christian Engelmayer
2014-02-07 13:39 ` Mark Brown
2014-02-07 18:43 ` [PATCH v2] ASoC: " Christian Engelmayer
2014-02-07 20:51 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.