All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
@ 2014-01-30 13:44 Avinash kumar
  2014-02-07 18:48 ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Avinash kumar @ 2014-01-30 13:44 UTC (permalink / raw)
  To: lidza.louina; +Cc: gregkh, driverdev-devel, Avinash kumar

drivers:staging:dgnc:dpacompat.h- removed following checkpatch.pl reported warnings

sccc@ubuntu:~/lk/rc/linux$ ./scripts/checkpatch.pl --terse --file drivers/staging/dgnc/dpacompat.h 
drivers/staging/dgnc/dpacompat.h:109: ERROR: Macros with complex values should be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:110: ERROR: Macros with complex values should be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:111: ERROR: Macros with complex values should be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:114: WARNING: line over 80 characters
drivers/staging/dgnc/dpacompat.h:114: ERROR: Macros with complex values should be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:115: WARNING: line over 80 characters
drivers/staging/dgnc/dpacompat.h:115: ERROR: Macros with complex values should be enclosed in parenthesis
total: 5 errors, 2 warnings, 115 lines checked

Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>

---
 drivers/staging/dgnc/dpacompat.h |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/dgnc/dpacompat.h b/drivers/staging/dgnc/dpacompat.h
index f96963b..b451c10 100644
--- a/drivers/staging/dgnc/dpacompat.h
+++ b/drivers/staging/dgnc/dpacompat.h
@@ -24,7 +24,7 @@
  * This structure holds data needed for the intelligent <--> nonintelligent
  * DPA translation
  */
- struct ni_info {
+struct ni_info {
 	int board;
 	int channel;
 	int dtr;
@@ -51,7 +51,7 @@
 
 #define RW_READ		1
 #define RW_WRITE        2
-#define DIGI_KME        ('e'<<8) | 98           /* Read/Write Host */
+#define DIGI_KME        (('e'<<8) | 98)           /* Read/Write Host */
 
 #define SUBTYPE         0007
 #define T_PCXI          0000
@@ -106,10 +106,10 @@
 
 /* Ioctls needed for dpa operation */
 
-#define DIGI_GETDD      ('d'<<8) | 248          /* get driver info      */
-#define DIGI_GETBD      ('d'<<8) | 249          /* get board info       */
-#define DIGI_GET_NI_INFO ('d'<<8) | 250		/* nonintelligent state snfo */
+#define DIGI_GETDD       (('d'<<8) | 248) /* get driver info */
+#define DIGI_GETBD       (('d'<<8) | 249) /* get board info */
+#define DIGI_GET_NI_INFO (('d'<<8) | 250) /* nonintelligent state snfo */
 
 /* Other special ioctls */
-#define DIGI_TIMERIRQ ('d'<<8) | 251		/* Enable/disable RS_TIMER use */
-#define DIGI_LOOPBACK ('d'<<8) | 252		/* Enable/disable UART internal loopback */
+#define DIGI_TIMERIRQ (('d'<<8) | 251)/* Enable/disable RS_TIMER use*/
+#define DIGI_LOOPBACK (('d'<<8) | 252)/* Enable/disable UART internal loopback*/
-- 
1.7.9.5

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
  2014-01-30 13:44 [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings Avinash kumar
@ 2014-02-07 18:48 ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2014-02-07 18:48 UTC (permalink / raw)
  To: Avinash kumar; +Cc: lidza.louina, driverdev-devel

On Thu, Jan 30, 2014 at 07:14:02PM +0530, Avinash kumar wrote:
> drivers:staging:dgnc:dpacompat.h- removed following checkpatch.pl reported warnings
> 
> sccc@ubuntu:~/lk/rc/linux$ ./scripts/checkpatch.pl --terse --file drivers/staging/dgnc/dpacompat.h 
> drivers/staging/dgnc/dpacompat.h:109: ERROR: Macros with complex values should be enclosed in parenthesis
> drivers/staging/dgnc/dpacompat.h:110: ERROR: Macros with complex values should be enclosed in parenthesis
> drivers/staging/dgnc/dpacompat.h:111: ERROR: Macros with complex values should be enclosed in parenthesis
> drivers/staging/dgnc/dpacompat.h:114: WARNING: line over 80 characters
> drivers/staging/dgnc/dpacompat.h:114: ERROR: Macros with complex values should be enclosed in parenthesis
> drivers/staging/dgnc/dpacompat.h:115: WARNING: line over 80 characters
> drivers/staging/dgnc/dpacompat.h:115: ERROR: Macros with complex values should be enclosed in parenthesis
> total: 5 errors, 2 warnings, 115 lines checked
> 
> Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>

I don't think you built the driver after making this change, otherwise
all of the build warnings you just added would have hinted that this fix
was not correct :(

Please be more careful in the future and always test your patches before
sending them out.

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
  2014-01-30 14:22   ` Avinash Kumar
@ 2014-01-30 14:57     ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2014-01-30 14:57 UTC (permalink / raw)
  To: Avinash Kumar; +Cc: lidza.louina, driverdev-devel

On Thu, Jan 30, 2014 at 07:52:27PM +0530, Avinash Kumar wrote:
> Apologies for not including in the body of the email.

Please resend this with the information properly in the patch changelog
entry.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
  2014-01-30 13:07 ` Greg KH
@ 2014-01-30 14:22   ` Avinash Kumar
  2014-01-30 14:57     ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Avinash Kumar @ 2014-01-30 14:22 UTC (permalink / raw)
  To: Greg KH; +Cc: lidza.louina, driverdev-devel

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

Apologies for not including in the body of the email.

warnings are as below:

sccc@ubuntu:~/lk/rc/linux$ ./scripts/checkpatch.pl --terse --file
drivers/staging/dgnc/dpacompat.h
drivers/staging/dgnc/dpacompat.h:109: ERROR: Macros with complex values
should be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:110: ERROR: Macros with complex values
should be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:111: ERROR: Macros with complex values
should be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:114: WARNING: line over 80 characters
drivers/staging/dgnc/dpacompat.h:114: ERROR: Macros with complex values
should be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:115: WARNING: line over 80 characters
drivers/staging/dgnc/dpacompat.h:115: ERROR: Macros with complex values
should be enclosed in parenthesis
total: 5 errors, 2 warnings, 115 lines checked

thanks,
Avinash



On Thu, Jan 30, 2014 at 6:37 PM, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Thu, Jan 30, 2014 at 06:18:48PM +0530, Avinash kumar wrote:
> > drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported
> warnings
>
> Which warnings?
>
>

[-- Attachment #2: Type: text/html, Size: 1791 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
  2014-01-30 12:48 Avinash kumar
@ 2014-01-30 13:07 ` Greg KH
  2014-01-30 14:22   ` Avinash Kumar
  0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2014-01-30 13:07 UTC (permalink / raw)
  To: Avinash kumar; +Cc: lidza.louina, driverdev-devel

On Thu, Jan 30, 2014 at 06:18:48PM +0530, Avinash kumar wrote:
> drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings

Which warnings?

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
@ 2014-01-30 12:48 Avinash kumar
  2014-01-30 13:07 ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Avinash kumar @ 2014-01-30 12:48 UTC (permalink / raw)
  To: lidza.louina; +Cc: gregkh, driverdev-devel, Avinash kumar

drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings

Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>

---
 drivers/staging/dgnc/dpacompat.h |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/dgnc/dpacompat.h b/drivers/staging/dgnc/dpacompat.h
index f96963b..b451c10 100644
--- a/drivers/staging/dgnc/dpacompat.h
+++ b/drivers/staging/dgnc/dpacompat.h
@@ -24,7 +24,7 @@
  * This structure holds data needed for the intelligent <--> nonintelligent
  * DPA translation
  */
- struct ni_info {
+struct ni_info {
 	int board;
 	int channel;
 	int dtr;
@@ -51,7 +51,7 @@
 
 #define RW_READ		1
 #define RW_WRITE        2
-#define DIGI_KME        ('e'<<8) | 98           /* Read/Write Host */
+#define DIGI_KME        (('e'<<8) | 98)           /* Read/Write Host */
 
 #define SUBTYPE         0007
 #define T_PCXI          0000
@@ -106,10 +106,10 @@
 
 /* Ioctls needed for dpa operation */
 
-#define DIGI_GETDD      ('d'<<8) | 248          /* get driver info      */
-#define DIGI_GETBD      ('d'<<8) | 249          /* get board info       */
-#define DIGI_GET_NI_INFO ('d'<<8) | 250		/* nonintelligent state snfo */
+#define DIGI_GETDD       (('d'<<8) | 248) /* get driver info */
+#define DIGI_GETBD       (('d'<<8) | 249) /* get board info */
+#define DIGI_GET_NI_INFO (('d'<<8) | 250) /* nonintelligent state snfo */
 
 /* Other special ioctls */
-#define DIGI_TIMERIRQ ('d'<<8) | 251		/* Enable/disable RS_TIMER use */
-#define DIGI_LOOPBACK ('d'<<8) | 252		/* Enable/disable UART internal loopback */
+#define DIGI_TIMERIRQ (('d'<<8) | 251)/* Enable/disable RS_TIMER use*/
+#define DIGI_LOOPBACK (('d'<<8) | 252)/* Enable/disable UART internal loopback*/
-- 
1.7.9.5

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-07 18:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-30 13:44 [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings Avinash kumar
2014-02-07 18:48 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2014-01-30 12:48 Avinash kumar
2014-01-30 13:07 ` Greg KH
2014-01-30 14:22   ` Avinash Kumar
2014-01-30 14:57     ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.