* [Buildroot] [Bug 3811] New: Added auto-mount for USB and SD Card (mdev) (for 2011.05)
@ 2011-06-01 13:28 bugzilla at busybox.net
2011-06-01 14:03 ` Patryk Benderz
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: bugzilla at busybox.net @ 2011-06-01 13:28 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=3811
Summary: Added auto-mount for USB and SD Card (mdev) (for
2011.05)
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: enhancement
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: tkazmierczak at eurofunk.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0
Works great for me :)
diff --git a/package/busybox/S10mdev b/package/busybox/S10mdev
index d2643d0..47c46f5 100644
--- a/package/busybox/S10mdev
+++ b/package/busybox/S10mdev
@@ -6,6 +6,7 @@
case "$1" in
start)
echo "Starting mdev..."
+ /bin/echo /sbin/mdev > /proc/sys/kernel/hotplug
/sbin/mdev -s
;;
stop)
diff --git a/package/busybox/automount.sh b/package/busybox/automount.sh
new file mode 100755
index 0000000..5ae2b97
--- /dev/null
+++ b/package/busybox/automount.sh
@@ -0,0 +1,34 @@
+#! /bin/sh
+
+if [ "$1" == "" ]; then
+ exit 1
+fi
+
+mounted=`mount | grep $1 | wc -l`
+
+# mounted, assume we umount
+if [ $mounted -ge 1 ]; then
+ if ! umount "/dev/$1"; then
+ exit 1
+ fi
+
+ if ! rmdir "/media/$1"; then
+ exit 1
+ fi
+# not mounted, lets mount under /media
+else
+ if ! mkdir -p "/media/$1"; then
+ exit 1
+ fi
+
+ if ! mount -o sync "/dev/$1" "/media/$1"; then
+ # failed to mount, clean up mountpoint
+ if ! rmdir "/media/$1"; then
+ exit 1
+ fi
+ exit 1
+ fi
+fi
+
+exit 0
+
diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
index 711d11b..bbe5c39 100644
--- a/package/busybox/busybox.mk
+++ b/package/busybox/busybox.mk
@@ -32,6 +32,8 @@ endif
ifeq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),y)
define BUSYBOX_INSTALL_MDEV_SCRIPT
install -m 0755 package/busybox/S10mdev $(TARGET_DIR)/etc/init.d
+ install -m 0755 package/busybox/mdev.conf $(TARGET_DIR)/etc
+ install -m 0755 package/busybox/automount.sh $(TARGET_DIR)/sbin
endef
define BUSYBOX_SET_MDEV
$(call KCONFIG_ENABLE_OPT,CONFIG_MDEV,$(BUSYBOX_BUILD_CONFIG))
diff --git a/package/busybox/mdev.conf b/package/busybox/mdev.conf
new file mode 100644
index 0000000..08d915c
--- /dev/null
+++ b/package/busybox/mdev.conf
@@ -0,0 +1,2 @@
+sd[a-z][0-9]* 0:0 0660 *(/sbin/automount.sh $MDEV)
+mmcblk[0-9]p[0-9] 0:0 0660 *(/sbin/automount.sh $MDEV)
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [Bug 3811] New: Added auto-mount for USB and SD Card (mdev) (for 2011.05)
2011-06-01 13:28 [Buildroot] [Bug 3811] New: Added auto-mount for USB and SD Card (mdev) (for 2011.05) bugzilla at busybox.net
@ 2011-06-01 14:03 ` Patryk Benderz
2011-06-02 4:10 ` Cam Hutchison
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patryk Benderz @ 2011-06-01 14:03 UTC (permalink / raw)
To: buildroot
Dnia 2011-06-01, ?ro o godzinie 13:28 +0000, bugzilla at busybox.net pisze:
> https://bugs.busybox.net/show_bug.cgi?id=3811
>
> Summary: Added auto-mount for USB and SD Card (mdev) (for
> 2011.05)
> Product: buildroot
> Version: unspecified
> Platform: PC
> OS/Version: Linux
> Status: NEW
> Severity: enhancement
> Priority: P5
> Component: Other
> AssignedTo: unassigned at buildroot.uclibc.org
> ReportedBy: tkazmierczak at eurofunk.com
> CC: buildroot at uclibc.org
> Estimated Hours: 0.0
>
>
> Works great for me :)
Great! Thats exactly what I need :) Will try to test it this month.
Thanks!
--
Patryk "LeadMan" Benderz
Linux Registered User #377521
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [Bug 3811] New: Added auto-mount for USB and SD Card (mdev) (for 2011.05)
2011-06-01 13:28 [Buildroot] [Bug 3811] New: Added auto-mount for USB and SD Card (mdev) (for 2011.05) bugzilla at busybox.net
2011-06-01 14:03 ` Patryk Benderz
@ 2011-06-02 4:10 ` Cam Hutchison
2014-02-08 20:53 ` [Buildroot] [Bug 3811] " bugzilla at busybox.net
2014-02-10 17:56 ` bugzilla at busybox.net
3 siblings, 0 replies; 5+ messages in thread
From: Cam Hutchison @ 2011-06-02 4:10 UTC (permalink / raw)
To: buildroot
Some comments on your automount.sh changes:
>+#! /bin/sh
No space after #!
>+mounted=`mount | grep $1 | wc -l`
mounted=$(grep -c "^/dev/$1 " /proc/mounts)
$() is clearer than ``.
Less processes is better than more.
Use a full pattern so you don't accidently match sda against /dev/sda1 or
other sub-matches (sda1 vs sda11).
>+# mounted, assume we umount
>+if [ $mounted -ge 1 ]; then
>+ if ! umount "/dev/$1"; then
>+ exit 1
>+ fi
If something is mounted more than once, you unmount it only once. So why
it it necessary to know how many times it is mounted?
if grep -qs "^/dev/$1 " /proc/mounts ; then
is simplier and more idiomatic. You can then get rid of mounted=...
above.
>+
>+ if ! rmdir "/media/$1"; then
>+ exit 1
>+ fi
>+# not mounted, lets mount under /media
>+else
>+ if ! mkdir -p "/media/$1"; then
>+ exit 1
>+ fi
Why remove the directory, only to re-create it again?
>+
>+ if ! mount -o sync "/dev/$1" "/media/$1"; then
>+ # failed to mount, clean up mountpoint
>+ if ! rmdir "/media/$1"; then
>+ exit 1
>+ fi
>+ exit 1
Why test the result of rmdir if you are just going to exit 1 anyway?
rmdir "/media/$1"
exit 1
>+ fi
>+fi
>+
>+exit 0
>+
>diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
>index 711d11b..bbe5c39 100644
>--- a/package/busybox/busybox.mk
>+++ b/package/busybox/busybox.mk
>@@ -32,6 +32,8 @@ endif
> ifeq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),y)
> define BUSYBOX_INSTALL_MDEV_SCRIPT
> install -m 0755 package/busybox/S10mdev $(TARGET_DIR)/etc/init.d
>+ install -m 0755 package/busybox/mdev.conf $(TARGET_DIR)/etc
>+ install -m 0755 package/busybox/automount.sh $(TARGET_DIR)/sbin
Since automount.sh is a helper program for mdev, not a general-purpose
program, it should probably live in /lib/mdev and not /sbin.
> endef
> define BUSYBOX_SET_MDEV
> $(call KCONFIG_ENABLE_OPT,CONFIG_MDEV,$(BUSYBOX_BUILD_CONFIG))
>diff --git a/package/busybox/mdev.conf b/package/busybox/mdev.conf
>new file mode 100644
>index 0000000..08d915c
>--- /dev/null
>+++ b/package/busybox/mdev.conf
>@@ -0,0 +1,2 @@
>+sd[a-z][0-9]* 0:0 0660 *(/sbin/automount.sh $MDEV)
>+mmcblk[0-9]p[0-9] 0:0 0660 *(/sbin/automount.sh $MDEV)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [Bug 3811] Added auto-mount for USB and SD Card (mdev) (for 2011.05)
2011-06-01 13:28 [Buildroot] [Bug 3811] New: Added auto-mount for USB and SD Card (mdev) (for 2011.05) bugzilla at busybox.net
2011-06-01 14:03 ` Patryk Benderz
2011-06-02 4:10 ` Cam Hutchison
@ 2014-02-08 20:53 ` bugzilla at busybox.net
2014-02-10 17:56 ` bugzilla at busybox.net
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla at busybox.net @ 2014-02-08 20:53 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=3811
--- Comment #1 from Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> 2014-02-08 20:53:25 UTC ---
In my opinion, this script/proposal is very project-specific and does not need
to be part of mainline buildroot. What is the opinion of other buildroot
developers?
If you agree, I would propose to close this bug as Resolved/Wontfix.
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [Bug 3811] Added auto-mount for USB and SD Card (mdev) (for 2011.05)
2011-06-01 13:28 [Buildroot] [Bug 3811] New: Added auto-mount for USB and SD Card (mdev) (for 2011.05) bugzilla at busybox.net
` (2 preceding siblings ...)
2014-02-08 20:53 ` [Buildroot] [Bug 3811] " bugzilla at busybox.net
@ 2014-02-10 17:56 ` bugzilla at busybox.net
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla at busybox.net @ 2014-02-10 17:56 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=3811
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |WONTFIX
--- Comment #2 from Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> 2014-02-10 17:56:42 UTC ---
Other buildroot developers agree that this patch is very project specific and
should not be applied to mainline buildroot.
Please consider using a post-build script or rootfs overlay to achieve the same
effect. See the buildroot manual for more information:
http://buildroot.uclibc.org/downloads/manual/manual.html#_customization
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-10 17:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-01 13:28 [Buildroot] [Bug 3811] New: Added auto-mount for USB and SD Card (mdev) (for 2011.05) bugzilla at busybox.net
2011-06-01 14:03 ` Patryk Benderz
2011-06-02 4:10 ` Cam Hutchison
2014-02-08 20:53 ` [Buildroot] [Bug 3811] " bugzilla at busybox.net
2014-02-10 17:56 ` bugzilla at busybox.net
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.