All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Correct max priority in renice man page
@ 2014-02-08 18:22 Phillip Susi
  2014-02-10 18:08 ` Karel Zak
  0 siblings, 1 reply; 2+ messages in thread
From: Phillip Susi @ 2014-02-08 18:22 UTC (permalink / raw)
  To: util-linux

The man page stated that the PRIO_MAX is 20.  While this
is correct, the header definition is wrong and the max
value is actually 19.

Signed-off-by: Phillip Susi <psusi@ubuntu.com>
---
 sys-utils/renice.1 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys-utils/renice.1 b/sys-utils/renice.1
index 538687e..9cb50b8 100644
--- a/sys-utils/renice.1
+++ b/sys-utils/renice.1
@@ -86,14 +86,14 @@ PIDs 987 and 32, plus all processes owned by the users daemon and root:
 Users other than the superuser may only alter the priority of processes they
 own, and can only monotonically increase their ``nice value'' (for security
 reasons) within the range 0 to
-.BR PRIO_MAX \ (20),
+.BR PRIO_MAX \ (19),
 unless a nice resource limit is set (Linux 2.6.12 and higher).  The
 superuser may alter the priority of any process and set the priority to any
 value in the range
 .BR PRIO_MIN \ (\-20)
 to
 .BR PRIO_MAX .
-Useful priorities are: 20 (the affected processes will run only when nothing
+Useful priorities are: 19 (the affected processes will run only when nothing
 else in the system wants to), 0 (the ``base'' scheduling priority), anything
 negative (to make things go very fast).
 .SH FILES
-- 
1.8.3.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Correct max priority in renice man page
  2014-02-08 18:22 [PATCH] Correct max priority in renice man page Phillip Susi
@ 2014-02-10 18:08 ` Karel Zak
  0 siblings, 0 replies; 2+ messages in thread
From: Karel Zak @ 2014-02-10 18:08 UTC (permalink / raw)
  To: Phillip Susi; +Cc: util-linux

On Sat, Feb 08, 2014 at 01:22:10PM -0500, Phillip Susi wrote:
> The man page stated that the PRIO_MAX is 20.  While this
> is correct, the header definition is wrong and the max
> value is actually 19.

 I have removed all notes about PRIO_MAX from the man page. The kernel
 syscalls use hardcoded limits rather than anything from header files.

 SYSCALL_DEFINE3(setpriority, int, which, int, who, int, niceval)
    ...
	if (niceval < -20)
		niceval = -20;
	if (niceval > 19)
		niceval = 19;

 and almost the same is SYSCALL_DEFINE1(nice...

 :-)

>  sys-utils/renice.1 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

 Applied, thanks.


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-02-10 18:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-08 18:22 [PATCH] Correct max priority in renice man page Phillip Susi
2014-02-10 18:08 ` Karel Zak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.