* [PATCH] ipv4: ipconfig.c: add parentheses in an if statement
@ 2014-02-10 15:46 Francois-Xavier Le Bail
2014-02-13 0:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Francois-Xavier Le Bail @ 2014-02-10 15:46 UTC (permalink / raw)
To: NETDEV; +Cc: David Miller
Even if the 'time_before' macro expand with parentheses, the look is bad.
Signed-off-by: Francois-Xavier Le Bail <fx.lebail@yahoo.com>
---
net/ipv4/ipconfig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index efa1138..b3e86ea 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -273,7 +273,7 @@ static int __init ic_open_devs(void)
msleep(1);
- if time_before(jiffies, next_msg)
+ if (time_before(jiffies, next_msg))
continue;
elapsed = jiffies_to_msecs(jiffies - start);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv4: ipconfig.c: add parentheses in an if statement
2014-02-10 15:46 [PATCH] ipv4: ipconfig.c: add parentheses in an if statement Francois-Xavier Le Bail
@ 2014-02-13 0:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-02-13 0:29 UTC (permalink / raw)
To: fx.lebail; +Cc: netdev
From: Francois-Xavier Le Bail <fx.lebail@yahoo.com>
Date: Mon, 10 Feb 2014 16:46:54 +0100
> Even if the 'time_before' macro expand with parentheses, the look is bad.
>
> Signed-off-by: Francois-Xavier Le Bail <fx.lebail@yahoo.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-13 0:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-10 15:46 [PATCH] ipv4: ipconfig.c: add parentheses in an if statement Francois-Xavier Le Bail
2014-02-13 0:29 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.