drm/i2c: tda998x: Fix memory leak in tda998x_encoder_init error path.

drm/i2c: tda998x: Fix memory leak in tda998x_encoder_init error path.

[Dave Jones]

Commit 6ae668cc19e8b18df28cd67b3448d9abd79284a4 introduced a memory leak
in the error path of tda998x_encoder_init

Picked up by the nightly Coverity scan. CID 1174076
    
Signed-off-by: Dave Jones <davej@fedoraproject.org>

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index fa18cf374470..faa77f543a07 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1151,8 +1151,10 @@ tda998x_encoder_init(struct i2c_client *client,
 
 	priv->current_page = 0xff;
 	priv->cec = i2c_new_dummy(client->adapter, 0x34);
-	if (!priv->cec)
+	if (!priv->cec) {
+		kfree(priv);
 		return -ENODEV;
+	}
 	priv->dpms = DRM_MODE_DPMS_OFF;
 
 	encoder_slave->slave_priv = priv;

Re: drm/i2c: tda998x: Fix memory leak in tda998x_encoder_init error path.

[Russell King - ARM Linux]

On Wed, Feb 12, 2014 at 10:47:51PM -0500, Dave Jones wrote:
> Commit 6ae668cc19e8b18df28cd67b3448d9abd79284a4 introduced a memory leak
> in the error path of tda998x_encoder_init
> 
> Picked up by the nightly Coverity scan. CID 1174076
>     
> Signed-off-by: Dave Jones <davej@fedoraproject.org>

Thanks Dave, patch applied, and will send to airlied soon.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".