From: Wolfram Sang <wsa@the-dreams.de> To: Gregory CLEMENT <gregory.clement@free-electrons.com> Cc: linux-i2c@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, Ezequiel Garcia <ezequiel.garcia@free-electrons.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, linux-arm-kernel@lists.infradead.org, Kevin Hilman <khilman@linaro.org>, stable@vger.kernel.org Subject: Re: [PATCH] i2c: mv64xxx: Fix locked bus when offload is selected but not used on a message Date: Thu, 13 Feb 2014 10:41:17 +0100 [thread overview] Message-ID: <20140213094117.GA3934@katana> (raw) In-Reply-To: <1391770588-1344-1-git-send-email-gregory.clement@free-electrons.com> [-- Attachment #1: Type: text/plain, Size: 1041 bytes --] > --- a/drivers/i2c/busses/i2c-mv64xxx.c > +++ b/drivers/i2c/busses/i2c-mv64xxx.c > @@ -461,8 +461,15 @@ mv64xxx_i2c_do_action(struct mv64xxx_i2c_data *drv_data) > case MV64XXX_I2C_ACTION_OFFLOAD_SEND_START: > if (!mv64xxx_i2c_offload_msg(drv_data)) > break; > - else > + else { Here you break the coding style... > drv_data->action = MV64XXX_I2C_ACTION_SEND_START; > + /* > + * Switch to the standard path, so we finally need to > + * prepare the io that have not been done in > + * mv64xxx_i2c_execute_msg > + */ > + mv64xxx_i2c_prepare_for_io(drv_data, drv_data->msgs); > + } ... but more importantly, NACK. The code is already hard to follow which is the cause for this bug. This snipplet makes the code even harder to read, so it needs some simplification IMO. I'll fire up a counterpatch in a minute to explain what I mean. > /* FALLTHRU */ > case MV64XXX_I2C_ACTION_SEND_START: > writel(drv_data->cntl_bits | MV64XXX_I2C_REG_CONTROL_START, > -- > 1.8.1.2 > [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] i2c: mv64xxx: Fix locked bus when offload is selected but not used on a message Date: Thu, 13 Feb 2014 10:41:17 +0100 [thread overview] Message-ID: <20140213094117.GA3934@katana> (raw) In-Reply-To: <1391770588-1344-1-git-send-email-gregory.clement@free-electrons.com> > --- a/drivers/i2c/busses/i2c-mv64xxx.c > +++ b/drivers/i2c/busses/i2c-mv64xxx.c > @@ -461,8 +461,15 @@ mv64xxx_i2c_do_action(struct mv64xxx_i2c_data *drv_data) > case MV64XXX_I2C_ACTION_OFFLOAD_SEND_START: > if (!mv64xxx_i2c_offload_msg(drv_data)) > break; > - else > + else { Here you break the coding style... > drv_data->action = MV64XXX_I2C_ACTION_SEND_START; > + /* > + * Switch to the standard path, so we finally need to > + * prepare the io that have not been done in > + * mv64xxx_i2c_execute_msg > + */ > + mv64xxx_i2c_prepare_for_io(drv_data, drv_data->msgs); > + } ... but more importantly, NACK. The code is already hard to follow which is the cause for this bug. This snipplet makes the code even harder to read, so it needs some simplification IMO. I'll fire up a counterpatch in a minute to explain what I mean. > /* FALLTHRU */ > case MV64XXX_I2C_ACTION_SEND_START: > writel(drv_data->cntl_bits | MV64XXX_I2C_REG_CONTROL_START, > -- > 1.8.1.2 > -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140213/cee40674/attachment.sig>
next prev parent reply other threads:[~2014-02-13 9:41 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-07 10:55 [PATCH] i2c: mv64xxx: Fix locked bus when offload is selected but not used on a message Gregory CLEMENT 2014-02-07 10:55 ` Gregory CLEMENT 2014-02-07 15:09 ` Jason Cooper 2014-02-07 15:09 ` Jason Cooper 2014-02-07 15:18 ` Gregory CLEMENT 2014-02-07 15:18 ` Gregory CLEMENT [not found] ` <20140207150958.GY8533-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> 2014-02-07 18:09 ` Kevin Hilman 2014-02-07 18:09 ` Kevin Hilman 2014-02-07 18:13 ` Jason Cooper 2014-02-07 18:13 ` Jason Cooper [not found] ` <1391770588-1344-1-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2014-02-08 17:01 ` Jason Cooper 2014-02-08 17:01 ` Jason Cooper 2014-02-13 9:41 ` Wolfram Sang [this message] 2014-02-13 9:41 ` Wolfram Sang 2014-02-13 14:23 ` Gregory CLEMENT 2014-02-13 14:23 ` Gregory CLEMENT 2014-02-13 20:36 ` [PATCH 0/5] mv64xxx updates Wolfram Sang 2014-02-13 20:36 ` Wolfram Sang [not found] ` <1392323793-4125-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2014-02-13 20:36 ` [PATCH 1/5] i2c: mv64xxx: put offload check into offload prepare function Wolfram Sang 2014-02-13 20:36 ` Wolfram Sang [not found] ` <1392323793-4125-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2014-02-14 11:38 ` Gregory CLEMENT 2014-02-14 11:38 ` Gregory CLEMENT 2014-02-13 20:36 ` [PATCH 2/5] i2c: mv64xxx: refactor message start to ensure proper initialization Wolfram Sang 2014-02-13 20:36 ` Wolfram Sang [not found] ` <1392323793-4125-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2014-02-14 11:39 ` Gregory CLEMENT 2014-02-14 11:39 ` Gregory CLEMENT [not found] ` <52FE0056.2030706-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2014-02-15 14:44 ` Wolfram Sang 2014-02-15 14:44 ` Wolfram Sang 2014-02-13 20:36 ` [PATCH 3/5] i2c: mv64xxx: refactor send_start Wolfram Sang 2014-02-13 20:36 ` Wolfram Sang [not found] ` <1392323793-4125-4-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2014-02-14 11:42 ` Gregory CLEMENT 2014-02-14 11:42 ` Gregory CLEMENT 2014-02-13 20:36 ` [PATCH 4/5] i2c: mv64xxx: directly call send_start when initializing transfer Wolfram Sang 2014-02-13 20:36 ` Wolfram Sang 2014-02-13 20:36 ` [PATCH 5/5] i2c: mv64xxx: refactor initialization for new msgs Wolfram Sang 2014-02-13 20:36 ` Wolfram Sang 2014-02-13 20:41 ` [PATCH 0/5] mv64xxx updates Gregory CLEMENT 2014-02-13 20:41 ` Gregory CLEMENT [not found] ` <52FD2E0C.10609-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2014-03-10 16:25 ` Wolfram Sang 2014-03-10 16:25 ` Wolfram Sang 2014-02-13 20:51 ` Thomas Petazzoni 2014-02-13 20:51 ` Thomas Petazzoni 2014-02-18 11:29 ` Maxime Ripard 2014-02-18 11:29 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140213094117.GA3934@katana \ --to=wsa@the-dreams.de \ --cc=andrew@lunn.ch \ --cc=ezequiel.garcia@free-electrons.com \ --cc=gregory.clement@free-electrons.com \ --cc=jason@lakedaemon.net \ --cc=khilman@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=stable@vger.kernel.org \ --cc=thomas.petazzoni@free-electrons.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.