From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Steve Capper <steve.capper@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] ARM: mm: report both sections from PMD
Date: Fri, 14 Feb 2014 19:23:22 +0000 [thread overview]
Message-ID: <20140214192322.GJ30257@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAGXu5jKYq=0Ud-A6bdD2zMe=+r0S7nja8Rg+OxeT+JHzdpwTKg@mail.gmail.com>
On Fri, Feb 14, 2014 at 11:13:53AM -0800, Kees Cook wrote:
> On Fri, Feb 14, 2014 at 2:17 AM, Catalin Marinas
> <catalin.marinas@arm.com> wrote:
> > On Thu, Feb 13, 2014 at 07:52:30PM +0000, Kees Cook wrote:
> >> On 2-level page table systems, the PMD has 2 section entries. Report
> >> these, otherwise ARM_PTDUMP will miss reporting permission changes on
> >> odd section boundaries.
> >>
> >> Signed-off-by: Kees Cook <keescook@chromium.org>
> >
> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>
> On Fri, Feb 14, 2014 at 9:05 AM, Steve Capper <steve.capper@linaro.org> wrote:
> > Tested-by: Steve Capper <steve.capper@linaro.org>
>
> Thanks to both of you! If you have a moment can you check this other
> patch which has additional fixes for the dump code?
>
> https://lkml.org/lkml/2014/2/12/662
It's not that simple, because APX in section descriptors doesn't exist
on pre-v6 ARMs. This needs to be conditional upon the CPU arch.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: mm: report both sections from PMD
Date: Fri, 14 Feb 2014 19:23:22 +0000 [thread overview]
Message-ID: <20140214192322.GJ30257@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAGXu5jKYq=0Ud-A6bdD2zMe=+r0S7nja8Rg+OxeT+JHzdpwTKg@mail.gmail.com>
On Fri, Feb 14, 2014 at 11:13:53AM -0800, Kees Cook wrote:
> On Fri, Feb 14, 2014 at 2:17 AM, Catalin Marinas
> <catalin.marinas@arm.com> wrote:
> > On Thu, Feb 13, 2014 at 07:52:30PM +0000, Kees Cook wrote:
> >> On 2-level page table systems, the PMD has 2 section entries. Report
> >> these, otherwise ARM_PTDUMP will miss reporting permission changes on
> >> odd section boundaries.
> >>
> >> Signed-off-by: Kees Cook <keescook@chromium.org>
> >
> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>
> On Fri, Feb 14, 2014 at 9:05 AM, Steve Capper <steve.capper@linaro.org> wrote:
> > Tested-by: Steve Capper <steve.capper@linaro.org>
>
> Thanks to both of you! If you have a moment can you check this other
> patch which has additional fixes for the dump code?
>
> https://lkml.org/lkml/2014/2/12/662
It's not that simple, because APX in section descriptors doesn't exist
on pre-v6 ARMs. This needs to be conditional upon the CPU arch.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
next prev parent reply other threads:[~2014-02-14 19:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 19:52 [PATCH v3] ARM: mm: report both sections from PMD Kees Cook
2014-02-13 19:52 ` Kees Cook
2014-02-14 10:17 ` Catalin Marinas
2014-02-14 10:17 ` Catalin Marinas
2014-02-14 19:13 ` Kees Cook
2014-02-14 19:13 ` Kees Cook
2014-02-14 19:23 ` Russell King - ARM Linux [this message]
2014-02-14 19:23 ` Russell King - ARM Linux
2014-02-14 19:31 ` Kees Cook
2014-02-14 19:31 ` Kees Cook
2014-02-14 17:05 ` Steve Capper
2014-02-14 17:05 ` Steve Capper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214192322.GJ30257@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=catalin.marinas@arm.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steve.capper@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.