All of lore.kernel.org
 help / color / mirror / Atom feed
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers
Date: Mon, 17 Feb 2014 15:37:48 +0000	[thread overview]
Message-ID: <20140217153748.513230fb@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <52FDD470.7000607@hitachi.com>

> #define TIOCSFIFORTRIG    _IOW('T', 0x41, unsigned char)
> 
> > Also, why pass a pointer to a variable, and not just the value itself?
> 
> Ah, it's no big reason.
> It will pass just the value itself in V2.

We don't need ioctls here - we have a sysfs interface we can expand to do
this. We also need proper locking. This isn't a trivial change but its
perfectly doable given a real world use case.

> According to a manual of setserial command, we could set RX interrupt
> trigger only for the Hayes ESP serial driver. However, current kernel
> does not support Hayes ESP serial[1]. I couldn't find this feature for
> current 8250/16X50 drivers.

It is long gone and was a set of ugly device specific hacks.

Alan

      reply	other threads:[~2014-02-17 15:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06  2:16 [PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers Yoshihiro YUNOMAE
2014-02-13 18:10 ` Greg Kroah-Hartman
2014-02-14  8:31   ` Yoshihiro YUNOMAE
2014-02-17 15:37     ` One Thousand Gnomes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140217153748.513230fb@alan.etchedpixels.co.uk \
    --to=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=hidehiro.kawai.ez@hitachi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=yoshihiro.yunomae.ez@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.