* [radeonsi] si_populate_sq_ramping_values
@ 2014-02-17 22:08 Sylvain BERTRAND
2014-02-18 15:17 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Sylvain BERTRAND @ 2014-02-17 22:08 UTC (permalink / raw)
To: dri-devel
Hi,
In si_dpm.c, si_populate_sq_ramping_values function,
It should be SISLANDS_DPM2_SQ_RAMP_LTI_RATIO instead of
NISLANDS_DPM2_SQ_RAMP_LTI_RATIO.
----
Moreover should it be:
if (SISLANDS_DPM2_SQ_RAMP_LTI_RATIO > (LTI_RATIO_MASK >>
LTI_RATIO_SHIFT))
instead of:
if (NISLANDS_DPM2_SQ_RAMP_LTI_RATIO <= (LTI_RATIO_MASK >>
LTI_RATIO_SHIFT))
----
The previous does disable "sq ramping" for good on all SI,
expected?
regards,
--
Sylvain
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [radeonsi] si_populate_sq_ramping_values
2014-02-17 22:08 [radeonsi] si_populate_sq_ramping_values Sylvain BERTRAND
@ 2014-02-18 15:17 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2014-02-18 15:17 UTC (permalink / raw)
To: Sylvain BERTRAND; +Cc: Maling list - DRI developers
On Mon, Feb 17, 2014 at 5:08 PM, Sylvain BERTRAND <sylware@legeek.net> wrote:
> Hi,
>
> In si_dpm.c, si_populate_sq_ramping_values function,
>
> It should be SISLANDS_DPM2_SQ_RAMP_LTI_RATIO instead of
> NISLANDS_DPM2_SQ_RAMP_LTI_RATIO.
>
This is already changed.
> ----
>
> Moreover should it be:
> if (SISLANDS_DPM2_SQ_RAMP_LTI_RATIO > (LTI_RATIO_MASK >>
> LTI_RATIO_SHIFT))
>
> instead of:
> if (NISLANDS_DPM2_SQ_RAMP_LTI_RATIO <= (LTI_RATIO_MASK >>
> LTI_RATIO_SHIFT))
>
> ----
>
> The previous does disable "sq ramping" for good on all SI,
> expected?
>
You are correct. fixed.
Thanks!
Alex
> regards,
>
> --
> Sylvain
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-18 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-17 22:08 [radeonsi] si_populate_sq_ramping_values Sylvain BERTRAND
2014-02-18 15:17 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.