* [nft next-3.14 PATCH] netlink: delete unused function calls
@ 2014-02-17 10:10 Arturo Borrero Gonzalez
2014-02-17 23:20 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Arturo Borrero Gonzalez @ 2014-02-17 10:10 UTC (permalink / raw)
To: netfilter-devel
These functions calls, and the related `struct nft_table *nlt' are unused.
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
src/netlink.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/netlink.c b/src/netlink.c
index 6e797dc..ea02972 100644
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -703,7 +703,6 @@ int netlink_list_tables(struct netlink_ctx *ctx, const struct handle *h,
const struct location *loc)
{
struct nft_table_list *table_cache;
- struct nft_table *nlt;
table_cache = mnl_nft_table_dump(nf_sock, h->family);
if (table_cache == NULL)
@@ -711,9 +710,7 @@ int netlink_list_tables(struct netlink_ctx *ctx, const struct handle *h,
"Could not receive tables from kernel: %s",
strerror(errno));
- nlt = alloc_nft_table(h);
nft_table_list_foreach(table_cache, list_table_cb, ctx);
- nft_table_free(nlt);
nft_table_list_free(table_cache);
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [nft next-3.14 PATCH] netlink: delete unused function calls
2014-02-17 10:10 [nft next-3.14 PATCH] netlink: delete unused function calls Arturo Borrero Gonzalez
@ 2014-02-17 23:20 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-02-17 23:20 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: netfilter-devel
On Mon, Feb 17, 2014 at 11:10:57AM +0100, Arturo Borrero Gonzalez wrote:
> These functions calls, and the related `struct nft_table *nlt' are unused.
Applied, thanks Arturo.
Changed the title and description to insist on the unused variable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-17 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-17 10:10 [nft next-3.14 PATCH] netlink: delete unused function calls Arturo Borrero Gonzalez
2014-02-17 23:20 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.