From: Stephen Rothwell <sfr@canb.auug.org.au> To: David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>, "John W. Linville" <linville@tuxdriver.com> Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Amitkumar Karwar <akarwar@marvell.com>, Aaron Durbin <adurbin@chromium.org> Subject: linux-next: manual merge of the net-next tree with the wireless tree Date: Fri, 21 Feb 2014 13:34:41 +1100 [thread overview] Message-ID: <20140221133441.77e6ef11dfad31bb90a12d8a@canb.auug.org.au> (raw) [-- Attachment #1: Type: text/plain, Size: 1291 bytes --] Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/wireless/mwifiex/pcie.c between commit bb8e6a1ee881 ("mwifiex: add NULL check for PCIe Rx skb") from the tree and commit dbccc92b5d54 ("mwifiex: balance dma map/unmap sizes") from the net-next tree. I fixed it up (see below) and can carry the fix as necessary (no action is required). -- Cheers, Stephen Rothwell sfr@canb.auug.org.au diff --cc drivers/net/wireless/mwifiex/pcie.c index 7fe7b53fb17a,d11d4acf0890..000000000000 --- a/drivers/net/wireless/mwifiex/pcie.c +++ b/drivers/net/wireless/mwifiex/pcie.c @@@ -1211,15 -1217,7 +1217,13 @@@ static int mwifiex_pcie_process_recv_da rd_index = card->rxbd_rdptr & reg->rx_mask; skb_data = card->rx_buf_list[rd_index]; + /* If skb allocation was failed earlier for Rx packet, + * rx_buf_list[rd_index] would have been left with a NULL. + */ + if (!skb_data) + return -ENOMEM; + - MWIFIEX_SKB_PACB(skb_data, &buf_pa); - pci_unmap_single(card->dev, buf_pa, MWIFIEX_RX_DATA_BUF_SIZE, - PCI_DMA_FROMDEVICE); + mwifiex_unmap_pci_memory(adapter, skb_data, PCI_DMA_FROMDEVICE); card->rx_buf_list[rd_index] = NULL; /* Get data length from interface header - [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au> To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org, "John W. Linville" <linville@tuxdriver.com> Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Amitkumar Karwar <akarwar@marvell.com>, Aaron Durbin <adurbin@chromium.org> Subject: linux-next: manual merge of the net-next tree with the wireless tree Date: Fri, 21 Feb 2014 13:34:41 +1100 [thread overview] Message-ID: <20140221133441.77e6ef11dfad31bb90a12d8a@canb.auug.org.au> (raw) [-- Attachment #1: Type: text/plain, Size: 1291 bytes --] Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/wireless/mwifiex/pcie.c between commit bb8e6a1ee881 ("mwifiex: add NULL check for PCIe Rx skb") from the tree and commit dbccc92b5d54 ("mwifiex: balance dma map/unmap sizes") from the net-next tree. I fixed it up (see below) and can carry the fix as necessary (no action is required). -- Cheers, Stephen Rothwell sfr@canb.auug.org.au diff --cc drivers/net/wireless/mwifiex/pcie.c index 7fe7b53fb17a,d11d4acf0890..000000000000 --- a/drivers/net/wireless/mwifiex/pcie.c +++ b/drivers/net/wireless/mwifiex/pcie.c @@@ -1211,15 -1217,7 +1217,13 @@@ static int mwifiex_pcie_process_recv_da rd_index = card->rxbd_rdptr & reg->rx_mask; skb_data = card->rx_buf_list[rd_index]; + /* If skb allocation was failed earlier for Rx packet, + * rx_buf_list[rd_index] would have been left with a NULL. + */ + if (!skb_data) + return -ENOMEM; + - MWIFIEX_SKB_PACB(skb_data, &buf_pa); - pci_unmap_single(card->dev, buf_pa, MWIFIEX_RX_DATA_BUF_SIZE, - PCI_DMA_FROMDEVICE); + mwifiex_unmap_pci_memory(adapter, skb_data, PCI_DMA_FROMDEVICE); card->rx_buf_list[rd_index] = NULL; /* Get data length from interface header - [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2014-02-21 2:34 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-21 2:34 Stephen Rothwell [this message] 2014-02-21 2:34 ` linux-next: manual merge of the net-next tree with the wireless tree Stephen Rothwell -- strict thread matches above, loose matches on Subject: below -- 2023-10-24 0:24 Stephen Rothwell 2023-10-12 0:37 Stephen Rothwell 2023-10-12 8:10 ` Johannes Berg 2023-10-19 21:40 ` Jakub Kicinski 2023-10-20 5:49 ` Johannes Berg 2014-07-24 2:47 Stephen Rothwell 2014-07-24 2:47 ` Stephen Rothwell 2014-07-23 2:00 Stephen Rothwell 2014-07-23 2:00 ` Stephen Rothwell 2014-05-23 3:45 Stephen Rothwell 2014-05-23 3:45 ` Stephen Rothwell 2014-02-26 3:21 Stephen Rothwell 2014-02-26 3:21 ` Stephen Rothwell 2013-09-27 3:03 Stephen Rothwell 2013-09-27 3:03 ` Stephen Rothwell 2013-08-27 4:10 Stephen Rothwell 2013-08-27 4:10 ` Stephen Rothwell 2013-04-04 0:44 Stephen Rothwell 2013-04-04 0:44 ` Stephen Rothwell 2013-05-02 3:19 ` Stephen Rothwell 2013-05-02 3:19 ` Stephen Rothwell 2013-04-02 2:00 Stephen Rothwell 2013-04-02 2:00 ` Stephen Rothwell 2013-04-02 9:30 ` Samuel Ortiz 2013-03-26 0:51 Stephen Rothwell 2013-03-26 0:51 ` Stephen Rothwell 2013-03-26 0:48 Stephen Rothwell 2013-03-26 0:48 ` Stephen Rothwell 2012-07-03 1:44 Stephen Rothwell 2012-07-03 1:44 ` Stephen Rothwell 2012-07-03 2:33 ` John W. Linville 2012-06-14 3:12 Stephen Rothwell 2012-06-14 3:12 ` Stephen Rothwell 2012-06-14 4:50 ` Mohammed Shafi Shajakhan 2012-06-14 4:50 ` Mohammed Shafi Shajakhan 2012-06-14 12:59 ` John W. Linville 2012-05-04 3:21 Stephen Rothwell 2012-05-04 3:21 ` Stephen Rothwell 2012-05-04 4:35 ` Guy, Wey-Yi 2012-02-16 1:40 Stephen Rothwell 2012-02-16 1:40 ` Stephen Rothwell 2012-02-16 1:37 Stephen Rothwell 2012-02-16 1:37 ` Stephen Rothwell 2011-12-20 2:02 Stephen Rothwell 2011-12-20 2:02 ` Stephen Rothwell 2011-12-15 2:53 Stephen Rothwell 2011-12-15 2:53 ` Stephen Rothwell 2011-12-15 3:16 ` Stephen Rothwell 2011-12-15 3:16 ` Stephen Rothwell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140221133441.77e6ef11dfad31bb90a12d8a@canb.auug.org.au \ --to=sfr@canb.auug.org.au \ --cc=adurbin@chromium.org \ --cc=akarwar@marvell.com \ --cc=davem@davemloft.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ --cc=linville@tuxdriver.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.