From: Jon Mason <jon.mason@intel.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 1/4] ntb: Fix leakage of ntb_device::msix_entries[] array
Date: Fri, 21 Feb 2014 16:33:25 -0700 [thread overview]
Message-ID: <20140221233325.GB3112@jonmason-lab> (raw)
In-Reply-To: <7f4150adb1b01e79555af6a9e13f1c0e0df6fdac.1392996332.git.agordeev@redhat.com>
On Fri, Feb 21, 2014 at 04:49:29PM +0100, Alexander Gordeev wrote:
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Jon Mason <jon.mason@intel.com>
> Cc: linux-pci@vger.kernel.org
Good catch. Applied.
> ---
> drivers/ntb/ntb_hw.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c
> index 170e8e6..487169dd 100644
> --- a/drivers/ntb/ntb_hw.c
> +++ b/drivers/ntb/ntb_hw.c
> @@ -1281,6 +1281,7 @@ static void ntb_free_interrupts(struct ntb_device *ndev)
> free_irq(msix->vector, &ndev->db_cb[i]);
> }
> pci_disable_msix(pdev);
> + kfree(ndev->msix_entries);
> } else {
> free_irq(pdev->irq, ndev);
>
> --
> 1.7.7.6
>
next prev parent reply other threads:[~2014-02-21 23:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 15:49 [PATCH v2 0/4] ntb: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-21 15:49 ` [PATCH v2 1/4] ntb: Fix leakage of ntb_device::msix_entries[] array Alexander Gordeev
2014-02-21 23:33 ` Jon Mason [this message]
2014-02-28 11:35 ` Alexander Gordeev
2014-02-21 15:49 ` [PATCH v2 2/4] ntb: Use pci_msix_vec_count() to obtain number of MSI-Xs Alexander Gordeev
2014-03-04 0:12 ` Jon Mason
2014-02-21 15:49 ` [PATCH v2 3/4] ntb: Split ntb_setup_msix() into separate BWD/SNB routines Alexander Gordeev
2014-02-22 19:55 ` Alexander Gordeev
2014-03-04 0:12 ` Jon Mason
2014-03-04 16:41 ` Alexander Gordeev
2014-03-10 21:18 ` Jon Mason
2014-03-11 16:00 ` Alexander Gordeev
2014-03-11 17:14 ` Jon Mason
2014-02-21 15:49 ` [PATCH v2 4/4] ntb: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-03-11 16:00 ` Alexander Gordeev
2014-03-11 17:15 ` Jon Mason
2014-02-21 16:09 ` [PATCH v2 0/4] " Alexander Gordeev
2014-02-22 19:56 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221233325.GB3112@jonmason-lab \
--to=jon.mason@intel.com \
--cc=agordeev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.