All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Alexander Gordeev <agordeev@redhat.com>,
	Jon Mason <jon.mason@intel.com>,
	linux-pci@vger.kernel.org
Subject: [PATCH v2 2/4] ntb: Use pci_msix_vec_count() to obtain number of MSI-Xs
Date: Fri, 21 Feb 2014 16:49:30 +0100	[thread overview]
Message-ID: <342d032b652517e2084ba97962ed017a25bf10bd.1392996332.git.agordeev@redhat.com> (raw)
In-Reply-To: <cover.1392996332.git.agordeev@redhat.com>

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Jon Mason <jon.mason@intel.com>
Cc: linux-pci@vger.kernel.org
---
 drivers/ntb/ntb_hw.c |   15 ++++-----------
 drivers/ntb/ntb_hw.h |    2 --
 2 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c
index 487169dd..53468f4 100644
--- a/drivers/ntb/ntb_hw.c
+++ b/drivers/ntb/ntb_hw.c
@@ -1085,19 +1085,12 @@ static int ntb_setup_msix(struct ntb_device *ndev)
 	struct msix_entry *msix;
 	int msix_entries;
 	int rc, i;
-	u16 val;
 
-	if (!pdev->msix_cap) {
-		rc = -EIO;
-		goto err;
-	}
-
-	rc = pci_read_config_word(pdev, pdev->msix_cap + PCI_MSIX_FLAGS, &val);
-	if (rc)
+	msix_entries = pci_msix_vec_count(pdev);
+	if (msix_entries < 0) {
+		rc = msix_entries;
 		goto err;
-
-	msix_entries = msix_table_size(val);
-	if (msix_entries > ndev->limits.msix_cnt) {
+	} else if (msix_entries > ndev->limits.msix_cnt) {
 		rc = -EINVAL;
 		goto err;
 	}
diff --git a/drivers/ntb/ntb_hw.h b/drivers/ntb/ntb_hw.h
index bbdb7ed..d307107 100644
--- a/drivers/ntb/ntb_hw.h
+++ b/drivers/ntb/ntb_hw.h
@@ -60,8 +60,6 @@
 #define PCI_DEVICE_ID_INTEL_NTB_SS_HSX		0x2F0F
 #define PCI_DEVICE_ID_INTEL_NTB_B2B_BWD		0x0C4E
 
-#define msix_table_size(control)	((control & PCI_MSIX_FLAGS_QSIZE)+1)
-
 #ifndef readq
 static inline u64 readq(void __iomem *addr)
 {
-- 
1.7.7.6


  parent reply	other threads:[~2014-02-21 15:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 15:49 [PATCH v2 0/4] ntb: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-21 15:49 ` [PATCH v2 1/4] ntb: Fix leakage of ntb_device::msix_entries[] array Alexander Gordeev
2014-02-21 23:33   ` Jon Mason
2014-02-28 11:35     ` Alexander Gordeev
2014-02-21 15:49 ` Alexander Gordeev [this message]
2014-03-04  0:12   ` [PATCH v2 2/4] ntb: Use pci_msix_vec_count() to obtain number of MSI-Xs Jon Mason
2014-02-21 15:49 ` [PATCH v2 3/4] ntb: Split ntb_setup_msix() into separate BWD/SNB routines Alexander Gordeev
2014-02-22 19:55   ` Alexander Gordeev
2014-03-04  0:12   ` Jon Mason
2014-03-04 16:41     ` Alexander Gordeev
2014-03-10 21:18       ` Jon Mason
2014-03-11 16:00   ` Alexander Gordeev
2014-03-11 17:14     ` Jon Mason
2014-02-21 15:49 ` [PATCH v2 4/4] ntb: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-03-11 16:00   ` Alexander Gordeev
2014-03-11 17:15     ` Jon Mason
2014-02-21 16:09 ` [PATCH v2 0/4] " Alexander Gordeev
2014-02-22 19:56   ` Alexander Gordeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=342d032b652517e2084ba97962ed017a25bf10bd.1392996332.git.agordeev@redhat.com \
    --to=agordeev@redhat.com \
    --cc=jon.mason@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.