All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] spi: qup: Fix build error due to a typo
@ 2014-02-23  5:27 Axel Lin
  2014-02-23  5:28 ` [PATCH 2/2] spi: qup: Enable driver compilation with COMPILE_TEST Axel Lin
  2014-02-23  5:39 ` [PATCH 1/2] spi: qup: Fix build error due to a typo Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-02-23  5:27 UTC (permalink / raw)
  To: Mark Brown; +Cc: Ivan T. Ivanov, linux-spi-u79uwXL29TY76Z2rM5mHXA

Fix below build error when CONFIG_PM_RUNTIME=y:

C [M]  drivers/spi/spi-qup.o
drivers/spi/spi-qup.c: In function 'spi_qup_pm_suspend_runtime':
drivers/spi/spi-qup.c:712:12: error: 'QUP_CLOCK_AUTO_GATE' undeclared (first use in this function)
drivers/spi/spi-qup.c:712:12: note: each undeclared identifier is reported only once for each function it appears in
drivers/spi/spi-qup.c: In function 'spi_qup_pm_resume_runtime':
drivers/spi/spi-qup.c:725:13: error: 'QUP_CLOCK_AUTO_GATE' undeclared (first use in this function)
make[2]: *** [drivers/spi/spi-qup.o] Error 1
make[1]: *** [drivers/spi] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
 drivers/spi/spi-qup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index dec339d..886edb4 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -709,7 +709,7 @@ static int spi_qup_pm_suspend_runtime(struct device *device)
 
 	/* Enable clocks auto gaiting */
 	config = readl(controller->base + QUP_CONFIG);
-	config |= QUP_CLOCK_AUTO_GATE;
+	config |= QUP_CONFIG_CLOCK_AUTO_GATE;
 	writel_relaxed(config, controller->base + QUP_CONFIG);
 	return 0;
 }
@@ -722,7 +722,7 @@ static int spi_qup_pm_resume_runtime(struct device *device)
 
 	/* Disable clocks auto gaiting */
 	config = readl_relaxed(controller->base + QUP_CONFIG);
-	config &= ~QUP_CLOCK_AUTO_GATE;
+	config &= ~QUP_CONFIG_CLOCK_AUTO_GATE;
 	writel_relaxed(config, controller->base + QUP_CONFIG);
 	return 0;
 }
-- 
1.8.1.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH 2/2] spi: qup: Enable driver compilation with COMPILE_TEST
  2014-02-23  5:27 [PATCH 1/2] spi: qup: Fix build error due to a typo Axel Lin
@ 2014-02-23  5:28 ` Axel Lin
  2014-02-23  5:39 ` [PATCH 1/2] spi: qup: Fix build error due to a typo Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Axel Lin @ 2014-02-23  5:28 UTC (permalink / raw)
  To: Mark Brown; +Cc: Ivan T. Ivanov, linux-spi-u79uwXL29TY76Z2rM5mHXA

This helps increasing build testing coverage.

Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 65e420d..e4e170f 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -384,7 +384,7 @@ config SPI_RSPI
 
 config SPI_QUP
 	tristate "Qualcomm SPI controller with QUP interface"
-	depends on ARCH_MSM_DT
+	depends on ARCH_MSM_DT || COMPILE_TEST
 	help
 	  Qualcomm Universal Peripheral (QUP) core is an AHB slave that
 	  provides a common data path (an output FIFO and an input FIFO)
-- 
1.8.1.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] spi: qup: Fix build error due to a typo
  2014-02-23  5:27 [PATCH 1/2] spi: qup: Fix build error due to a typo Axel Lin
  2014-02-23  5:28 ` [PATCH 2/2] spi: qup: Enable driver compilation with COMPILE_TEST Axel Lin
@ 2014-02-23  5:39 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-02-23  5:39 UTC (permalink / raw)
  To: Axel Lin; +Cc: Ivan T. Ivanov, linux-spi-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 131 bytes --]

On Sun, Feb 23, 2014 at 01:27:16PM +0800, Axel Lin wrote:
> Fix below build error when CONFIG_PM_RUNTIME=y:

Applied both, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-23  5:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-23  5:27 [PATCH 1/2] spi: qup: Fix build error due to a typo Axel Lin
2014-02-23  5:28 ` [PATCH 2/2] spi: qup: Enable driver compilation with COMPILE_TEST Axel Lin
2014-02-23  5:39 ` [PATCH 1/2] spi: qup: Fix build error due to a typo Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.