Re: [PATCH v5 net-next] tcp: switch rtt estimations to usec resolution

From: Stephen Hemminger <stephen@networkplumber.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Julian Anastasov <ja@ssi.bg>, David Miller <davem@davemloft.net>,
	Yuchung Cheng <ycheng@google.com>,
	netdev <netdev@vger.kernel.org>,
	Neal Cardwell <ncardwell@google.com>,
	Larry Brakmo <brakmo@google.com>
Subject: Re: [PATCH v5 net-next] tcp: switch rtt estimations to usec resolution
Date: Mon, 24 Feb 2014 15:51:30 -0800	[thread overview]
Message-ID: <20140224155130.4c286cca@samsung-9> (raw)
In-Reply-To: <1393284682.2316.83.camel@edumazet-glaptop2.roam.corp.google.com>

On Mon, 24 Feb 2014 15:31:22 -0800
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> From: Eric Dumazet <edumazet@google.com>
> 
> Upcoming congestion controls for TCP require usec resolution for RTT
> estimations. Millisecond resolution is simply not enough these days.
> 
> FQ/pacing in DC environments also require this change for finer control
> and removal of bimodal behavior due to the current hack in
> tcp_update_pacing_rate() for 'small rtt'
> 
> TCP_CONG_RTT_STAMP no longer is needed.
> 
> As Julian Anastasov pointed out, we need to keep user compatibility :
> tcp_metrics used to export RTT and RTTVAR in msec resolution,
> so we added RTT_US and RTTVAR_US. An iproute2 patch is needed
> to use the new attributes if provided by the kernel.
> 
> In this example ss command displays a srtt of 32 usecs
> 
> lpk51:~# ./ss -i dst lpk52
> Netid  State      Recv-Q Send-Q   Local Address:Port       Peer
> Address:Port   
> tcp    ESTAB      0      1         10.246.11.51:42959
> 10.246.11.52:64614   
>          cubic wscale:6,6 rto:201 rtt:0.032/0.001 ato:40 mss:1448
> cwnd:10 send
> 3620.0Mbps pacing_rate 7240.0Mbps unacked:1 rcv_rtt:993 rcv_space:29559
>  
> Updated iproute2 ip command displays :
> 
> lpk51:~# ./ip tcp_metrics | grep 10.246.11.52
> 10.246.11.52 age 561.914sec cwnd 10 rtt 274us rttvar 213us source
> 10.246.11.51
> 
> Old binary displays :
> 
> lpk51:~# ip tcp_metrics | grep 10.246.11.52
> 10.246.11.52 age 561.914sec cwnd 10 rtt 250us rttvar 125us source
> 10.246.11.51
> 
> With help from Julian Anastasov and Yuchung Cheng
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Yuchung Cheng <ycheng@google.com>
> Cc: Neal Cardwell <ncardwell@google.com>
> Cc: Larry Brakmo <brakmo@google.com>
> Cc: Julian Anastasov <ja@ssi.bg>

The original reason I kept ms resolution and added the flag was
that accessing high resolution time is expensive for systems where
TSC is not stable.  Google may live in a world of SMP systems with
good X86 CPUs with working TSC, but other architectures and system
config's may have non-working TSC.