From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>, Julian Anastasov <ja@ssi.bg>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>,
Larry Brakmo <brakmo@google.com>
Subject: Re: [PATCH v2 net-next] tcp: switch rtt estimations to usec resolution
Date: Fri, 28 Feb 2014 14:31:27 +0100 [thread overview]
Message-ID: <20140228133127.GT22728@two.firstfloor.org> (raw)
In-Reply-To: <1393568072.26794.53.camel@edumazet-glaptop2.roam.corp.google.com>
> Right, so I cooked this instead :
>
> http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=363ec392352e55c61ce2799c3f15f89f9429bba7
>
> Is this OK or do you see a problem with this ?
It seems mostly ok. I assume the compiler optimizes the constant do_div to a
multiplication?
I'm not sure it's better than ktime() if it works. So it may be still
better to have some global flag that says "ktime is slow" and
qualify it on that. But that would need changing the timer
subsystem.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2014-02-28 13:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 6:38 [PATCH net-next] tcp: switch rtt estimations to usec resolution Eric Dumazet
2014-02-23 7:36 ` Julian Anastasov
2014-02-23 17:55 ` Eric Dumazet
2014-02-23 18:50 ` [PATCH v2 " Eric Dumazet
2014-02-23 19:19 ` Yuchung Cheng
2014-02-23 21:41 ` Eric Dumazet
2014-02-24 4:42 ` [PATCH v3 " Eric Dumazet
2014-02-24 17:58 ` Eric Dumazet
2014-02-24 18:24 ` [PATCH v4 " Eric Dumazet
2014-02-24 20:47 ` Julian Anastasov
2014-02-24 22:13 ` Eric Dumazet
2014-02-24 23:01 ` Julian Anastasov
2014-02-24 23:31 ` [PATCH v5 " Eric Dumazet
2014-02-24 23:51 ` Stephen Hemminger
2014-02-25 0:15 ` David Miller
2014-02-25 1:11 ` Eric Dumazet
2014-02-25 1:38 ` Eric Dumazet
2014-02-25 6:22 ` [PATCH v6 net-next 1/2] net: add skb_mstamp infrastructure Eric Dumazet
2014-02-25 9:51 ` David Laight
2014-02-25 12:21 ` Eric Dumazet
2014-02-26 20:02 ` David Miller
2014-02-26 20:29 ` Eric Dumazet
2014-02-26 22:02 ` [PATCH v7 " Eric Dumazet
2014-02-26 22:04 ` David Miller
2014-02-25 6:22 ` [PATCH v6 net-next 2/2] tcp: switch rtt estimations to usec resolution Eric Dumazet
2014-02-25 17:46 ` Neal Cardwell
2014-02-25 18:17 ` Eric Dumazet
2014-02-25 19:13 ` Neal Cardwell
2014-02-26 22:02 ` [PATCH v7 " Eric Dumazet
2014-02-26 22:04 ` David Miller
2014-02-27 1:09 ` Stephen Hemminger
2014-02-27 1:21 ` Rick Jones
2014-02-27 9:57 ` David Laight
2014-02-27 2:25 ` Eric Dumazet
2014-02-24 22:19 ` [PATCH v4 net-next] " Eric Dumazet
2014-02-28 5:20 ` [PATCH v2 " Andi Kleen
2014-02-28 6:14 ` Eric Dumazet
2014-02-28 13:31 ` Andi Kleen [this message]
2014-02-28 13:51 ` Eric Dumazet
2014-02-23 19:11 ` [PATCH " Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228133127.GT22728@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=brakmo@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ja@ssi.bg \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.