* [PATCH] timberdale: Use pci_enable_msix_range() instead of pci_enable_msix()
@ 2014-02-19 10:15 Alexander Gordeev
2014-02-19 11:44 ` Lee Jones
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Gordeev @ 2014-02-19 10:15 UTC (permalink / raw)
To: linux-kernel; +Cc: Alexander Gordeev, Samuel Ortiz, Lee Jones, linux-pci
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() and pci_enable_msix_range()
interfaces.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linux-pci@vger.kernel.org
---
drivers/mfd/timberdale.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
index 2bc5cfb..c2bc6d7 100644
--- a/drivers/mfd/timberdale.c
+++ b/drivers/mfd/timberdale.c
@@ -715,8 +715,9 @@ static int timb_probe(struct pci_dev *dev,
for (i = 0; i < TIMBERDALE_NR_IRQS; i++)
msix_entries[i].entry = i;
- err = pci_enable_msix(dev, msix_entries, TIMBERDALE_NR_IRQS);
- if (err) {
+ err = pci_enable_msix_range(dev, msix_entries,
+ TIMBERDALE_NR_IRQS, TIMBERDALE_NR_IRQS);
+ if (err < 0) {
dev_err(&dev->dev,
"MSI-X init failed: %d, expected entries: %d\n",
err, TIMBERDALE_NR_IRQS);
--
1.7.7.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] timberdale: Use pci_enable_msix_range() instead of pci_enable_msix()
2014-02-19 10:15 [PATCH] timberdale: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
@ 2014-02-19 11:44 ` Lee Jones
2014-02-21 16:56 ` Alexander Gordeev
0 siblings, 1 reply; 10+ messages in thread
From: Lee Jones @ 2014-02-19 11:44 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: linux-kernel, Samuel Ortiz, linux-pci
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() and pci_enable_msix_range()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linux-pci@vger.kernel.org
> ---
> drivers/mfd/timberdale.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] timberdale: Use pci_enable_msix_range() instead of pci_enable_msix()
2014-02-19 11:44 ` Lee Jones
@ 2014-02-21 16:56 ` Alexander Gordeev
2014-02-21 16:58 ` [PATCH v2] timberdale: Use pci_enable_msix_exact() " Alexander Gordeev
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Gordeev @ 2014-02-21 16:56 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Samuel Ortiz, linux-pci
Hi Lee et al,
Based on recently accepted to the mainline pci_enable_msix_exact() function,
I am sending an updated version of the patch. Please, let me know if it does
not work for you and you need and incremental update from the previous version.
Thanks!
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] timberdale: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-02-21 16:56 ` Alexander Gordeev
@ 2014-02-21 16:58 ` Alexander Gordeev
2014-02-24 16:29 ` Lee Jones
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Gordeev @ 2014-02-21 16:58 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Samuel Ortiz, linux-pci
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linux-pci@vger.kernel.org
---
drivers/mfd/timberdale.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
index 2bc5cfb..6ce36d6 100644
--- a/drivers/mfd/timberdale.c
+++ b/drivers/mfd/timberdale.c
@@ -715,7 +715,7 @@ static int timb_probe(struct pci_dev *dev,
for (i = 0; i < TIMBERDALE_NR_IRQS; i++)
msix_entries[i].entry = i;
- err = pci_enable_msix(dev, msix_entries, TIMBERDALE_NR_IRQS);
+ err = pci_enable_msix_exact(dev, msix_entries, TIMBERDALE_NR_IRQS);
if (err) {
dev_err(&dev->dev,
"MSI-X init failed: %d, expected entries: %d\n",
--
1.7.7.6
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] timberdale: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-02-21 16:58 ` [PATCH v2] timberdale: Use pci_enable_msix_exact() " Alexander Gordeev
@ 2014-02-24 16:29 ` Lee Jones
2014-03-03 7:25 ` Lee Jones
0 siblings, 1 reply; 10+ messages in thread
From: Lee Jones @ 2014-02-24 16:29 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: linux-kernel, Samuel Ortiz, linux-pci
On Fri, 21 Feb 2014, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linux-pci@vger.kernel.org
> ---
> drivers/mfd/timberdale.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] timberdale: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-02-24 16:29 ` Lee Jones
@ 2014-03-03 7:25 ` Lee Jones
2014-03-03 8:10 ` Alexander Gordeev
0 siblings, 1 reply; 10+ messages in thread
From: Lee Jones @ 2014-03-03 7:25 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: linux-kernel, Samuel Ortiz, linux-pci
> > As result of deprecation of MSI-X/MSI enablement functions
> > pci_enable_msix() and pci_enable_msi_block() all drivers
> > using these two interfaces need to be updated to use the
> > new pci_enable_msi_range() or pci_enable_msi_exact()
> > and pci_enable_msix_range() or pci_enable_msix_exact()
> > interfaces.
> >
> > Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: linux-pci@vger.kernel.org
> > ---
> > drivers/mfd/timberdale.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Applied, thanks.
I've reverted this patch, as it doesn't build othognally.
drivers/mfd/timberdale.c:718:2:
error: implicit declaration of function ‘pci_enable_msix_exact’
[-Werror=implicit-function-declaration]
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] timberdale: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-03 7:25 ` Lee Jones
@ 2014-03-03 8:10 ` Alexander Gordeev
2014-03-03 9:26 ` Lee Jones
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Gordeev @ 2014-03-03 8:10 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Samuel Ortiz, linux-pci
On Mon, Mar 03, 2014 at 03:25:51PM +0800, Lee Jones wrote:
> > Applied, thanks.
>
> I've reverted this patch, as it doesn't build othognally.
>
> drivers/mfd/timberdale.c:718:2:
> error: implicit declaration of function ‘pci_enable_msix_exact’
> [-Werror=implicit-function-declaration]
I should have to clarify it I think. Do you build on top of 3.14-rc4?
Thanks!
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] timberdale: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-03 8:10 ` Alexander Gordeev
@ 2014-03-03 9:26 ` Lee Jones
2014-03-03 9:33 ` Alexander Gordeev
0 siblings, 1 reply; 10+ messages in thread
From: Lee Jones @ 2014-03-03 9:26 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: linux-kernel, Samuel Ortiz, linux-pci
> > > Applied, thanks.
> >
> > I've reverted this patch, as it doesn't build othognally.
> >
> > drivers/mfd/timberdale.c:718:2:
> > error: implicit declaration of function ‘pci_enable_msix_exact’
> > [-Werror=implicit-function-declaration]
>
> I should have to clarify it I think. Do you build on top of 3.14-rc4?
Not yet. Is the required patch in there?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] timberdale: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-03 9:26 ` Lee Jones
@ 2014-03-03 9:33 ` Alexander Gordeev
2014-03-03 10:04 ` Lee Jones
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Gordeev @ 2014-03-03 9:33 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Samuel Ortiz, linux-pci
On Mon, Mar 03, 2014 at 05:26:00PM +0800, Lee Jones wrote:
> > > > Applied, thanks.
> > >
> > > I've reverted this patch, as it doesn't build othognally.
> > >
> > > drivers/mfd/timberdale.c:718:2:
> > > error: implicit declaration of function ‘pci_enable_msix_exact’
> > > [-Werror=implicit-function-declaration]
> >
> > I should have to clarify it I think. Do you build on top of 3.14-rc4?
>
> Not yet. Is the required patch in there?
Yep - commit 302a252 ("PCI/MSI: Add pci_enable_msi_range() and
pci_enable_msix_range()").
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] timberdale: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-03 9:33 ` Alexander Gordeev
@ 2014-03-03 10:04 ` Lee Jones
0 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2014-03-03 10:04 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: linux-kernel, Samuel Ortiz, linux-pci
> > > > > Applied, thanks.
> > > >
> > > > I've reverted this patch, as it doesn't build othognally.
> > > >
> > > > drivers/mfd/timberdale.c:718:2:
> > > > error: implicit declaration of function ‘pci_enable_msix_exact’
> > > > [-Werror=implicit-function-declaration]
> > >
> > > I should have to clarify it I think. Do you build on top of 3.14-rc4?
> >
> > Not yet. Is the required patch in there?
>
> Yep - commit 302a252 ("PCI/MSI: Add pci_enable_msi_range() and
> pci_enable_msix_range()").
Okay, seems to work fine post-rebase.
Reapplied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-03-03 10:04 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-19 10:15 [PATCH] timberdale: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-19 11:44 ` Lee Jones
2014-02-21 16:56 ` Alexander Gordeev
2014-02-21 16:58 ` [PATCH v2] timberdale: Use pci_enable_msix_exact() " Alexander Gordeev
2014-02-24 16:29 ` Lee Jones
2014-03-03 7:25 ` Lee Jones
2014-03-03 8:10 ` Alexander Gordeev
2014-03-03 9:26 ` Lee Jones
2014-03-03 9:33 ` Alexander Gordeev
2014-03-03 10:04 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.