All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] arm: delete unused macro CONFIG_ARCH_DEVICE_TREE
@ 2014-02-24 12:45 Masahiro Yamada
  2014-02-24 17:26 ` Stephen Warren
  2014-02-25 13:58 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2014-02-24 12:45 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Tom Warren <twarren@nvidia.com>
Cc: Stephen Warren <swarren@nvidia.com>
Cc: Rajeshwari Birje <rajeshwari.s@samsung.com>
Cc: Inderpal Singh <inderpal.singh@linaro.org>
---

Hi.

I grepped the whole tree and found
   arch/arm/cpu/armv7/tegra124/config.mk
   include/configs/arndale.h
   include/configs/smdk5420.h
define CONFIG_ARCH_DEVICE_TREE,
but it is never used anywhere.

I cannot understand what this macro was added for.
If I am doing a wrong thing, please stop me.


 arch/arm/cpu/armv7/tegra124/config.mk | 10 ----------
 include/configs/arndale.h             |  2 --
 include/configs/smdk5420.h            |  2 --
 3 files changed, 14 deletions(-)
 delete mode 100644 arch/arm/cpu/armv7/tegra124/config.mk

diff --git a/arch/arm/cpu/armv7/tegra124/config.mk b/arch/arm/cpu/armv7/tegra124/config.mk
deleted file mode 100644
index 2f1c645..0000000
--- a/arch/arm/cpu/armv7/tegra124/config.mk
+++ /dev/null
@@ -1,10 +0,0 @@
-#
-# (C) Copyright 2013
-# NVIDIA Corporation <www.nvidia.com>
-# (C) Copyright 2002
-# Gary Jennejohn, DENX Software Engineering, <garyj@denx.de>
-#
-# SPDX-License-Identifier:     GPL-2.0+
-#
-
-CONFIG_ARCH_DEVICE_TREE := tegra124
diff --git a/include/configs/arndale.h b/include/configs/arndale.h
index 9584d82..515facf 100644
--- a/include/configs/arndale.h
+++ b/include/configs/arndale.h
@@ -22,8 +22,6 @@
 #define CONFIG_DISPLAY_CPUINFO
 #define CONFIG_DISPLAY_BOARDINFO
 
-/* Enable fdt support for Exynos5250 */
-#define CONFIG_ARCH_DEVICE_TREE		exynos5250
 #define CONFIG_OF_CONTROL
 #define CONFIG_OF_SEPARATE
 
diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h
index 447f8e5..b96eea8 100644
--- a/include/configs/smdk5420.h
+++ b/include/configs/smdk5420.h
@@ -17,8 +17,6 @@
 #undef CONFIG_DEFAULT_DEVICE_TREE
 #define CONFIG_DEFAULT_DEVICE_TREE	exynos5420-smdk5420
 
-#define CONFIG_ARCH_DEVICE_TREE		exynos5420
-
 #define CONFIG_VAR_SIZE_SPL
 
 #define CONFIG_SYS_SDRAM_BASE		0x20000000
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] arm: delete unused macro CONFIG_ARCH_DEVICE_TREE
  2014-02-24 12:45 [U-Boot] [PATCH] arm: delete unused macro CONFIG_ARCH_DEVICE_TREE Masahiro Yamada
@ 2014-02-24 17:26 ` Stephen Warren
  2014-02-25  0:04   ` Masahiro Yamada
  2014-02-25 13:58 ` [U-Boot] " Tom Rini
  1 sibling, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2014-02-24 17:26 UTC (permalink / raw)
  To: u-boot

On 02/24/2014 05:45 AM, Masahiro Yamada wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Commit description?

Acked-by: Stephen Warren <swarren@nvidia.com>

FWIW, this config option was used prior to:

8ad723acd7e9 dts/Makefile: don't define ARCH_CPU_DTS, BOARD_DTS
6e8e0311ccc7 dt: don't use ARCH_CPU_DTS
...
6c5be646b47e Tegra: fdt: Change /include/ to #include for C preprocessor

I evidently forgot to remove some of the places where Exynos boards
defined CONFIG_ARCH_DEVICE_TREE, and when sending the Tegra124 patches
recently, didn't notice that I didn't need the file that defined it there.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] arm: delete unused macro CONFIG_ARCH_DEVICE_TREE
  2014-02-24 17:26 ` Stephen Warren
@ 2014-02-25  0:04   ` Masahiro Yamada
  0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2014-02-25  0:04 UTC (permalink / raw)
  To: u-boot

Hello Stephen

On Mon, 24 Feb 2014 10:26:46 -0700
Stephen Warren <swarren@wwwdotorg.org> wrote:

> On 02/24/2014 05:45 AM, Masahiro Yamada wrote:
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> 
> Commit description?

This patch looked trivial so I did not write commit description.
Sorry for my laziness..

Best Regards
Masahiro

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] arm: delete unused macro CONFIG_ARCH_DEVICE_TREE
  2014-02-24 12:45 [U-Boot] [PATCH] arm: delete unused macro CONFIG_ARCH_DEVICE_TREE Masahiro Yamada
  2014-02-24 17:26 ` Stephen Warren
@ 2014-02-25 13:58 ` Tom Rini
  1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2014-02-25 13:58 UTC (permalink / raw)
  To: u-boot

On Mon, Feb 24, 2014 at 09:45:48PM +0900, Masahiro Yamada wrote:

> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Tom Warren <twarren@nvidia.com>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: Rajeshwari Birje <rajeshwari.s@samsung.com>
> Cc: Inderpal Singh <inderpal.singh@linaro.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140225/e53b1d4a/attachment.pgp>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-02-25 13:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-24 12:45 [U-Boot] [PATCH] arm: delete unused macro CONFIG_ARCH_DEVICE_TREE Masahiro Yamada
2014-02-24 17:26 ` Stephen Warren
2014-02-25  0:04   ` Masahiro Yamada
2014-02-25 13:58 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.