[PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Fabio Estevam]

When building an ARM multi_v7_defconfig with LPAE option selected we get the
following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/watchdog/orion_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
index 15321aa..6f9b4c6 100644
--- a/drivers/watchdog/orion_wdt.c
+++ b/drivers/watchdog/orion_wdt.c
@@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
 
 	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
 
-	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
+	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
 	return devm_ioremap(&pdev->dev, rstout, 0x4);
 }
 
-- 
1.8.1.2

Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Guenter Roeck]

On 02/18/2014 04:23 AM, Fabio Estevam wrote:
> When building an ARM multi_v7_defconfig with LPAE option selected we get the
> following build warning:
>
> drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
>
> Fix it by using %pa to print 'phys_addr_t'.
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Ezequiel Garcia]

On Tue, Feb 18, 2014 at 09:23:54AM -0300, Fabio Estevam wrote:
> When building an ARM multi_v7_defconfig with LPAE option selected we get the
> following build warning:
> 
> drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> 
> Fix it by using %pa to print 'phys_addr_t'.
> 
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Wim Van Sebroeck]

Hi Ezequiel,

Can you have a look at the below patch?

Kind regards,
Wim.

> When building an ARM multi_v7_defconfig with LPAE option selected we get the
> following build warning:
> 
> drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> 
> Fix it by using %pa to print 'phys_addr_t'.
> 
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/watchdog/orion_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> index 15321aa..6f9b4c6 100644
> --- a/drivers/watchdog/orion_wdt.c
> +++ b/drivers/watchdog/orion_wdt.c
> @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
>  
>  	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
>  
> -	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> +	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
>  	return devm_ioremap(&pdev->dev, rstout, 0x4);
>  }
>  
> -- 
> 1.8.1.2
> 
> 

Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Ezequiel Garcia]

On Wed, Feb 19, 2014 at 05:59:33PM +0100, Wim Van Sebroeck wrote:
> 
> Can you have a look at the below patch?
> 

I've acked-it yesterday, I think.

Do you want me to re-send the mail?
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Wim Van Sebroeck]

Hi Ezequiel,

> On Wed, Feb 19, 2014 at 05:59:33PM +0100, Wim Van Sebroeck wrote:
> > 
> > Can you have a look at the below patch?
> > 
> 
> I've acked-it yesterday, I think.
> 
> Do you want me to re-send the mail?

Not needed :-). I have it.

Kind regards,
Wim.

Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Wim Van Sebroeck]

Hi All,

> When building an ARM multi_v7_defconfig with LPAE option selected we get the
> following build warning:
> 
> drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> 
> Fix it by using %pa to print 'phys_addr_t'.
> 
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/watchdog/orion_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> index 15321aa..6f9b4c6 100644
> --- a/drivers/watchdog/orion_wdt.c
> +++ b/drivers/watchdog/orion_wdt.c
> @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
>  
>  	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
>  
> -	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> +	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
>  	return devm_ioremap(&pdev->dev, rstout, 0x4);
>  }
>  
> -- 
> 1.8.1.2
> 
> 

Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also thereà?

Kind regards,
Wim.

Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Ezequiel Garcia]

Jason,

On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote:
> > When building an ARM multi_v7_defconfig with LPAE option selected we get the
> > following build warning:
> > 
> > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> > 
> > Fix it by using %pa to print 'phys_addr_t'.
> > 
> > Reported-by: Olof's autobuilder <build@lixom.net>
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> >  drivers/watchdog/orion_wdt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > index 15321aa..6f9b4c6 100644
> > --- a/drivers/watchdog/orion_wdt.c
> > +++ b/drivers/watchdog/orion_wdt.c
> > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
> >  
> >  	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
> >  
> > -	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> > +	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
> >  	return devm_ioremap(&pdev->dev, rstout, 0x4);
> >  }
> >  
> > -- 
> > 1.8.1.2
> > 
> > 
> 
> Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also thereà?
> 

Can you pull this too? It's been acked by Wim and me.

Thanks,
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Ezequiel Garcia]

Jason,

On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote:
> > When building an ARM multi_v7_defconfig with LPAE option selected we get the
> > following build warning:
> > 
> > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> > 
> > Fix it by using %pa to print 'phys_addr_t'.
> > 
> > Reported-by: Olof's autobuilder <build@lixom.net>
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> >  drivers/watchdog/orion_wdt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > index 15321aa..6f9b4c6 100644
> > --- a/drivers/watchdog/orion_wdt.c
> > +++ b/drivers/watchdog/orion_wdt.c
> > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
> >  
> >  	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
> >  
> > -	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> > +	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
> >  	return devm_ioremap(&pdev->dev, rstout, 0x4);
> >  }
> >  
> > -- 
> > 1.8.1.2
> > 
> > 
> 
> Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there??
> 

Can you pull this too? It's been acked by Wim and me.

Thanks,
-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Jason Cooper]

On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote:
> Jason,
> 
> On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote:
> > > When building an ARM multi_v7_defconfig with LPAE option selected we get the
> > > following build warning:
> > > 
> > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> > > 
> > > Fix it by using %pa to print 'phys_addr_t'.
> > > 
> > > Reported-by: Olof's autobuilder <build@lixom.net>
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > > ---
> > >  drivers/watchdog/orion_wdt.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > > index 15321aa..6f9b4c6 100644
> > > --- a/drivers/watchdog/orion_wdt.c
> > > +++ b/drivers/watchdog/orion_wdt.c
> > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
> > >  
> > >  	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
> > >  
> > > -	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> > > +	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
> > >  	return devm_ioremap(&pdev->dev, rstout, 0x4);
> > >  }
> > >  
> > > -- 
> > > 1.8.1.2
> > > 
> > > 
> > 
> > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also thereà?
> > 
> 
> Can you pull this too? It's been acked by Wim and me.

Yep, I'll add it onto the stack.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Jason Cooper]

On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote:
> Jason,
> 
> On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote:
> > > When building an ARM multi_v7_defconfig with LPAE option selected we get the
> > > following build warning:
> > > 
> > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> > > 
> > > Fix it by using %pa to print 'phys_addr_t'.
> > > 
> > > Reported-by: Olof's autobuilder <build@lixom.net>
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > > ---
> > >  drivers/watchdog/orion_wdt.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > > index 15321aa..6f9b4c6 100644
> > > --- a/drivers/watchdog/orion_wdt.c
> > > +++ b/drivers/watchdog/orion_wdt.c
> > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
> > >  
> > >  	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
> > >  
> > > -	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> > > +	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
> > >  	return devm_ioremap(&pdev->dev, rstout, 0x4);
> > >  }
> > >  
> > > -- 
> > > 1.8.1.2
> > > 
> > > 
> > 
> > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there??
> > 
> 
> Can you pull this too? It's been acked by Wim and me.

Yep, I'll add it onto the stack.

thx,

Jason.

Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Jason Cooper]

Fabio,

On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote:
> Jason,
> 
> On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote:
> > > When building an ARM multi_v7_defconfig with LPAE option selected we get the
> > > following build warning:
> > > 
> > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> > > 
> > > Fix it by using %pa to print 'phys_addr_t'.
> > > 
> > > Reported-by: Olof's autobuilder <build@lixom.net>
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > > ---
> > >  drivers/watchdog/orion_wdt.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > > index 15321aa..6f9b4c6 100644
> > > --- a/drivers/watchdog/orion_wdt.c
> > > +++ b/drivers/watchdog/orion_wdt.c
> > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
> > >  
> > >  	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
> > >  
> > > -	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> > > +	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
> > >  	return devm_ioremap(&pdev->dev, rstout, 0x4);
> > >  }
> > >  
> > > -- 
> > > 1.8.1.2
> > > 
> > > 
> > 
> > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also thereà?
> > 
> 
> Can you pull this too? It's been acked by Wim and me.

I don't have a local archive of the watchdog ML, could you resend the
patch to me?

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

[Jason Cooper]

Fabio,

On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote:
> Jason,
> 
> On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote:
> > > When building an ARM multi_v7_defconfig with LPAE option selected we get the
> > > following build warning:
> > > 
> > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
> > > 
> > > Fix it by using %pa to print 'phys_addr_t'.
> > > 
> > > Reported-by: Olof's autobuilder <build@lixom.net>
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > > ---
> > >  drivers/watchdog/orion_wdt.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > > index 15321aa..6f9b4c6 100644
> > > --- a/drivers/watchdog/orion_wdt.c
> > > +++ b/drivers/watchdog/orion_wdt.c
> > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
> > >  
> > >  	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
> > >  
> > > -	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
> > > +	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
> > >  	return devm_ioremap(&pdev->dev, rstout, 0x4);
> > >  }
> > >  
> > > -- 
> > > 1.8.1.2
> > > 
> > > 
> > 
> > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there??
> > 
> 
> Can you pull this too? It's been acked by Wim and me.

I don't have a local archive of the watchdog ML, could you resend the
patch to me?

thx,

Jason.