* Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents
[not found] <1393408077-556-1-git-send-email-pl@kamp.de>
@ 2014-02-26 10:17 ` Fam Zheng
2014-02-27 10:06 ` Stefan Hajnoczi
2014-02-27 15:49 ` Stefan Hajnoczi
1 sibling, 1 reply; 6+ messages in thread
From: Fam Zheng @ 2014-02-26 10:17 UTC (permalink / raw)
To: Peter Lieven; +Cc: kwolf, qemu-devel, stefanha
On Wed, 02/26 10:47, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/vmdk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index ff6f5ee..5fa29b0 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -1146,7 +1146,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs,
> break;
> case VMDK_OK:
> ret = BDRV_BLOCK_DATA;
> - if (extent->file == bs->file) {
> + if (extent->file == bs->file && !extent->compressed) {
> ret |= BDRV_BLOCK_OFFSET_VALID | offset;
> }
>
> --
> 1.7.9.5
>
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents
2014-02-26 10:17 ` [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents Fam Zheng
@ 2014-02-27 10:06 ` Stefan Hajnoczi
2014-02-27 10:15 ` Peter Lieven
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Hajnoczi @ 2014-02-27 10:06 UTC (permalink / raw)
To: Fam Zheng; +Cc: kwolf, Peter Lieven, qemu-devel, stefanha
On Wed, Feb 26, 2014 at 06:17:31PM +0800, Fam Zheng wrote:
> On Wed, 02/26 10:47, Peter Lieven wrote:
> > Signed-off-by: Peter Lieven <pl@kamp.de>
> > ---
> > block/vmdk.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/block/vmdk.c b/block/vmdk.c
> > index ff6f5ee..5fa29b0 100644
> > --- a/block/vmdk.c
> > +++ b/block/vmdk.c
> > @@ -1146,7 +1146,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs,
> > break;
> > case VMDK_OK:
> > ret = BDRV_BLOCK_DATA;
> > - if (extent->file == bs->file) {
> > + if (extent->file == bs->file && !extent->compressed) {
> > ret |= BDRV_BLOCK_OFFSET_VALID | offset;
> > }
> >
> > --
> > 1.7.9.5
> >
>
> Reviewed-by: Fam Zheng <famz@redhat.com>
I don't have the original mail :(. Did it get sent out the mailing
list?
All patches must be posted to qemu-devel@nongnu.org so they can be
reviewed by the community before being merged. Please send top-level
mails, don't send new patches as a reply to another thread.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents
2014-02-27 10:06 ` Stefan Hajnoczi
@ 2014-02-27 10:15 ` Peter Lieven
0 siblings, 0 replies; 6+ messages in thread
From: Peter Lieven @ 2014-02-27 10:15 UTC (permalink / raw)
To: Stefan Hajnoczi, Fam Zheng; +Cc: kwolf, qemu-devel, stefanha
Am 27.02.2014 11:06, schrieb Stefan Hajnoczi:
> On Wed, Feb 26, 2014 at 06:17:31PM +0800, Fam Zheng wrote:
>> On Wed, 02/26 10:47, Peter Lieven wrote:
>>> Signed-off-by: Peter Lieven <pl@kamp.de>
>>> ---
>>> block/vmdk.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/block/vmdk.c b/block/vmdk.c
>>> index ff6f5ee..5fa29b0 100644
>>> --- a/block/vmdk.c
>>> +++ b/block/vmdk.c
>>> @@ -1146,7 +1146,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs,
>>> break;
>>> case VMDK_OK:
>>> ret = BDRV_BLOCK_DATA;
>>> - if (extent->file == bs->file) {
>>> + if (extent->file == bs->file && !extent->compressed) {
>>> ret |= BDRV_BLOCK_OFFSET_VALID | offset;
>>> }
>>>
>>> --
>>> 1.7.9.5
>>>
>> Reviewed-by: Fam Zheng <famz@redhat.com>
> I don't have the original mail :(. Did it get sent out the mailing
> list?
>
> All patches must be posted to qemu-devel@nongnu.org so they can be
> reviewed by the community before being merged. Please send top-level
> mails, don't send new patches as a reply to another thread.
>
> Stefan
I know. I've sent this patch out to qemu-devel@nongnu.org. Very strange.
I will repost.
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents
[not found] <1393408077-556-1-git-send-email-pl@kamp.de>
2014-02-26 10:17 ` [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents Fam Zheng
@ 2014-02-27 15:49 ` Stefan Hajnoczi
1 sibling, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2014-02-27 15:49 UTC (permalink / raw)
To: Peter Lieven; +Cc: kwolf, Fam Zheng, qemu-devel
On Wed, Feb 26, 2014 at 10:47:57AM +0100, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/vmdk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents
@ 2014-02-27 10:15 Peter Lieven
2014-02-28 10:30 ` Stefan Hajnoczi
0 siblings, 1 reply; 6+ messages in thread
From: Peter Lieven @ 2014-02-27 10:15 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, Peter Lieven, Fam Zheng, stefanha
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block/vmdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index ff6f5ee..5fa29b0 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1146,7 +1146,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs,
break;
case VMDK_OK:
ret = BDRV_BLOCK_DATA;
- if (extent->file == bs->file) {
+ if (extent->file == bs->file && !extent->compressed) {
ret |= BDRV_BLOCK_OFFSET_VALID | offset;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-28 10:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1393408077-556-1-git-send-email-pl@kamp.de>
2014-02-26 10:17 ` [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents Fam Zheng
2014-02-27 10:06 ` Stefan Hajnoczi
2014-02-27 10:15 ` Peter Lieven
2014-02-27 15:49 ` Stefan Hajnoczi
2014-02-27 10:15 Peter Lieven
2014-02-28 10:30 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.