From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
linaro-kernel <linaro-kernel@lists.linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/4] pci: OF: Fix the conversion of IO ranges into IO resources.
Date: Thu, 27 Feb 2014 11:19:51 -0700 [thread overview]
Message-ID: <20140227181951.GC24656@obsidianresearch.com> (raw)
In-Reply-To: <1393506402-11474-2-git-send-email-Liviu.Dudau@arm.com>
On Thu, Feb 27, 2014 at 01:06:39PM +0000, Liviu Dudau wrote:
> + if (res->flags & IORESOURCE_IO) {
> + unsigned long port;
> + port = pci_address_to_pio(range->pci_addr);
This looks very suspicious, pci_addr is not unique across all domains,
so there is no way to convert from a pci_addr to the virtual IO
address without knowing the domain number as well.
I would like to see it be:
port = pci_address_to_pio(range->cpu_addr);
cpu_addr is unique across all domains.
Looking at the microblaze and PPC versions I think the above version
is actually correct (assuming io_base_phys is the CPU address of the
IO window)
Jason
WARNING: multiple messages have this Message-ID (diff)
From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] pci: OF: Fix the conversion of IO ranges into IO resources.
Date: Thu, 27 Feb 2014 11:19:51 -0700 [thread overview]
Message-ID: <20140227181951.GC24656@obsidianresearch.com> (raw)
In-Reply-To: <1393506402-11474-2-git-send-email-Liviu.Dudau@arm.com>
On Thu, Feb 27, 2014 at 01:06:39PM +0000, Liviu Dudau wrote:
> + if (res->flags & IORESOURCE_IO) {
> + unsigned long port;
> + port = pci_address_to_pio(range->pci_addr);
This looks very suspicious, pci_addr is not unique across all domains,
so there is no way to convert from a pci_addr to the virtual IO
address without knowing the domain number as well.
I would like to see it be:
port = pci_address_to_pio(range->cpu_addr);
cpu_addr is unique across all domains.
Looking at the microblaze and PPC versions I think the above version
is actually correct (assuming io_base_phys is the CPU address of the
IO window)
Jason
next prev parent reply other threads:[~2014-02-27 18:19 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 13:06 [PATCH v2 0/4] [RFC] Support for creating generic host_bridge from device tree Liviu Dudau
2014-02-27 13:06 ` Liviu Dudau
[not found] ` < 1393506402-11474-5-git-send-email-Liviu.Dudau@arm.com>
2014-02-27 13:06 ` [PATCH v2 1/4] pci: OF: Fix the conversion of IO ranges into IO resources Liviu Dudau
2014-02-27 13:06 ` Liviu Dudau
2014-02-27 13:20 ` Arnd Bergmann
2014-02-27 13:20 ` Arnd Bergmann
2014-02-27 13:20 ` Arnd Bergmann
2014-02-27 13:45 ` Liviu Dudau
2014-02-27 13:22 ` Andrew Murray
2014-02-27 13:22 ` Andrew Murray
2014-02-27 13:56 ` Liviu Dudau
2014-02-27 14:08 ` Arnd Bergmann
2014-02-27 14:21 ` Liviu Dudau
2014-02-27 16:00 ` Arnd Bergmann
2014-02-27 14:30 ` Liviu Dudau
2014-02-27 13:58 ` Arnd Bergmann
2014-02-27 13:58 ` Arnd Bergmann
2014-02-27 18:19 ` Jason Gunthorpe [this message]
2014-02-27 18:19 ` Jason Gunthorpe
2014-02-27 19:12 ` Liviu Dudau
2014-02-27 19:12 ` Liviu Dudau
2014-02-27 19:12 ` Liviu Dudau
2014-02-27 19:36 ` Jason Gunthorpe
2014-02-27 19:36 ` Jason Gunthorpe
2014-02-27 19:36 ` Jason Gunthorpe
2014-02-27 19:48 ` Arnd Bergmann
2014-02-27 19:48 ` Arnd Bergmann
2014-02-27 20:07 ` Jason Gunthorpe
2014-02-27 20:07 ` Jason Gunthorpe
2014-02-27 20:22 ` Arnd Bergmann
2014-02-27 20:22 ` Arnd Bergmann
2014-02-27 20:22 ` Arnd Bergmann
2014-02-28 12:50 ` Liviu Dudau
2014-02-28 12:50 ` Liviu Dudau
2014-02-28 12:50 ` Liviu Dudau
2014-02-27 13:06 ` [PATCH v2 2/4] pci: Create pci_host_bridge before its associated bus in pci_create_root_bus Liviu Dudau
2014-02-27 13:06 ` Liviu Dudau
2014-02-27 13:06 ` Liviu Dudau
2014-02-27 13:22 ` Arnd Bergmann
2014-02-27 13:22 ` Arnd Bergmann
2014-02-27 13:06 ` [PATCH v2 3/4] pci: Introduce a domain number for pci_host_bridge Liviu Dudau
2014-02-27 13:06 ` Liviu Dudau
2014-02-27 13:06 ` Liviu Dudau
2014-02-27 13:22 ` Arnd Bergmann
2014-02-27 13:22 ` Arnd Bergmann
2014-02-27 13:06 ` [PATCH v2 4/4] pci: Add support for creating a generic host_bridge from device tree Liviu Dudau
2014-02-27 13:06 ` Liviu Dudau
2014-02-27 13:06 ` Liviu Dudau
2014-02-27 13:38 ` Arnd Bergmann
2014-02-27 13:38 ` Arnd Bergmann
2014-02-27 13:48 ` Arnd Bergmann
2014-02-27 13:48 ` Arnd Bergmann
2014-02-27 13:48 ` Arnd Bergmann
2014-02-27 14:13 ` Liviu Dudau
2014-02-27 15:58 ` Arnd Bergmann
2014-02-27 16:20 ` Liviu Dudau
2014-02-27 16:45 ` Arnd Bergmann
2014-02-27 16:54 ` Liviu Dudau
2014-02-27 18:42 ` Arnd Bergmann
2014-02-27 23:32 ` Benjamin Herrenschmidt
2014-02-27 23:32 ` Benjamin Herrenschmidt
2014-02-27 23:32 ` Benjamin Herrenschmidt
2014-02-28 8:46 ` Arnd Bergmann
2014-02-28 8:46 ` Arnd Bergmann
2014-02-28 9:55 ` Liviu Dudau
2014-02-28 9:55 ` Liviu Dudau
2014-03-02 1:23 ` Benjamin Herrenschmidt
2014-03-02 1:23 ` Benjamin Herrenschmidt
2014-03-02 1:23 ` Benjamin Herrenschmidt
2014-03-02 1:25 ` Benjamin Herrenschmidt
2014-03-02 1:25 ` Benjamin Herrenschmidt
2014-03-07 18:58 ` Grant Likely
2014-03-07 18:58 ` Grant Likely
2014-03-07 18:58 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227181951.GC24656@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=Catalin.Marinas@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Will.Deacon@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.