From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Markus Mayer <markus.mayer@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Markus Mayer <mmayer@broadcom.com>,
Linux GPIO List <linux-gpio@vger.kernel.org>,
ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
kernel@pengutronix.de
Subject: Re: [PATCH] gpio: only enable kona driver on BCM_MOBILE or for compile testing
Date: Fri, 28 Feb 2014 11:27:46 +0100 [thread overview]
Message-ID: <20140228102746.GN6865@pengutronix.de> (raw)
In-Reply-To: <CAPdLdqkq06AuLr8a8x9aY8BmHHbcNsL5tmQrH4j8bEom_HS-kA@mail.gmail.com>
Hello Markus,
On Thu, Feb 27, 2014 at 02:20:17PM -0800, Markus Mayer wrote:
> On 21 February 2014 05:42, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > I'm not sure if and how "Kona" fits into the bcm281xx namespace, but
> > reading through the commit logs of the changes touching
> > drivers/gpio/gpio-bcm-kona.c so far suggests it does. In this case I'd
> > consider it a good idea to mention "bcm281xx" in the help text of
> > GPIO_BCM_KONA.
>
> Naming these components has been quite a challenge for our upstreaming
> effort. Some things are not very obvious unless you know he chip or
> were involved in those discussions.
>
> "Kona" can be thought of as an architecture or a family of chips.
> bcm281xx is one member of that family. There are others. I submitted
> bcm21664 to arm-linux just a few minutes ago. bcm21664 also uses
> gpio-bcm-kona.c.
>
> Mentioning the SoCs in the help text is a good idea, but we'll likely
> have to come up with a central location where all supported members of
> the Kona family are listed, so they aren't scattered all over
> different sub-systems (Kona watchdog, Kona GPIO, Kona timer, etc.) If
> we don't have a central location, we'll be certain to forget updating
> one of the help texts eventually, and it would become inconsistent.
Fine for me, but note that this was only a side node and is orthogonal
to the patch I sent. So if you want to ack it ...
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: only enable kona driver on BCM_MOBILE or for compile testing
Date: Fri, 28 Feb 2014 11:27:46 +0100 [thread overview]
Message-ID: <20140228102746.GN6865@pengutronix.de> (raw)
In-Reply-To: <CAPdLdqkq06AuLr8a8x9aY8BmHHbcNsL5tmQrH4j8bEom_HS-kA@mail.gmail.com>
Hello Markus,
On Thu, Feb 27, 2014 at 02:20:17PM -0800, Markus Mayer wrote:
> On 21 February 2014 05:42, Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
> > I'm not sure if and how "Kona" fits into the bcm281xx namespace, but
> > reading through the commit logs of the changes touching
> > drivers/gpio/gpio-bcm-kona.c so far suggests it does. In this case I'd
> > consider it a good idea to mention "bcm281xx" in the help text of
> > GPIO_BCM_KONA.
>
> Naming these components has been quite a challenge for our upstreaming
> effort. Some things are not very obvious unless you know he chip or
> were involved in those discussions.
>
> "Kona" can be thought of as an architecture or a family of chips.
> bcm281xx is one member of that family. There are others. I submitted
> bcm21664 to arm-linux just a few minutes ago. bcm21664 also uses
> gpio-bcm-kona.c.
>
> Mentioning the SoCs in the help text is a good idea, but we'll likely
> have to come up with a central location where all supported members of
> the Kona family are listed, so they aren't scattered all over
> different sub-systems (Kona watchdog, Kona GPIO, Kona timer, etc.) If
> we don't have a central location, we'll be certain to forget updating
> one of the help texts eventually, and it would become inconsistent.
Fine for me, but note that this was only a side node and is orthogonal
to the patch I sent. So if you want to ack it ...
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-02-28 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 13:42 [PATCH] gpio: only enable kona driver on BCM_MOBILE or for compile testing Uwe Kleine-König
2014-02-21 13:42 ` Uwe Kleine-König
2014-02-27 9:16 ` Linus Walleij
2014-02-27 9:16 ` Linus Walleij
2014-02-27 22:11 ` Markus Mayer
2014-02-27 22:11 ` Markus Mayer
2014-09-24 8:06 ` Uwe Kleine-König
2014-09-24 8:06 ` Uwe Kleine-König
2014-09-25 7:51 ` Linus Walleij
2014-09-25 7:51 ` Linus Walleij
2014-02-27 22:20 ` Markus Mayer
2014-02-27 22:20 ` Markus Mayer
2014-02-28 10:27 ` Uwe Kleine-König [this message]
2014-02-28 10:27 ` Uwe Kleine-König
2014-02-28 10:59 ` Uwe Kleine-König
2014-02-28 10:59 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228102746.GN6865@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=mmayer@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.