From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Li, Aubrey" <aubrey.li@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
"alan@linux.intel.com" <alan@linux.intel.com>,
linux-kernel@vger.kernel.org, Len.Brown@intel.com,
Adam Williamson <awilliam@redhat.com>
Subject: Re: [patch] x86: Introduce BOOT_EFI and BOOT_CF9 into the reboot sequence loop
Date: Sat, 1 Mar 2014 18:19:51 +0000 [thread overview]
Message-ID: <20140301181951.GA984@srcf.ucam.org> (raw)
In-Reply-To: <53121961.2080209@linux.intel.com>
On Sun, Mar 02, 2014 at 01:31:13AM +0800, Li, Aubrey wrote:
> On 2014/3/2 1:22, Matthew Garrett wrote:
> > No. The EFI reboot call jumps into the firmware and executes code.
>
> Firmware actually writes CF9.
Your firmware writes CF9. Other firmware may hit some other addresses.
We don't know what the behaviour of that firmware will be if it takes a
fault in the process.
By and large the rule when it comes to dealing with firmware interaction
is "Copy Windows as closely as possible". Older versions of Windows
didn't appear to hit the EFI reset vector, but if they're doing it now
then we should do the same - but we should only do so once we have an
expectation that it'll work rather than dumping an oops all over
someone's screen. And, as I keep saying, the code to handle this case is
written. Let's just make sure that your code ends up behind it in the
queue.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2014-03-01 18:19 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 4:11 [patch] x86: Introduce BOOT_EFI and BOOT_CF9 into the reboot sequence loop Li, Aubrey
2014-02-28 4:56 ` Matthew Garrett
2014-02-28 5:22 ` Li, Aubrey
2014-02-28 5:56 ` Matthew Garrett
2014-02-28 6:07 ` Li, Aubrey
2014-02-28 6:12 ` Matthew Garrett
2014-02-28 6:20 ` Li, Aubrey
2014-02-28 6:23 ` Matthew Garrett
2014-02-28 6:39 ` Li, Aubrey
2014-02-28 6:44 ` Matthew Garrett
2014-02-28 6:54 ` Li, Aubrey
2014-02-28 17:47 ` H. Peter Anvin
2014-02-28 22:11 ` Li, Aubrey
2014-02-28 22:16 ` Adam Williamson
2014-03-01 17:10 ` Li, Aubrey
2014-03-01 17:22 ` Matthew Garrett
2014-03-01 17:31 ` Li, Aubrey
2014-03-01 18:19 ` Matthew Garrett [this message]
2014-03-01 19:01 ` Matthew Garrett
2014-03-02 0:15 ` Li, Aubrey
2014-03-01 20:06 ` H. Peter Anvin
2014-03-01 20:21 ` Matthew Garrett
2014-03-01 20:26 ` H. Peter Anvin
2014-03-02 0:26 ` Li, Aubrey
2014-03-02 0:33 ` H. Peter Anvin
2014-03-02 1:47 ` Li, Aubrey
2014-03-02 2:07 ` H. Peter Anvin
2014-03-02 2:20 ` Li, Aubrey
2014-03-02 2:23 ` Matthew Garrett
2014-03-02 2:35 ` H. Peter Anvin
2014-03-02 10:39 ` Li, Aubrey
2014-03-02 16:52 ` H. Peter Anvin
2014-03-02 22:13 ` Li, Aubrey
2014-03-02 22:26 ` Matthew Garrett
2014-03-02 22:45 ` Li, Aubrey
2014-03-02 23:11 ` Matthew Garrett
2014-03-02 23:23 ` Li, Aubrey
2014-03-03 0:07 ` Matthew Garrett
2014-03-03 0:18 ` H. Peter Anvin
2014-03-03 1:36 ` Li, Aubrey
2014-03-03 1:47 ` H. Peter Anvin
2014-03-03 1:49 ` Li, Aubrey
2014-03-03 22:11 ` Li, Aubrey
2014-03-02 23:57 ` H. Peter Anvin
2014-03-05 23:39 ` [tip:x86/reboot] x86, reboot: Add EFI and CF9 reboot methods into the default list tip-bot for Li, Aubrey
2014-03-05 23:45 ` [tip:x86/reboot] x86, reboot: Only use CF9_COND automatically, not CF9 tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140301181951.GA984@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Len.Brown@intel.com \
--cc=alan@linux.intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=awilliam@redhat.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.