All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: vf610-twr: Add support for sdhc1
Date: Mon, 3 Mar 2014 13:12:36 +0800	[thread overview]
Message-ID: <20140303051234.GB9706@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <1393591611-3147-1-git-send-email-cosminstefan.stoica@freescale.com>

On Fri, Feb 28, 2014 at 02:46:51PM +0200, Stoica Cosmin Stefan wrote:
> From: Cosmin Stoica <cosminstefan.stoica@freescale.com>
> 
> The kernel was not able to boot from SD card because sdhc support
> was not present into the dts.
> 
> A new entry for sdhc1 was added for vf610-twr board based on the
> compatible entry present on imx53.
> 
> After applying these changes, the kernel is able to boot successfully
> from SD card.
> 
> Signed-off-by: Cosmin Stoica <cosminstefan.stoica@freescale.com>

Use "ARM:" instead of "arm:" in patch subject please.

> ---
>  arch/arm/boot/dts/vf610-twr.dts |    7 +++++++
>  arch/arm/boot/dts/vf610.dtsi    |   10 ++++++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
> index 7dd1d6e..fa4cf48 100644
> --- a/arch/arm/boot/dts/vf610-twr.dts
> +++ b/arch/arm/boot/dts/vf610-twr.dts
> @@ -227,3 +227,10 @@
>  	pinctrl-0 = <&pinctrl_uart1>;
>  	status = "okay";
>  };
> +
> +&esdhc1 {
> +   pinctrl-names = "default";
> +   pinctrl-0 = <&pinctrl_esdhc1_1>;
> +   bus-width = <4>;
> +   status = "okay";
> +};

Sort the node alphabetically.  IOW, it should be put right before &fec0.

> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index c63d26d..516b6d2 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -344,6 +344,16 @@
>  				status = "disabled";
>  			};
>  
> +			esdhc1: esdhc at 400b2000 {
> +				   compatible = "fsl,imx53-esdhc";
> +				   reg = <0x400b2000 0x4000>;
> +				   interrupts = <0 28 0x04>;
> +				   clocks = <&clks VF610_CLK_IPG_BUS>, <&clks VF610_CLK_PLATFORM_BUS>, <&clks VF610_CLK_ESDHC1>;

The line is too long.  You can split it like:

				   clocks = <&clks VF610_CLK_IPG_BUS>,
				   	    <&clks VF610_CLK_PLATFORM_BUS>,
					    <&clks VF610_CLK_ESDHC1>;

> +				   clock-names = "ipg", "ahb", "per";
> +				   bus-width = <4>;

This property can be dropped, since you have it in board dts.

Shawn

> +				   status = "disabled";
> +			};
> +
>  			fec0: ethernet at 400d0000 {
>  				compatible = "fsl,mvf600-fec";
>  				reg = <0x400d0000 0x1000>;
> -- 
> 1.7.9.5
> 
> 

  reply	other threads:[~2014-03-03  5:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 12:46 [PATCH] arm: dts: vf610-twr: Add support for sdhc1 Stoica Cosmin Stefan
2014-03-03  5:12 ` Shawn Guo [this message]
2014-03-03 15:29 ` [PATCH v2] ARM: " Stoica Cosmin Stefan
2014-03-05  5:33   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140303051234.GB9706@shlinux1.ap.freescale.net \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.