From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kevin.z.m.zh@gmail.com,
sunny@allwinnertech.com, shuge@allwinnertech.com,
zhuzhenhua@allwinnertech.com
Subject: Re: [PATCH] i2c: mv64xxx: Fix compilation breakage
Date: Fri, 7 Mar 2014 18:19:32 +0100 [thread overview]
Message-ID: <20140307171932.GU607@lukather> (raw)
In-Reply-To: <20140307160836.GM21483@n2100.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]
On Fri, Mar 07, 2014 at 04:08:36PM +0000, Russell King - ARM Linux wrote:
> On Fri, Mar 07, 2014 at 03:59:30PM +0100, Maxime Ripard wrote:
> > @@ -900,7 +902,8 @@ mv64xxx_i2c_probe(struct platform_device *pd)
> > exit_free_irq:
> > free_irq(drv_data->irq, drv_data);
> > exit_reset:
> > - if (pd->dev.of_node && !IS_ERR(drv_data->rstc))
> > + if (pd->dev.of_node && IS_ENABLED(CONFIG_RESET_CONTROLLER) &&
> > + !IS_ERR(drv_data->rstc))
> > reset_control_assert(drv_data->rstc);
>
> Another question is... why do we need to check pd->dev.of_node here?
> If CONFIG_RESET_CONTROLLER is set, we always try to get the reset
> controller node, so drv_data->rstc is either going to be a valid
> pointer, or it's going to be an error pointer - neither
> reset_control_get() nor devm_reset_control_get return NULL.
Hmmm, right. I'll fix this in a later version.
Wolfram, do you want me to respin the patch making use of
reset_get_optional introduced by Philip in its other mail?
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: mv64xxx: Fix compilation breakage
Date: Fri, 7 Mar 2014 18:19:32 +0100 [thread overview]
Message-ID: <20140307171932.GU607@lukather> (raw)
In-Reply-To: <20140307160836.GM21483@n2100.arm.linux.org.uk>
On Fri, Mar 07, 2014 at 04:08:36PM +0000, Russell King - ARM Linux wrote:
> On Fri, Mar 07, 2014 at 03:59:30PM +0100, Maxime Ripard wrote:
> > @@ -900,7 +902,8 @@ mv64xxx_i2c_probe(struct platform_device *pd)
> > exit_free_irq:
> > free_irq(drv_data->irq, drv_data);
> > exit_reset:
> > - if (pd->dev.of_node && !IS_ERR(drv_data->rstc))
> > + if (pd->dev.of_node && IS_ENABLED(CONFIG_RESET_CONTROLLER) &&
> > + !IS_ERR(drv_data->rstc))
> > reset_control_assert(drv_data->rstc);
>
> Another question is... why do we need to check pd->dev.of_node here?
> If CONFIG_RESET_CONTROLLER is set, we always try to get the reset
> controller node, so drv_data->rstc is either going to be a valid
> pointer, or it's going to be an error pointer - neither
> reset_control_get() nor devm_reset_control_get return NULL.
Hmmm, right. I'll fix this in a later version.
Wolfram, do you want me to respin the patch making use of
reset_get_optional introduced by Philip in its other mail?
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140307/e5889c10/attachment.sig>
next prev parent reply other threads:[~2014-03-07 17:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 14:59 [PATCH] i2c: mv64xxx: Fix compilation breakage Maxime Ripard
2014-03-07 14:59 ` Maxime Ripard
2014-03-07 14:59 ` Maxime Ripard
2014-03-07 16:08 ` Russell King - ARM Linux
2014-03-07 16:08 ` Russell King - ARM Linux
2014-03-07 16:08 ` Russell King - ARM Linux
2014-03-07 17:19 ` Maxime Ripard [this message]
2014-03-07 17:19 ` Maxime Ripard
2014-03-07 17:29 ` Wolfram Sang
2014-03-07 17:29 ` Wolfram Sang
2014-03-07 17:52 ` Maxime Ripard
2014-03-07 17:52 ` Maxime Ripard
2014-03-07 17:52 ` Maxime Ripard
2014-03-10 10:58 ` Maxime Ripard
2014-03-10 10:58 ` Maxime Ripard
2014-03-10 11:29 ` Russell King - ARM Linux
2014-03-10 11:29 ` Russell King - ARM Linux
2014-03-10 11:29 ` Russell King - ARM Linux
2014-03-21 15:49 ` Paul Gortmaker
2014-03-21 15:49 ` Paul Gortmaker
2014-03-21 15:49 ` Paul Gortmaker
2014-03-21 19:17 ` Maxime Ripard
2014-03-21 19:17 ` Maxime Ripard
2014-03-22 11:11 ` Arnd Bergmann
2014-03-22 11:11 ` Arnd Bergmann
2014-03-22 11:11 ` Arnd Bergmann
2014-03-24 9:41 ` Maxime Ripard
2014-03-24 9:41 ` Maxime Ripard
2014-03-28 7:48 ` Wolfram Sang
2014-03-28 7:48 ` Wolfram Sang
2014-03-24 13:33 ` Wolfram Sang
2014-03-24 13:33 ` Wolfram Sang
2014-03-24 13:33 ` Wolfram Sang
2014-03-24 14:03 ` Gregory CLEMENT
2014-03-24 14:03 ` Gregory CLEMENT
2014-03-24 14:03 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307171932.GU607@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=kevin.z.m.zh@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=shuge@allwinnertech.com \
--cc=sunny@allwinnertech.com \
--cc=wsa@the-dreams.de \
--cc=zhuzhenhua@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.