From: Daniel Vetter <daniel@ffwll.ch>
To: Siva Chandra <sivachandra@google.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Add a DRM property "psr"
Date: Wed, 19 Mar 2014 09:44:38 +0100 [thread overview]
Message-ID: <20140319084438.GM30571@phenom.ffwll.local> (raw)
In-Reply-To: <CAGyQ6gzRPNRpCDHWLL3P6_+E52v2XjZuOfNOqrQ-=Zvc5aOPCA@mail.gmail.com>
On Tue, Mar 18, 2014 at 01:53:56PM -0700, Siva Chandra wrote:
> On Tue, Mar 18, 2014 at 1:06 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > On Tue, 18 Mar 2014 12:51:07 -0700
> > Siva Chandra <sivachandra@chromium.org> wrote:
> >
> >> This property helps one turn PSR "on" and "off" via xrandr.
> >> The default value is same as that of the module param i915.enable_psr.
> >>
> >> Signed-off-by: Siva Chandra <sivachandra@google.com>
> >> ---
> >
> > So are you using this in Chromium for disabling PSR in cases where it
> > doesn't work? Or to optimize power consumption when the kernel driver
> > gets it wrong? Or just for debug?
>
> We are testing a few PSR panels; Having a knob to turn PSR on and off
> would be of great convenience for manual testing and for test scripts.
Is the module param not good enough for that? Iirc we recheck that every
time ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-03-19 8:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 19:51 [PATCH] drm/i915: Add a DRM property "psr" Siva Chandra
2014-03-18 20:06 ` Jesse Barnes
2014-03-18 20:53 ` Siva Chandra
2014-03-19 8:44 ` Daniel Vetter [this message]
2014-03-19 15:03 ` Damien Lespiau
2014-03-19 17:04 ` Siva Chandra
2014-03-20 10:52 ` Jani Nikula
2014-03-20 13:17 ` Siva Chandra
2014-03-20 13:25 ` Jani Nikula
2014-03-20 13:31 ` Siva Chandra
2014-03-20 14:49 ` Jani Nikula
2014-03-20 15:16 ` Ville Syrjälä
2014-03-21 21:10 ` Siva Chandra
2014-03-19 15:32 ` Jani Nikula
2014-03-19 16:59 ` Siva Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319084438.GM30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.