All of lore.kernel.org
 help / color / mirror / Atom feed
From: Siva Chandra <sivachandra@google.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Add a DRM property "psr"
Date: Fri, 21 Mar 2014 14:10:15 -0700	[thread overview]
Message-ID: <CAGyQ6gx5SbjrmW-056dy3NrAboP4CKXq6uaR=sL5JHj007FOog@mail.gmail.com> (raw)
In-Reply-To: <87vbv90vt1.fsf@intel.com>

On Thu, Mar 20, 2014 at 7:49 AM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
> echo 1 > /sys/module/i915/parameters/enable_psr
> echo something > sys/kernel/debug/dri/0/i915_edp_psr_update
>
> where that debugfs file essentially calls intel_edp_psr_update() on
> update.
>
> I guess it could be i915_edp_psr_enable and echoing there would modify
> the module parameter and call update.

I am OK with this, but your last sentence is confusing. If echoing to
the debugfs file modifies the module param, why is the echo to the
module param required at all?

One last note before I stop dragging this thread: We are dealing with
few panels which support PSR but in non-standard ways. So, we will
likely use this knob for PSR control beyond just testing. While I am
OK with debugfs, I would prefer to have a more standard way. Do you
think debugfs is the best place to keep this knob?

Thanks,
Siva Chandra

  parent reply	other threads:[~2014-03-21 21:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 19:51 [PATCH] drm/i915: Add a DRM property "psr" Siva Chandra
2014-03-18 20:06 ` Jesse Barnes
2014-03-18 20:53   ` Siva Chandra
2014-03-19  8:44     ` Daniel Vetter
2014-03-19 15:03       ` Damien Lespiau
2014-03-19 17:04         ` Siva Chandra
2014-03-20 10:52           ` Jani Nikula
2014-03-20 13:17             ` Siva Chandra
2014-03-20 13:25               ` Jani Nikula
2014-03-20 13:31                 ` Siva Chandra
2014-03-20 14:49                   ` Jani Nikula
2014-03-20 15:16                     ` Ville Syrjälä
2014-03-21 21:10                     ` Siva Chandra [this message]
2014-03-19 15:32       ` Jani Nikula
2014-03-19 16:59         ` Siva Chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGyQ6gx5SbjrmW-056dy3NrAboP4CKXq6uaR=sL5JHj007FOog@mail.gmail.com' \
    --to=sivachandra@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.