[PATCH/RFC] serial_core: Fix pm imbalance on unbind

[PATCH/RFC] serial_core: Fix pm imbalance on unbind

[Geert Uytterhoeven]

From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>

When a serial port is closed, uart_close() takes care of shutting down the
hardware, and powering it down.

When a serial port is unbound while in use, uart_close() bypasses all of
this, as this is supposed to be done through uart_hangup() (invoked via
tty_vhangup() in uart_remove_one_port()).

However, uart_hangup() does not set the hardware's power state, leaving it
powered up.  This may also lead to unbounded nesting counts in clock and
power management, depending on their internal implementation.

Make sure to power down the port in uart_hangup(), except when the port is
used as a serial console. For serial consoles, this must be postponed until
after their deregistration in uart_remove_one_port() (symmetry with
registration in uart_configure_port(), invoked from uart_add_one_port()).

After this, the module clock used by the sh-sci driver is disabled on
unbind while the serial port is in use.

Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
---
 drivers/tty/serial/serial_core.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 8ece7f14d89d..a91cc2dcb66a 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1452,6 +1452,8 @@ static void uart_hangup(struct tty_struct *tty)
 		clear_bit(ASYNCB_NORMAL_ACTIVE, &port->flags);
 		spin_unlock_irqrestore(&port->lock, flags);
 		tty_port_tty_set(port, NULL);
+		if (!uart_console(state->uart_port))
+			uart_change_pm(state, UART_PM_STATE_OFF);
 		wake_up_interruptible(&port->open_wait);
 		wake_up_interruptible(&port->delta_msr_wait);
 	}
@@ -2677,10 +2679,12 @@ int uart_remove_one_port(struct uart_driver *drv, struct uart_port *uport)
 		tty_vhangup(port->tty);
 
 	/*
-	 * If the port is used as a console, unregister it
+	 * If the port is used as a console, unregister it, and power it down
 	 */
-	if (uart_console(uport))
+	if (uart_console(uport)) {
 		unregister_console(uport->cons);
+		uart_change_pm(state, UART_PM_STATE_OFF);
+	}
 
 	/*
 	 * Free the port IO and memory resources, if any.
-- 
1.7.9.5

[PATCH/RFC] serial_core: Fix pm imbalance on unbind

[Geert Uytterhoeven]

From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>

When a serial port is closed, uart_close() takes care of shutting down the
hardware, and powering it down.

When a serial port is unbound while in use, uart_close() bypasses all of
this, as this is supposed to be done through uart_hangup() (invoked via
tty_vhangup() in uart_remove_one_port()).

However, uart_hangup() does not set the hardware's power state, leaving it
powered up.  This may also lead to unbounded nesting counts in clock and
power management, depending on their internal implementation.

Make sure to power down the port in uart_hangup(), except when the port is
used as a serial console. For serial consoles, this must be postponed until
after their deregistration in uart_remove_one_port() (symmetry with
registration in uart_configure_port(), invoked from uart_add_one_port()).

After this, the module clock used by the sh-sci driver is disabled on
unbind while the serial port is in use.

Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
---
 drivers/tty/serial/serial_core.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 8ece7f14d89d..a91cc2dcb66a 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1452,6 +1452,8 @@ static void uart_hangup(struct tty_struct *tty)
 		clear_bit(ASYNCB_NORMAL_ACTIVE, &port->flags);
 		spin_unlock_irqrestore(&port->lock, flags);
 		tty_port_tty_set(port, NULL);
+		if (!uart_console(state->uart_port))
+			uart_change_pm(state, UART_PM_STATE_OFF);
 		wake_up_interruptible(&port->open_wait);
 		wake_up_interruptible(&port->delta_msr_wait);
 	}
@@ -2677,10 +2679,12 @@ int uart_remove_one_port(struct uart_driver *drv, struct uart_port *uport)
 		tty_vhangup(port->tty);
 
 	/*
-	 * If the port is used as a console, unregister it
+	 * If the port is used as a console, unregister it, and power it down
 	 */
-	if (uart_console(uport))
+	if (uart_console(uport)) {
 		unregister_console(uport->cons);
+		uart_change_pm(state, UART_PM_STATE_OFF);
+	}
 
 	/*
 	 * Free the port IO and memory resources, if any.
-- 
1.7.9.5

Re: [PATCH/RFC] serial_core: Fix pm imbalance on unbind

[Geert Uytterhoeven]

Hi Greg,

On Mon, Mar 10, 2014 at 8:54 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> When a serial port is closed, uart_close() takes care of shutting down the
> hardware, and powering it down.
>
> When a serial port is unbound while in use, uart_close() bypasses all of
> this, as this is supposed to be done through uart_hangup() (invoked via
> tty_vhangup() in uart_remove_one_port()).
>
> However, uart_hangup() does not set the hardware's power state, leaving it
> powered up.  This may also lead to unbounded nesting counts in clock and
> power management, depending on their internal implementation.
>
> Make sure to power down the port in uart_hangup(), except when the port is
> used as a serial console. For serial consoles, this must be postponed until
> after their deregistration in uart_remove_one_port() (symmetry with
> registration in uart_configure_port(), invoked from uart_add_one_port()).
>
> After this, the module clock used by the sh-sci driver is disabled on
> unbind while the serial port is in use.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>

I noticed you have applied all serial patches I've sent, except for this one.
Is there any specific reason you skipped this one?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH/RFC] serial_core: Fix pm imbalance on unbind

[Geert Uytterhoeven]

Hi Greg,

On Mon, Mar 10, 2014 at 8:54 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> When a serial port is closed, uart_close() takes care of shutting down the
> hardware, and powering it down.
>
> When a serial port is unbound while in use, uart_close() bypasses all of
> this, as this is supposed to be done through uart_hangup() (invoked via
> tty_vhangup() in uart_remove_one_port()).
>
> However, uart_hangup() does not set the hardware's power state, leaving it
> powered up.  This may also lead to unbounded nesting counts in clock and
> power management, depending on their internal implementation.
>
> Make sure to power down the port in uart_hangup(), except when the port is
> used as a serial console. For serial consoles, this must be postponed until
> after their deregistration in uart_remove_one_port() (symmetry with
> registration in uart_configure_port(), invoked from uart_add_one_port()).
>
> After this, the module clock used by the sh-sci driver is disabled on
> unbind while the serial port is in use.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>

I noticed you have applied all serial patches I've sent, except for this one.
Is there any specific reason you skipped this one?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH/RFC] serial_core: Fix pm imbalance on unbind

[Greg Kroah-Hartman]

On Thu, Mar 20, 2014 at 11:23:00AM +0100, Geert Uytterhoeven wrote:
> Hi Greg,
> 
> On Mon, Mar 10, 2014 at 8:54 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> >
> > When a serial port is closed, uart_close() takes care of shutting down the
> > hardware, and powering it down.
> >
> > When a serial port is unbound while in use, uart_close() bypasses all of
> > this, as this is supposed to be done through uart_hangup() (invoked via
> > tty_vhangup() in uart_remove_one_port()).
> >
> > However, uart_hangup() does not set the hardware's power state, leaving it
> > powered up.  This may also lead to unbounded nesting counts in clock and
> > power management, depending on their internal implementation.
> >
> > Make sure to power down the port in uart_hangup(), except when the port is
> > used as a serial console. For serial consoles, this must be postponed until
> > after their deregistration in uart_remove_one_port() (symmetry with
> > registration in uart_configure_port(), invoked from uart_add_one_port()).
> >
> > After this, the module clock used by the sh-sci driver is disabled on
> > unbind while the serial port is in use.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> 
> I noticed you have applied all serial patches I've sent, except for this one.
> Is there any specific reason you skipped this one?

It was marked "RFC" so I didn't think it was to be applied...

If it's ready, please resend.

thanks,

greg k-h

Re: [PATCH/RFC] serial_core: Fix pm imbalance on unbind

[Greg Kroah-Hartman]

On Thu, Mar 20, 2014 at 11:23:00AM +0100, Geert Uytterhoeven wrote:
> Hi Greg,
> 
> On Mon, Mar 10, 2014 at 8:54 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> >
> > When a serial port is closed, uart_close() takes care of shutting down the
> > hardware, and powering it down.
> >
> > When a serial port is unbound while in use, uart_close() bypasses all of
> > this, as this is supposed to be done through uart_hangup() (invoked via
> > tty_vhangup() in uart_remove_one_port()).
> >
> > However, uart_hangup() does not set the hardware's power state, leaving it
> > powered up.  This may also lead to unbounded nesting counts in clock and
> > power management, depending on their internal implementation.
> >
> > Make sure to power down the port in uart_hangup(), except when the port is
> > used as a serial console. For serial consoles, this must be postponed until
> > after their deregistration in uart_remove_one_port() (symmetry with
> > registration in uart_configure_port(), invoked from uart_add_one_port()).
> >
> > After this, the module clock used by the sh-sci driver is disabled on
> > unbind while the serial port is in use.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> 
> I noticed you have applied all serial patches I've sent, except for this one.
> Is there any specific reason you skipped this one?

It was marked "RFC" so I didn't think it was to be applied...

If it's ready, please resend.

thanks,

greg k-h