[PATCH 3.13] regulator: core: Change dummy supplies error message to a warning

[PATCH 3.13] regulator: core: Change dummy supplies error message to a warning

[Shuah Khan]

Change "dummy supplies not allowed" error message to warning instead,
as this is a just warning message with no change to the behavior.

upstream commit acc3d5cec84f82ebea535fa0bd9500ac3df2aee9

Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
---

Back porting as the original patch tagged for stable failed to apply.
Included Mark Brown's Signed-off from the original commit. This change
is not applicable to 3.12 and earlier.

 drivers/regulator/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 0186c1b..804521a 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
 		rdev = dummy_regulator_rdev;
 		goto found;
 	} else {
-		dev_err(dev, "dummy supplies not allowed\n");
+		dev_warn(dev, "dummy supplies not allowed\n");
 	}
 
 	mutex_unlock(&regulator_list_mutex);
-- 
1.7.10.4

Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning

[Joe Perches]

On Wed, 2014-03-05 at 14:29 -0700, Shuah Khan wrote:
> Change "dummy supplies not allowed" error message to warning instead,
> as this is a just warning message with no change to the behavior.
[]
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
[]
> @@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
>  		rdev = dummy_regulator_rdev;
>  		goto found;
>  	} else {
> -		dev_err(dev, "dummy supplies not allowed\n");
> +		dev_warn(dev, "dummy supplies not allowed\n");

What does this mean anyway?

Would it be better to emit the calling function too with
%pf, __builtin_return_address(0)?

Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning

[Shuah Khan]

On 03/05/2014 03:00 PM, Joe Perches wrote:
> On Wed, 2014-03-05 at 14:29 -0700, Shuah Khan wrote:
>> Change "dummy supplies not allowed" error message to warning instead,
>> as this is a just warning message with no change to the behavior.
> []
>> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> []
>> @@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
>>   		rdev = dummy_regulator_rdev;
>>   		goto found;
>>   	} else {
>> -		dev_err(dev, "dummy supplies not allowed\n");
>> +		dev_warn(dev, "dummy supplies not allowed\n");
>
> What does this mean anyway?
>
> Would it be better to emit the calling function too with
> %pf, __builtin_return_address(0)?
>

Maybe. In that case, that change has to first go into the mainline. This 
is a back port of an upstream commit to get rid of a regression in error 
messages.

-- Shuah

-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658

Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning

[Greg KH]

On Wed, Mar 05, 2014 at 02:29:47PM -0700, Shuah Khan wrote:
> Change "dummy supplies not allowed" error message to warning instead,
> as this is a just warning message with no change to the behavior.
> 
> upstream commit acc3d5cec84f82ebea535fa0bd9500ac3df2aee9
> 
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> 
> Back porting as the original patch tagged for stable failed to apply.
> Included Mark Brown's Signed-off from the original commit. This change
> is not applicable to 3.12 and earlier.
> 
>  drivers/regulator/core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 0186c1b..804521a 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
>  		rdev = dummy_regulator_rdev;
>  		goto found;
>  	} else {
> -		dev_err(dev, "dummy supplies not allowed\n");
> +		dev_warn(dev, "dummy supplies not allowed\n");

This really isn't a problem that warrents a stable backport, sorry.  I
can understand distros being "annoyed" at it, but probably not.

greg k-h

Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

On Wed, Mar 19, 2014 at 11:58:28PM +0000, Greg KH wrote:
> On Wed, Mar 05, 2014 at 02:29:47PM -0700, Shuah Khan wrote:

> > -		dev_err(dev, "dummy supplies not allowed\n");
> > +		dev_warn(dev, "dummy supplies not allowed\n");

> This really isn't a problem that warrents a stable backport, sorry.  I
> can understand distros being "annoyed" at it, but probably not.

A previous stable commit caused this to happen for esentially every
regulator request on x86 when previously it wouldn't have triggered.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning

[Greg KH]

On Thu, Mar 20, 2014 at 10:02:41AM +0000, Mark Brown wrote:
> On Wed, Mar 19, 2014 at 11:58:28PM +0000, Greg KH wrote:
> > On Wed, Mar 05, 2014 at 02:29:47PM -0700, Shuah Khan wrote:
> 
> > > -		dev_err(dev, "dummy supplies not allowed\n");
> > > +		dev_warn(dev, "dummy supplies not allowed\n");
> 
> > This really isn't a problem that warrents a stable backport, sorry.  I
> > can understand distros being "annoyed" at it, but probably not.
> 
> A previous stable commit caused this to happen for esentially every
> regulator request on x86 when previously it wouldn't have triggered.

Ick, ok, fair enough, I'll queue it up, thanks.

greg k-h