* [PATCH] drm/i915: release mutex in i915_gem_init()'s error path
@ 2014-01-31 15:14 Mika Kuoppala
2014-02-04 11:11 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Mika Kuoppala @ 2014-01-31 15:14 UTC (permalink / raw)
To: intel-gfx
Found with smatch.
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 08331e1..feedef9 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4536,8 +4536,10 @@ int i915_gem_init(struct drm_device *dev)
i915_gem_init_global_gtt(dev);
ret = i915_gem_context_init(dev);
- if (ret)
+ if (ret) {
+ mutex_unlock(&dev->struct_mutex);
return ret;
+ }
ret = i915_gem_init_hw(dev);
mutex_unlock(&dev->struct_mutex);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: release mutex in i915_gem_init()'s error path
2014-01-31 15:14 [PATCH] drm/i915: release mutex in i915_gem_init()'s error path Mika Kuoppala
@ 2014-02-04 11:11 ` Daniel Vetter
2014-03-21 18:39 ` Ben Widawsky
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2014-02-04 11:11 UTC (permalink / raw)
To: Mika Kuoppala; +Cc: intel-gfx
On Fri, Jan 31, 2014 at 05:14:02PM +0200, Mika Kuoppala wrote:
> Found with smatch.
>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
Both smatch patches merged to dinq, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: release mutex in i915_gem_init()'s error path
2014-02-04 11:11 ` Daniel Vetter
@ 2014-03-21 18:39 ` Ben Widawsky
2014-03-21 19:27 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Ben Widawsky @ 2014-03-21 18:39 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
On Tue, Feb 04, 2014 at 12:11:03PM +0100, Daniel Vetter wrote:
> On Fri, Jan 31, 2014 at 05:14:02PM +0200, Mika Kuoppala wrote:
> > Found with smatch.
> >
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Both smatch patches merged to dinq, thanks.
> -Daniel
CC stable?
--
Ben Widawsky, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: release mutex in i915_gem_init()'s error path
2014-03-21 18:39 ` Ben Widawsky
@ 2014-03-21 19:27 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2014-03-21 19:27 UTC (permalink / raw)
To: Ben Widawsky; +Cc: intel-gfx
On Fri, Mar 21, 2014 at 11:39:55AM -0700, Ben Widawsky wrote:
> On Tue, Feb 04, 2014 at 12:11:03PM +0100, Daniel Vetter wrote:
> > On Fri, Jan 31, 2014 at 05:14:02PM +0200, Mika Kuoppala wrote:
> > > Found with smatch.
> > >
> > > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> >
> > Both smatch patches merged to dinq, thanks.
> > -Daniel
>
> CC stable?
Init tends to rarely blow up, so without a report that this is possible in
the wild, nope. Quoting stable kernel rules:
- It must fix a real bug that bothers people (not a, "This could be a
problem..." type thing).
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-21 19:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-31 15:14 [PATCH] drm/i915: release mutex in i915_gem_init()'s error path Mika Kuoppala
2014-02-04 11:11 ` Daniel Vetter
2014-03-21 18:39 ` Ben Widawsky
2014-03-21 19:27 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.