All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Laura Abbott <lauraa@codeaurora.org>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Tony Luck <tony.luck@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	x86@kernel.org, Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux-kernel@vger.kernel.org, linux390@de.ibm.com,
	sparclinux@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-ia64@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig
Date: Sat, 22 Mar 2014 22:23:06 +0000	[thread overview]
Message-ID: <20140322222306.GM7528@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1395523881.2143.58.camel@dabdike.int.hansenpartnership.com>

On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote:
> Perhaps now might be the time to ask which are the remaining
> architectures that cannot do SG chaining and then we can fix them and
> pull the whole thing out.

Not quite.  You're making the assumption that we can be sure that all
the scatterlist users on an architecture have been converted - that's
simply not true on ARM.  We have some which have, and some which still
have not been audited.

The cases that get us here would be old platform DMA code which walks
scatterlists handed to it from drivers - stuff like
arch/arm/mach-rpc/dma.c (which probably can cope), and drivers/scsi/arm/*
(which definitely can't because of their SCSI pointers save/restore
handling message.)  I know that's one case where SG_CHAIN definitely
isn't supported on ARM.

So, we had decided not to enable it, but this means that new stuff
isn't benefitting from this.  I've recently asked arm-soc to enable
it for the modern multi-platform builds, because modern stuff really
be written with correct SG chaining in mind.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig
Date: Sat, 22 Mar 2014 22:23:06 +0000	[thread overview]
Message-ID: <20140322222306.GM7528@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1395523881.2143.58.camel@dabdike.int.hansenpartnership.com>

On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote:
> Perhaps now might be the time to ask which are the remaining
> architectures that cannot do SG chaining and then we can fix them and
> pull the whole thing out.

Not quite.  You're making the assumption that we can be sure that all
the scatterlist users on an architecture have been converted - that's
simply not true on ARM.  We have some which have, and some which still
have not been audited.

The cases that get us here would be old platform DMA code which walks
scatterlists handed to it from drivers - stuff like
arch/arm/mach-rpc/dma.c (which probably can cope), and drivers/scsi/arm/*
(which definitely can't because of their SCSI pointers save/restore
handling message.)  I know that's one case where SG_CHAIN definitely
isn't supported on ARM.

So, we had decided not to enable it, but this means that new stuff
isn't benefitting from this.  I've recently asked arm-soc to enable
it for the modern multi-platform builds, because modern stuff really
be written with correct SG chaining in mind.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	Laura Abbott <lauraa@codeaurora.org>,
	linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
	x86@kernel.org, Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	sparclinux@vger.kernel.org, linux390@de.ibm.com,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig
Date: Sat, 22 Mar 2014 22:23:06 +0000	[thread overview]
Message-ID: <20140322222306.GM7528@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1395523881.2143.58.camel@dabdike.int.hansenpartnership.com>

On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote:
> Perhaps now might be the time to ask which are the remaining
> architectures that cannot do SG chaining and then we can fix them and
> pull the whole thing out.

Not quite.  You're making the assumption that we can be sure that all
the scatterlist users on an architecture have been converted - that's
simply not true on ARM.  We have some which have, and some which still
have not been audited.

The cases that get us here would be old platform DMA code which walks
scatterlists handed to it from drivers - stuff like
arch/arm/mach-rpc/dma.c (which probably can cope), and drivers/scsi/arm/*
(which definitely can't because of their SCSI pointers save/restore
handling message.)  I know that's one case where SG_CHAIN definitely
isn't supported on ARM.

So, we had decided not to enable it, but this means that new stuff
isn't benefitting from this.  I've recently asked arm-soc to enable
it for the modern multi-platform builds, because modern stuff really
be written with correct SG chaining in mind.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig
Date: Sat, 22 Mar 2014 22:23:06 +0000	[thread overview]
Message-ID: <20140322222306.GM7528@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1395523881.2143.58.camel@dabdike.int.hansenpartnership.com>

On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote:
> Perhaps now might be the time to ask which are the remaining
> architectures that cannot do SG chaining and then we can fix them and
> pull the whole thing out.

Not quite.  You're making the assumption that we can be sure that all
the scatterlist users on an architecture have been converted - that's
simply not true on ARM.  We have some which have, and some which still
have not been audited.

The cases that get us here would be old platform DMA code which walks
scatterlists handed to it from drivers - stuff like
arch/arm/mach-rpc/dma.c (which probably can cope), and drivers/scsi/arm/*
(which definitely can't because of their SCSI pointers save/restore
handling message.)  I know that's one case where SG_CHAIN definitely
isn't supported on ARM.

So, we had decided not to enable it, but this means that new stuff
isn't benefitting from this.  I've recently asked arm-soc to enable
it for the modern multi-platform builds, because modern stuff really
be written with correct SG chaining in mind.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

  parent reply	other threads:[~2014-03-22 22:24 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-22 18:13 [RESEND][PATCH 0/2] Cleanup asm/scatterlist.h Laura Abbott
2014-03-22 18:13 ` Laura Abbott
2014-03-22 18:13 ` Laura Abbott
2014-03-22 18:13 ` Laura Abbott
2014-03-22 18:13 ` Laura Abbott
2014-03-22 18:13 ` [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig Laura Abbott
2014-03-22 18:13   ` Laura Abbott
2014-03-22 18:13   ` Laura Abbott
2014-03-22 18:13   ` Laura Abbott
2014-03-22 18:13   ` Laura Abbott
2014-03-22 20:44   ` Thomas Gleixner
2014-03-22 20:44     ` Thomas Gleixner
2014-03-22 20:44     ` Thomas Gleixner
2014-03-22 20:44     ` Thomas Gleixner
2014-03-22 20:44     ` Thomas Gleixner
2014-03-22 21:31   ` James Bottomley
2014-03-22 21:31     ` James Bottomley
2014-03-22 21:31     ` James Bottomley
2014-03-22 21:31     ` James Bottomley
2014-03-22 21:31     ` James Bottomley
2014-03-22 21:31     ` James Bottomley
2014-03-22 22:03     ` Thomas Gleixner
2014-03-22 22:03       ` Thomas Gleixner
2014-03-22 22:03       ` Thomas Gleixner
2014-03-22 22:03       ` Thomas Gleixner
2014-03-22 22:03       ` Thomas Gleixner
2014-03-22 22:23     ` Russell King - ARM Linux [this message]
2014-03-22 22:23       ` Russell King - ARM Linux
2014-03-22 22:23       ` Russell King - ARM Linux
2014-03-22 22:23       ` Russell King - ARM Linux
2014-03-22 22:37       ` James Bottomley
2014-03-22 22:37         ` James Bottomley
2014-03-22 22:37         ` James Bottomley
2014-03-22 22:37         ` James Bottomley
2014-03-22 22:37         ` James Bottomley
2014-03-22 22:52         ` Russell King - ARM Linux
2014-03-22 22:52           ` Russell King - ARM Linux
2014-03-22 22:52           ` Russell King - ARM Linux
2014-03-22 22:52           ` Russell King - ARM Linux
2014-03-22 22:59           ` James Bottomley
2014-03-22 22:59             ` James Bottomley
2014-03-22 22:59             ` James Bottomley
2014-03-22 22:59             ` James Bottomley
2014-03-22 22:59             ` James Bottomley
2014-03-24 10:45             ` Russell King - ARM Linux
2014-03-24 10:45               ` Russell King - ARM Linux
2014-03-24 10:45               ` Russell King - ARM Linux
2014-03-24 10:45               ` Russell King - ARM Linux
2014-03-23  3:04   ` Benjamin Herrenschmidt
2014-03-23  3:04     ` Benjamin Herrenschmidt
2014-03-23  3:04     ` Benjamin Herrenschmidt
2014-03-23  3:04     ` Benjamin Herrenschmidt
2014-03-23  3:04     ` Benjamin Herrenschmidt
2014-03-23  7:03     ` Christoph Hellwig
2014-03-23  7:03       ` Christoph Hellwig
2014-03-23  7:03       ` Christoph Hellwig
2014-03-23  7:03       ` Christoph Hellwig
2014-03-23  7:03       ` Christoph Hellwig
2014-03-23  8:58       ` Benjamin Herrenschmidt
2014-03-23  8:58         ` Benjamin Herrenschmidt
2014-03-23  8:58         ` Benjamin Herrenschmidt
2014-03-23  8:58         ` Benjamin Herrenschmidt
2014-03-23  8:58         ` Benjamin Herrenschmidt
2014-03-23  3:06   ` Benjamin Herrenschmidt
2014-03-23  3:06     ` Benjamin Herrenschmidt
2014-03-23  3:06     ` Benjamin Herrenschmidt
2014-03-23  3:06     ` Benjamin Herrenschmidt
2014-03-23  3:06     ` Benjamin Herrenschmidt
2014-03-24  5:47   ` Heiko Carstens
2014-03-24  5:47     ` Heiko Carstens
2014-03-24  5:47     ` Heiko Carstens
2014-03-24  5:47     ` Heiko Carstens
2014-03-24  5:47     ` Heiko Carstens
2014-03-24  5:47     ` Heiko Carstens
2014-03-22 18:13 ` [RESEND][PATCH 2/2] Cleanup useless architecture versions of scatterlist.h Laura Abbott
2014-03-28 22:14 ` [RESEND][PATCH 0/2] Cleanup asm/scatterlist.h Andrew Morton
2014-03-28 22:14   ` Andrew Morton
2014-03-28 22:14   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140322222306.GM7528@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=fenghua.yu@intel.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=lauraa@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux390@de.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.