[U-Boot] [PATCH] we don't went version control for .cmd files

[U-Boot] [PATCH] we don't went version control for .cmd files

[Pavel Machek]

commit 5acba11ad70ba7eeb8cc82e7dd77871f022964dd
Author: Pavel Machek <pavel@denx.de>
Date:   Sat Mar 22 20:09:49 2014 +0100

.cmd files should not be version-controlled.
    
Signed-off-by: Pavel Machek <pavel@denx.de>

diff --git a/.gitignore b/.gitignore
index a163728..77fb2c8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -15,6 +15,7 @@
 *.swp
 *.patch
 *.bin
+*.cmd
 
 # Build tree
 /build-*

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] [PATCH] we don't went version control for .cmd files

[Masahiro Yamada]

Hi Pavel,


> .cmd files should not be version-controlled.
>     
> Signed-off-by: Pavel Machek <pavel@denx.de>
> 
> diff --git a/.gitignore b/.gitignore
> index a163728..77fb2c8 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -15,6 +15,7 @@
>  *.swp
>  *.patch
>  *.bin
> +*.cmd
>  
>  # Build tree
>  /build-*


Which files do you need this patch for?
Could you give me an example, please?


Best Regards
Masahiro Yamada

[U-Boot] [PATCH] we don't went version control for .cmd files

[Pavel Machek]

Hi!

> > .cmd files should not be version-controlled.
> >     
> > Signed-off-by: Pavel Machek <pavel@denx.de>
> > 
> > diff --git a/.gitignore b/.gitignore
> > index a163728..77fb2c8 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -15,6 +15,7 @@
> >  *.swp
> >  *.patch
> >  *.bin
> > +*.cmd
> >  
> >  # Build tree
> >  /build-*
> 
> 
> Which files do you need this patch for?
> Could you give me an example, please?

My build leaves files such as

./common/.fdt_support.o.cmd
./common/.console.o.cmd
./common/.main.o.cmd
./common/.cmd_load.o.cmd
./common/.flash.o.cmd
./common/.env_flags.o.cmd
./common/.cmd_source.o.cmd
./common/.built-in.o.cmd

. Git usage would be slightly nicer if those were ignored. My u-boot
is based on v2013.01.01... hmm. I expected Altera to have slightly
newer version. That may explain stuff.

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] [PATCH] we don't went version control for .cmd files

[Masahiro Yamada]

Hi Pavel,

On Mon, 24 Mar 2014 10:29:56 +0100
Pavel Machek <pavel@denx.de> wrote:

> Hi!
> 
> > > .cmd files should not be version-controlled.
> > >     
> > > Signed-off-by: Pavel Machek <pavel@denx.de>
> > > 
> > > diff --git a/.gitignore b/.gitignore
> > > index a163728..77fb2c8 100644
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > @@ -15,6 +15,7 @@
> > >  *.swp
> > >  *.patch
> > >  *.bin
> > > +*.cmd
> > >  
> > >  # Build tree
> > >  /build-*
> > 
> > 
> > Which files do you need this patch for?
> > Could you give me an example, please?
> 
> My build leaves files such as
> 
> ./common/.fdt_support.o.cmd
> ./common/.console.o.cmd
> ./common/.main.o.cmd
> ./common/.cmd_load.o.cmd
> ./common/.flash.o.cmd
> ./common/.env_flags.o.cmd
> ./common/.cmd_source.o.cmd
> ./common/.built-in.o.cmd
> 
> . Git usage would be slightly nicer if those were ignored. My u-boot
> is based on v2013.01.01... hmm. I expected Altera to have slightly
> newer version. That may explain stuff.

.*.cmd files were introduced by Kbuild at v2014.04-rc1
and correctly ignored.
v2013.01.01 you are using has nothing to do with Kbuild.

I guess you built at u-boot/master (.*.cmd files were generated)
and then you checked out v2013.01.01.

And one more thing.
Your patch is not applicable at all.
Please do not post a patch based on such an old tag.

Not Acked by Masahiro Yamada



Best Regards
Masahiro Yamada

[U-Boot] [PATCH] we don't went version control for .cmd files

[Pavel Machek]

Hi!

> > My build leaves files such as
> > 
> > ./common/.fdt_support.o.cmd
> > ./common/.console.o.cmd
> > ./common/.main.o.cmd
> > ./common/.cmd_load.o.cmd
> > ./common/.flash.o.cmd
> > ./common/.env_flags.o.cmd
> > ./common/.cmd_source.o.cmd
> > ./common/.built-in.o.cmd
> > 
> > . Git usage would be slightly nicer if those were ignored. My u-boot
> > is based on v2013.01.01... hmm. I expected Altera to have slightly
> > newer version. That may explain stuff.
> 
> .*.cmd files were introduced by Kbuild at v2014.04-rc1
> and correctly ignored.
> v2013.01.01 you are using has nothing to do with Kbuild.
> 
> I guess you built at u-boot/master (.*.cmd files were generated)
> and then you checked out v2013.01.01.

Yes, I guess that's what happened.

> And one more thing.
> Your patch is not applicable at all.
> Please do not post a patch based on such an old tag.

Sorry for the noise,
							Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html