From: Mike Turquette <mturquette@linaro.org>
To: Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, linux@arm.linux.org.uk,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: "Lee Jones" <lee.jones@linaro.org>,
"Gabriel Fernandez" <gabriel.fernandez@st.com>,
"Pankaj Dev" <pankaj.dev@st.com>
Subject: Re: [PATCH v0 01/15] drivers: clk: st: Support for DIVMUX and PreDiv Clocks
Date: Mon, 24 Mar 2014 22:27:25 -0700 [thread overview]
Message-ID: <20140325052725.32624.39974@quantum> (raw)
In-Reply-To: <1393514668-17440-2-git-send-email-gabriel.fernandez@st.com>
Quoting Gabriel FERNANDEZ (2014-02-27 07:24:14)
> +/**
> + * DOC: Clock mux with a programmable divider on each of its three inputs.
> + * The mux has an input setting which effectively gates its output.
> + *
> + * Traits of this clock:
> + * prepare - clk_(un)prepare only ensures parent is (un)prepared
Minor nitpick but it doesn't look like .prepare or .unprepare are
supported below. It looks like this copy/paste comment applies to most
of the clk patches as well.
It's a small problem and doesn't require a patch respin. But perhaps can
be cleaned up some day in the future.
Do you want me to take these patches directly or are you just looking
for an Ack?
Regards,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, linux@arm.linux.org.uk,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Lee Jones <lee.jones@linaro.org>,
Gabriel Fernandez <gabriel.fernandez@st.com>,
Pankaj Dev <pankaj.dev@st.com>
Subject: Re: [PATCH v0 01/15] drivers: clk: st: Support for DIVMUX and PreDiv Clocks
Date: Mon, 24 Mar 2014 22:27:25 -0700 [thread overview]
Message-ID: <20140325052725.32624.39974@quantum> (raw)
In-Reply-To: <1393514668-17440-2-git-send-email-gabriel.fernandez@st.com>
Quoting Gabriel FERNANDEZ (2014-02-27 07:24:14)
> +/**
> + * DOC: Clock mux with a programmable divider on each of its three inputs.
> + * The mux has an input setting which effectively gates its output.
> + *
> + * Traits of this clock:
> + * prepare - clk_(un)prepare only ensures parent is (un)prepared
Minor nitpick but it doesn't look like .prepare or .unprepare are
supported below. It looks like this copy/paste comment applies to most
of the clk patches as well.
It's a small problem and doesn't require a patch respin. But perhaps can
be cleaned up some day in the future.
Do you want me to take these patches directly or are you just looking
for an Ack?
Regards,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v0 01/15] drivers: clk: st: Support for DIVMUX and PreDiv Clocks
Date: Mon, 24 Mar 2014 22:27:25 -0700 [thread overview]
Message-ID: <20140325052725.32624.39974@quantum> (raw)
In-Reply-To: <1393514668-17440-2-git-send-email-gabriel.fernandez@st.com>
Quoting Gabriel FERNANDEZ (2014-02-27 07:24:14)
> +/**
> + * DOC: Clock mux with a programmable divider on each of its three inputs.
> + * The mux has an input setting which effectively gates its output.
> + *
> + * Traits of this clock:
> + * prepare - clk_(un)prepare only ensures parent is (un)prepared
Minor nitpick but it doesn't look like .prepare or .unprepare are
supported below. It looks like this copy/paste comment applies to most
of the clk patches as well.
It's a small problem and doesn't require a patch respin. But perhaps can
be cleaned up some day in the future.
Do you want me to take these patches directly or are you just looking
for an Ack?
Regards,
Mike
next prev parent reply other threads:[~2014-03-25 5:27 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 15:24 [PATCH v0 00/15] clk: st: Add new driver Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 01/15] drivers: clk: st: Support for DIVMUX and PreDiv Clocks Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-03-25 5:27 ` Mike Turquette [this message]
2014-03-25 5:27 ` Mike Turquette
2014-03-25 5:27 ` Mike Turquette
2014-03-25 8:28 ` Gabriel Fernandez
2014-03-25 8:28 ` Gabriel Fernandez
2014-03-25 8:28 ` Gabriel Fernandez
2014-03-25 22:59 ` Mike Turquette
2014-03-25 22:59 ` Mike Turquette
2014-02-27 15:24 ` [PATCH v0 02/15] drivers: clk: st: Support for PLLs inside ClockGenA(s) Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 03/15] drivers: clk: st: Support for VCC-mux and MUX clocks Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 04/15] drivers: clk: st: Support for QUADFS inside ClockGenB/C/D/E/F Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 05/15] drivers: clk: st: Support for ClockGenA9/DDR/GPU Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 06/15] drivers: clk: st: Support for A9 MUX clocks Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 07/15] clk: st: Adds divmux and prediv clock binding Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 08/15] clk: st: Adds clockgen " Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 09/15] clk: st: Adds clockgen-vcc and clockgen-mux " Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 10/15] clk: st: Adds quadfs " Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 11/15] ARM: STi: DT: STiH416: 416 DT Entry for clockgen A0/1/10/11/12 Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 12/15] ARM: STi: DT: STiH416: 416 DT Entry for clockgen B/C/D/E/F Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 16:36 ` Lee Jones
2014-02-27 16:36 ` Lee Jones
2014-02-28 13:53 ` Gabriel Fernandez
2014-02-27 15:24 ` [PATCH v0 13/15] ARM: STi: DT: STiH416: 416 DT Entry for clockgen A9/DDR/GPU Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 14/15] ARM: STi: DT: STiH415: 415 DT Entry for clockgen A0/1/10/11/12 Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
2014-02-27 15:24 ` [PATCH v0 15/15] ARM: STi: DT: STiH415: 415 DT Entry for clockgen A9 Gabriel FERNANDEZ
2014-02-27 15:24 ` Gabriel FERNANDEZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325052725.32624.39974@quantum \
--to=mturquette@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gabriel.fernandez@st.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pankaj.dev@st.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.