* [patch] xfs: extra semi-colon breaks a condition
@ 2014-03-28 8:03 ` Dan Carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2014-03-28 8:03 UTC (permalink / raw)
To: Dave Chinner; +Cc: kernel-janitors, xfs
There were some extra semi-colons here which mean that we return true
unintentionally.
Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 98016b3..75df77d 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -659,10 +659,10 @@ xfs_check_page_type(
if (type == XFS_IO_UNWRITTEN)
return true;
} else if (buffer_delay(bh)) {
- if (type == XFS_IO_DELALLOC);
+ if (type == XFS_IO_DELALLOC)
return true;
} else if (buffer_dirty(bh) && buffer_mapped(bh)) {
- if (type == XFS_IO_OVERWRITE);
+ if (type == XFS_IO_OVERWRITE)
return true;
}
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [patch] xfs: extra semi-colon breaks a condition
@ 2014-03-28 8:03 ` Dan Carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2014-03-28 8:03 UTC (permalink / raw)
To: Dave Chinner; +Cc: kernel-janitors, xfs
There were some extra semi-colons here which mean that we return true
unintentionally.
Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 98016b3..75df77d 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -659,10 +659,10 @@ xfs_check_page_type(
if (type = XFS_IO_UNWRITTEN)
return true;
} else if (buffer_delay(bh)) {
- if (type = XFS_IO_DELALLOC);
+ if (type = XFS_IO_DELALLOC)
return true;
} else if (buffer_dirty(bh) && buffer_mapped(bh)) {
- if (type = XFS_IO_OVERWRITE);
+ if (type = XFS_IO_OVERWRITE)
return true;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [patch] xfs: extra semi-colon breaks a condition
2014-03-28 8:03 ` Dan Carpenter
@ 2014-03-28 12:09 ` Brian Foster
-1 siblings, 0 replies; 9+ messages in thread
From: Brian Foster @ 2014-03-28 12:09 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, xfs
On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
> if (type == XFS_IO_UNWRITTEN)
> return true;
> } else if (buffer_delay(bh)) {
> - if (type == XFS_IO_DELALLOC);
> + if (type == XFS_IO_DELALLOC)
> return true;
> } else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> - if (type == XFS_IO_OVERWRITE);
> + if (type == XFS_IO_OVERWRITE)
> return true;
> }
>
Nice catch.
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] xfs: extra semi-colon breaks a condition
@ 2014-03-28 12:09 ` Brian Foster
0 siblings, 0 replies; 9+ messages in thread
From: Brian Foster @ 2014-03-28 12:09 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, xfs
On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
> if (type = XFS_IO_UNWRITTEN)
> return true;
> } else if (buffer_delay(bh)) {
> - if (type = XFS_IO_DELALLOC);
> + if (type = XFS_IO_DELALLOC)
> return true;
> } else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> - if (type = XFS_IO_OVERWRITE);
> + if (type = XFS_IO_OVERWRITE)
> return true;
> }
>
Nice catch.
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] xfs: extra semi-colon breaks a condition
2014-03-28 8:03 ` Dan Carpenter
@ 2014-03-29 1:56 ` Eric Sandeen
-1 siblings, 0 replies; 9+ messages in thread
From: Eric Sandeen @ 2014-03-29 1:56 UTC (permalink / raw)
To: Dan Carpenter, Dave Chinner; +Cc: kernel-janitors, xfs
On 3/28/14, 3:03 AM, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
that's terrifying.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
> if (type == XFS_IO_UNWRITTEN)
> return true;
> } else if (buffer_delay(bh)) {
> - if (type == XFS_IO_DELALLOC);
> + if (type == XFS_IO_DELALLOC)
> return true;
> } else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> - if (type == XFS_IO_OVERWRITE);
> + if (type == XFS_IO_OVERWRITE)
> return true;
> }
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] xfs: extra semi-colon breaks a condition
@ 2014-03-29 1:56 ` Eric Sandeen
0 siblings, 0 replies; 9+ messages in thread
From: Eric Sandeen @ 2014-03-29 1:56 UTC (permalink / raw)
To: Dan Carpenter, Dave Chinner; +Cc: kernel-janitors, xfs
On 3/28/14, 3:03 AM, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
that's terrifying.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
> if (type = XFS_IO_UNWRITTEN)
> return true;
> } else if (buffer_delay(bh)) {
> - if (type = XFS_IO_DELALLOC);
> + if (type = XFS_IO_DELALLOC)
> return true;
> } else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> - if (type = XFS_IO_OVERWRITE);
> + if (type = XFS_IO_OVERWRITE)
> return true;
> }
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] xfs: extra semi-colon breaks a condition
2014-03-29 1:56 ` Eric Sandeen
(?)
@ 2014-03-29 2:08 ` Raphael S Carvalho
-1 siblings, 0 replies; 9+ messages in thread
From: Raphael S Carvalho @ 2014-03-29 2:08 UTC (permalink / raw)
To: Eric Sandeen; +Cc: kernel-janitors, Dan Carpenter, xfs
[-- Attachment #1.1: Type: text/plain, Size: 1699 bytes --]
On Fri, Mar 28, 2014 at 10:56 PM, Eric Sandeen <sandeen@sandeen.net> wrote:
> On 3/28/14, 3:03 AM, Dan Carpenter wrote:
> > There were some extra semi-colons here which mean that we return true
> > unintentionally.
> >
> > Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
>
> that's terrifying.
>
Wonder how errors like this one get into the kernel :-) Suppose it's not
the main tree, but instead xfs private one.
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> > index 98016b3..75df77d 100644
> > --- a/fs/xfs/xfs_aops.c
> > +++ b/fs/xfs/xfs_aops.c
> > @@ -659,10 +659,10 @@ xfs_check_page_type(
> > if (type == XFS_IO_UNWRITTEN)
> > return true;
> > } else if (buffer_delay(bh)) {
> > - if (type == XFS_IO_DELALLOC);
> > + if (type == XFS_IO_DELALLOC)
> > return true;
> > } else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> > - if (type == XFS_IO_OVERWRITE);
> > + if (type == XFS_IO_OVERWRITE)
> > return true;
> > }
> >
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Raphael S. Carvalho
[-- Attachment #1.2: Type: text/html, Size: 2999 bytes --]
[-- Attachment #2: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] xfs: extra semi-colon breaks a condition
2014-03-28 8:03 ` Dan Carpenter
@ 2014-04-03 19:36 ` Dave Chinner
-1 siblings, 0 replies; 9+ messages in thread
From: Dave Chinner @ 2014-04-03 19:36 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, xfs
On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Dan, $BEVVIE_OF_CHOICE is on me next time we are in the same place.
And bring a handful brown paper bags as well because there's a few
people here that need to wear them for a while. :/
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] xfs: extra semi-colon breaks a condition
@ 2014-04-03 19:36 ` Dave Chinner
0 siblings, 0 replies; 9+ messages in thread
From: Dave Chinner @ 2014-04-03 19:36 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, xfs
On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Dan, $BEVVIE_OF_CHOICE is on me next time we are in the same place.
And bring a handful brown paper bags as well because there's a few
people here that need to wear them for a while. :/
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-04-03 19:36 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-28 8:03 [patch] xfs: extra semi-colon breaks a condition Dan Carpenter
2014-03-28 8:03 ` Dan Carpenter
2014-03-28 12:09 ` Brian Foster
2014-03-28 12:09 ` Brian Foster
2014-03-29 1:56 ` Eric Sandeen
2014-03-29 1:56 ` Eric Sandeen
2014-03-29 2:08 ` Raphael S Carvalho
2014-04-03 19:36 ` Dave Chinner
2014-04-03 19:36 ` Dave Chinner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.