All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Fariya Fatima <fariyaf@gmail.com>,
	linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] rsi: rsi_91x: misleading debug printk
Date: Fri, 28 Mar 2014 09:07:49 -0400	[thread overview]
Message-ID: <20140328130748.GJ31168@tuxdriver.com> (raw)
In-Reply-To: <20140328082733.GK25192@mwanda>

;-)

goto fail;
goto fail;

Thanks, Dan!

On Fri, Mar 28, 2014 at 11:27:33AM +0300, Dan Carpenter wrote:
> There is a missing set of curly braces here so the debug output says
> "Probe confirm received" unintentionally.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
> index ef37d4b..2361a68 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
> @@ -1292,10 +1292,11 @@ int rsi_mgmt_pkt_recv(struct rsi_common *common, u8 *msg)
>  			return -EINVAL;
>  		}
>  	} else if (msg_type == TX_STATUS_IND) {
> -		if (msg[15] == PROBEREQ_CONFIRM)
> +		if (msg[15] == PROBEREQ_CONFIRM) {
>  			common->mgmt_q_block = false;
>  			rsi_dbg(FSM_ZONE, "%s: Probe confirm received\n",
>  				__func__);
> +		}
>  	} else {
>  		return rsi_mgmt_pkt_to_core(common, msg, msg_len, msg_type);
>  	}
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Fariya Fatima <fariyaf@gmail.com>,
	linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] rsi: rsi_91x: misleading debug printk
Date: Fri, 28 Mar 2014 13:07:49 +0000	[thread overview]
Message-ID: <20140328130748.GJ31168@tuxdriver.com> (raw)
In-Reply-To: <20140328082733.GK25192@mwanda>

;-)

goto fail;
goto fail;

Thanks, Dan!

On Fri, Mar 28, 2014 at 11:27:33AM +0300, Dan Carpenter wrote:
> There is a missing set of curly braces here so the debug output says
> "Probe confirm received" unintentionally.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
> index ef37d4b..2361a68 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
> @@ -1292,10 +1292,11 @@ int rsi_mgmt_pkt_recv(struct rsi_common *common, u8 *msg)
>  			return -EINVAL;
>  		}
>  	} else if (msg_type = TX_STATUS_IND) {
> -		if (msg[15] = PROBEREQ_CONFIRM)
> +		if (msg[15] = PROBEREQ_CONFIRM) {
>  			common->mgmt_q_block = false;
>  			rsi_dbg(FSM_ZONE, "%s: Probe confirm received\n",
>  				__func__);
> +		}
>  	} else {
>  		return rsi_mgmt_pkt_to_core(common, msg, msg_len, msg_type);
>  	}
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2014-03-28 13:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28  8:27 [patch] rsi: rsi_91x: misleading debug printk Dan Carpenter
2014-03-28  8:27 ` Dan Carpenter
2014-03-28 13:07 ` John W. Linville [this message]
2014-03-28 13:07   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140328130748.GJ31168@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=dan.carpenter@oracle.com \
    --cc=fariyaf@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.