* btrfs send/receive still gets out of sync in 3.14.0
@ 2014-03-22 21:04 Marc MERLIN
2014-03-30 3:22 ` Marc MERLIN
2014-04-22 16:07 ` David Brown
0 siblings, 2 replies; 8+ messages in thread
From: Marc MERLIN @ 2014-03-22 21:04 UTC (permalink / raw)
To: linux-btrfs
After deleting a huge directory tree in my /home subvolume, syncing
snapshots now fails with:
ERROR: rmdir o1952777-157-0 failed. No such file or directory
Error line 156 with status 1
DIE: Code dump:
153 if [[ -n "$init" ]]; then
154 btrfs send "$src_newsnap" | $ssh btrfs receive "$dest_pool/"
155 else
156 btrfs send -p "$src_snap" "$src_newsnap" | $ssh btrfs receive "$dest_pool/"
157 fi
158
159 # We make a read-write snapshot in case you want to use it for a chroot
Is there anything useful I can provide before killing my snapshot and doing
a full sync again?
Thanks,
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs send/receive still gets out of sync in 3.14.0
2014-03-22 21:04 btrfs send/receive still gets out of sync in 3.14.0 Marc MERLIN
@ 2014-03-30 3:22 ` Marc MERLIN
2014-03-30 12:42 ` Hugo Mills
2014-04-22 16:07 ` David Brown
1 sibling, 1 reply; 8+ messages in thread
From: Marc MERLIN @ 2014-03-30 3:22 UTC (permalink / raw)
To: linux-btrfs
On Sat, Mar 22, 2014 at 02:04:56PM -0700, Marc MERLIN wrote:
> After deleting a huge directory tree in my /home subvolume, syncing
> snapshots now fails with:
>
> ERROR: rmdir o1952777-157-0 failed. No such file or directory
So, I'm ok again after I deleted my destination snapshot and re-init'ed,
but on multi terabyte backups, this ain't great :)
Do I need to file a bug that btrfs send/receive still gets out of sync
in 3.14, or is it already known and maybe even fixed in btrfs-next?
Thanks,
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs send/receive still gets out of sync in 3.14.0
2014-03-30 3:22 ` Marc MERLIN
@ 2014-03-30 12:42 ` Hugo Mills
2014-03-30 13:13 ` Filipe David Manana
0 siblings, 1 reply; 8+ messages in thread
From: Hugo Mills @ 2014-03-30 12:42 UTC (permalink / raw)
To: Marc MERLIN; +Cc: linux-btrfs, Filipe David Borba Manana
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On Sat, Mar 29, 2014 at 08:22:02PM -0700, Marc MERLIN wrote:
> On Sat, Mar 22, 2014 at 02:04:56PM -0700, Marc MERLIN wrote:
> > After deleting a huge directory tree in my /home subvolume, syncing
> > snapshots now fails with:
> >
> > ERROR: rmdir o1952777-157-0 failed. No such file or directory
>
> So, I'm ok again after I deleted my destination snapshot and re-init'ed,
> but on multi terabyte backups, this ain't great :)
>
> Do I need to file a bug that btrfs send/receive still gets out of sync
> in 3.14, or is it already known and maybe even fixed in btrfs-next?
Filipe has been posting a series of patches related to send/receive
recently, so this may be related to those bugs.
Hugo.
--
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
PGP key: 65E74AC0 from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
--- Gort! Klaatu barada nikto! ---
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs send/receive still gets out of sync in 3.14.0
2014-03-30 12:42 ` Hugo Mills
@ 2014-03-30 13:13 ` Filipe David Manana
2014-03-30 14:27 ` Marc MERLIN
0 siblings, 1 reply; 8+ messages in thread
From: Filipe David Manana @ 2014-03-30 13:13 UTC (permalink / raw)
To: Hugo Mills, Marc MERLIN, linux-btrfs, Filipe David Borba Manana
On Sun, Mar 30, 2014 at 1:42 PM, Hugo Mills <hugo@carfax.org.uk> wrote:
> On Sat, Mar 29, 2014 at 08:22:02PM -0700, Marc MERLIN wrote:
>> On Sat, Mar 22, 2014 at 02:04:56PM -0700, Marc MERLIN wrote:
>> > After deleting a huge directory tree in my /home subvolume, syncing
>> > snapshots now fails with:
>> >
>> > ERROR: rmdir o1952777-157-0 failed. No such file or directory
>>
>> So, I'm ok again after I deleted my destination snapshot and re-init'ed,
>> but on multi terabyte backups, this ain't great :)
>>
>> Do I need to file a bug that btrfs send/receive still gets out of sync
>> in 3.14, or is it already known and maybe even fixed in btrfs-next?
>
> Filipe has been posting a series of patches related to send/receive
> recently, so this may be related to those bugs.
Yes, this one in particular might have fixed the issue:
http://git.kernel.org/cgit/linux/kernel/git/josef/btrfs-next.git/commit/?id=29d6d30f5c8aa58b04f40a58442df3bcaae5a1d5
(There might be other cases that attempt to rmdir a non-existing
orphan directory)
>
> Hugo.
>
> --
> === Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
> PGP key: 65E74AC0 from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
> --- Gort! Klaatu barada nikto! ---
--
Filipe David Manana,
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs send/receive still gets out of sync in 3.14.0
2014-03-30 13:13 ` Filipe David Manana
@ 2014-03-30 14:27 ` Marc MERLIN
2014-03-30 15:14 ` Filipe David Manana
0 siblings, 1 reply; 8+ messages in thread
From: Marc MERLIN @ 2014-03-30 14:27 UTC (permalink / raw)
To: Filipe David Manana; +Cc: Hugo Mills, linux-btrfs
On Sun, Mar 30, 2014 at 02:13:35PM +0100, Filipe David Manana wrote:
> On Sun, Mar 30, 2014 at 1:42 PM, Hugo Mills <hugo@carfax.org.uk> wrote:
> > On Sat, Mar 29, 2014 at 08:22:02PM -0700, Marc MERLIN wrote:
> >> On Sat, Mar 22, 2014 at 02:04:56PM -0700, Marc MERLIN wrote:
> >> > After deleting a huge directory tree in my /home subvolume, syncing
> >> > snapshots now fails with:
> >> >
> >> > ERROR: rmdir o1952777-157-0 failed. No such file or directory
> >>
> >> So, I'm ok again after I deleted my destination snapshot and re-init'ed,
> >> but on multi terabyte backups, this ain't great :)
> >>
> >> Do I need to file a bug that btrfs send/receive still gets out of sync
> >> in 3.14, or is it already known and maybe even fixed in btrfs-next?
> >
> > Filipe has been posting a series of patches related to send/receive
> > recently, so this may be related to those bugs.
>
> Yes, this one in particular might have fixed the issue:
>
> http://git.kernel.org/cgit/linux/kernel/git/josef/btrfs-next.git/commit/?id=29d6d30f5c8aa58b04f40a58442df3bcaae5a1d5
>
> (There might be other cases that attempt to rmdir a non-existing
> orphan directory)
Cool, thanks for fixing those.
Is that meant to make it in 3.14 final, or is it going to be 3.15?
Thanks,
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs send/receive still gets out of sync in 3.14.0
2014-03-30 14:27 ` Marc MERLIN
@ 2014-03-30 15:14 ` Filipe David Manana
2014-03-30 23:01 ` Marc MERLIN
0 siblings, 1 reply; 8+ messages in thread
From: Filipe David Manana @ 2014-03-30 15:14 UTC (permalink / raw)
To: Marc MERLIN; +Cc: Hugo Mills, linux-btrfs
On Sun, Mar 30, 2014 at 3:27 PM, Marc MERLIN <marc@merlins.org> wrote:
> On Sun, Mar 30, 2014 at 02:13:35PM +0100, Filipe David Manana wrote:
>> On Sun, Mar 30, 2014 at 1:42 PM, Hugo Mills <hugo@carfax.org.uk> wrote:
>> > On Sat, Mar 29, 2014 at 08:22:02PM -0700, Marc MERLIN wrote:
>> >> On Sat, Mar 22, 2014 at 02:04:56PM -0700, Marc MERLIN wrote:
>> >> > After deleting a huge directory tree in my /home subvolume, syncing
>> >> > snapshots now fails with:
>> >> >
>> >> > ERROR: rmdir o1952777-157-0 failed. No such file or directory
>> >>
>> >> So, I'm ok again after I deleted my destination snapshot and re-init'ed,
>> >> but on multi terabyte backups, this ain't great :)
>> >>
>> >> Do I need to file a bug that btrfs send/receive still gets out of sync
>> >> in 3.14, or is it already known and maybe even fixed in btrfs-next?
>> >
>> > Filipe has been posting a series of patches related to send/receive
>> > recently, so this may be related to those bugs.
>>
>> Yes, this one in particular might have fixed the issue:
>>
>> http://git.kernel.org/cgit/linux/kernel/git/josef/btrfs-next.git/commit/?id=29d6d30f5c8aa58b04f40a58442df3bcaae5a1d5
>>
>> (There might be other cases that attempt to rmdir a non-existing
>> orphan directory)
>
> Cool, thanks for fixing those.
> Is that meant to make it in 3.14 final, or is it going to be 3.15?
My guess is 3.15.
>
> Thanks,
> Marc
> --
> "A mouse is a device used to point at the xterm you want to type in" - A.S.R.
> Microsoft is to operating systems ....
> .... what McDonalds is to gourmet cooking
> Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
--
Filipe David Manana,
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs send/receive still gets out of sync in 3.14.0
2014-03-30 15:14 ` Filipe David Manana
@ 2014-03-30 23:01 ` Marc MERLIN
0 siblings, 0 replies; 8+ messages in thread
From: Marc MERLIN @ 2014-03-30 23:01 UTC (permalink / raw)
To: Filipe David Manana; +Cc: Hugo Mills, linux-btrfs
On Sun, Mar 30, 2014 at 04:14:59PM +0100, Filipe David Manana wrote:
> > Cool, thanks for fixing those.
> > Is that meant to make it in 3.14 final, or is it going to be 3.15?
>
> My guess is 3.15.
Understood. I'll see if I can find your btrfs patches and apply them to
3.14.
Thanks for letting me know.
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs send/receive still gets out of sync in 3.14.0
2014-03-22 21:04 btrfs send/receive still gets out of sync in 3.14.0 Marc MERLIN
2014-03-30 3:22 ` Marc MERLIN
@ 2014-04-22 16:07 ` David Brown
1 sibling, 0 replies; 8+ messages in thread
From: David Brown @ 2014-04-22 16:07 UTC (permalink / raw)
To: Marc MERLIN; +Cc: linux-btrfs
On Sat, Mar 22, 2014 at 02:04:56PM -0700, Marc MERLIN wrote:
>After deleting a huge directory tree in my /home subvolume, syncing
>snapshots now fails with:
>
>ERROR: rmdir o1952777-157-0 failed. No such file or directory
>Error line 156 with status 1
>
> DIE: Code dump:
> 153 if [[ -n "$init" ]]; then
> 154 btrfs send "$src_newsnap" | $ssh btrfs receive "$dest_pool/"
> 155 else
> 156 btrfs send -p "$src_snap" "$src_newsnap" | $ssh btrfs receive "$dest_pool/"
> 157 fi
> 158
> 159 # We make a read-write snapshot in case you want to use it for a chroot
>
>
>Is there anything useful I can provide before killing my snapshot and doing
>a full sync again?
I have been able to work around this by hacking up btrfs receive to
ignore the rmdir. As far as I can tell (tree comparison) the
resulting tree is correct.
David
diff --git a/cmds-receive.c b/cmds-receive.c
index d6cd3da..5bd4161 100644
--- a/cmds-receive.c
+++ b/cmds-receive.c
@@ -492,6 +492,9 @@ static int process_rmdir(const char *path, void *user)
fprintf(stderr, "ERROR: rmdir %s failed. %s\n", path,
strerror(-ret));
}
+ // Ugly hack to work around kernel problem of sending
+ // redundant rmdirs.
+ ret = 0;
free(full_path);
return ret;
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-04-22 16:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-22 21:04 btrfs send/receive still gets out of sync in 3.14.0 Marc MERLIN
2014-03-30 3:22 ` Marc MERLIN
2014-03-30 12:42 ` Hugo Mills
2014-03-30 13:13 ` Filipe David Manana
2014-03-30 14:27 ` Marc MERLIN
2014-03-30 15:14 ` Filipe David Manana
2014-03-30 23:01 ` Marc MERLIN
2014-04-22 16:07 ` David Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.