From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: Linux Stable <stable@vger.kernel.org>,
XFS Mailing List <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix bad hash ordering
Date: Mon, 31 Mar 2014 11:10:56 +1100 [thread overview]
Message-ID: <20140331001055.GD16336@dastard> (raw)
In-Reply-To: <20140328173430.622616177@sgi.com>
On Fri, Mar 28, 2014 at 12:33:34PM -0500, Mark Tinguely wrote:
> Fix the fix directory "bad hash ordering" bug introduced in
> commit f5ea1100.
The patch looks like it fixes a hashing issue, but I really can't
tell what hashing issue it fixes from the commit message.
I don't know if you've identified the right commit just by looking
at it - to confirm you've quoted the correct hash I have to find it,
parse it, read the diff and try and work out whether it could have
introduced some bug that you haven't described....
.... introduced in commit f5ea110 ("xfs: add CRCs to dir2/da node
blocks") ....
is far more informative, even for the causal reader....
Secondly, reading that commit subject and message in isolation,
it didn't even occur to me that this is a fix for a filesystem
corruption bug. Any distro maintainer reading the commit logs won't
have any idea that they need to pick this up, either.
IOWs, it is extremely important that the commit message for a
filesystem corruption bug fix to be clearly marked as fixing a
corruption bug, explain what the bug is, what they user visible
symptoms are, what the impact of the corruption is, how likely users
are going to be impacted by it, whether is causes permanent loss
of data or not, etc. This doesn't belong in a throw-away comment to
your fix...
> ---
> A C program that generates this problem can be found at:
> http://oss.sgi.com/archives/xfs/2014-03/msg00373.html
>
> A xfstest for this bug is coming from Hannes Frederic Sowa.
Can you convert this program to an xfstest yourself so that I can
commit the regression test at the same time I commit an updated
fix?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-31 0:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 17:33 [PATCH] xfs: fix bad hash ordering Mark Tinguely
2014-03-28 19:07 ` Ben Myers
2014-03-31 0:10 ` Dave Chinner [this message]
2014-03-31 0:35 ` Eric Sandeen
2014-03-31 16:42 ` Mark Tinguely
2014-03-31 21:40 ` Dave Chinner
2014-04-01 2:22 ` Mark Tinguely
2014-04-01 22:03 ` Dave Chinner
2014-04-07 19:00 ` [PATCH] xfsprogs: fix directory hash ordering bug Mark Tinguely
2014-04-08 8:56 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331001055.GD16336@dastard \
--to=david@fromorbit.com \
--cc=stable@vger.kernel.org \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.